Remove WebRTC custom sidebar

[wbamberg]

This PR removes all references to the custom sidebar implemented by the WebRTCSidebar macro, and replaces them with references to the standard DefaultAPISidebar.

The WebRTCSidebar macro doesn't really have any features missing in DefaultAPISidebar. In fact, there is already a group for WebRTC in groupdata.json, and the WebRTC overview page already uses DefaultAPISidebar (https://developer.mozilla.org/en-US/docs/Web/API/WebRTC_API) although its children don't.

Because the usage of this sidebar is quite inconsistent, this PR makes a few different changes:

• I fixed three pages that should be using APIRef:
  • https://developer.mozilla.org/en-US/docs/Web/API/RTCIceTransport/statechange_event
  • https://developer.mozilla.org/en-US/docs/Web/API/RTCPeerConnection/currentLocalDescription
  • https://developer.mozilla.org/en-US/docs/web/api/rtcdtmfsender/tonechange_event
• I deleted https://developer.mozilla.org/en-US/docs/Web/Guide/API/WebRTC/Peer-to-peer_communications_with_WebRTC and redirected it to the main page
• everything under https://developer.mozilla.org/en-US/docs/Web/API/WebRTC_API I updated to use DefaultAPISidebar. Some of these pages were using WebRTCSidebar and some were incorrectly using APIRef.

I also added one guide to the groupdata entry for WebRTC - that was the only relevant thing that seemed to be missing, compared with the custom sidebar contents.

All the other changes are Prettier. I hope that's OK (and sorry about the noise).

After merging this we can deprecate WebRTCSidebar.

[github-actions]

Preview URLs (24 pages)

• /en-US/docs/Web/API/RTCDTMFSender/tonechange_event
• /en-US/docs/Web/API/RTCIceTransport/statechange_event
• /en-US/docs/Web/API/RTCPeerConnection/currentLocalDescription
• /en-US/docs/Web/API/WebRTC_API/Build_a_phone_with_peerjs/Build_the_server
• /en-US/docs/Web/API/WebRTC_API/Build_a_phone_with_peerjs/Connect_peers/Answer_a_call
• /en-US/docs/Web/API/WebRTC_API/Build_a_phone_with_peerjs/Connect_peers/Create_a_peer_connection
• /en-US/docs/Web/API/WebRTC_API/Build_a_phone_with_peerjs/Connect_peers/Creating_a_call
• /en-US/docs/Web/API/WebRTC_API/Build_a_phone_with_peerjs/Connect_peers/Get_microphone_permission
• /en-US/docs/Web/API/WebRTC_API/Build_a_phone_with_peerjs/Connect_peers/Show_hide_html
• /en-US/docs/Web/API/WebRTC_API/Build_a_phone_with_peerjs/Connect_peers
• /en-US/docs/Web/API/WebRTC_API/Build_a_phone_with_peerjs/Deployment_and_further_reading
• /en-US/docs/Web/API/WebRTC_API/Build_a_phone_with_peerjs/Setup
• /en-US/docs/Web/API/WebRTC_API/Build_a_phone_with_peerjs
• /en-US/docs/Web/API/WebRTC_API/Connectivity
• /en-US/docs/Web/API/WebRTC_API/Intro_to_RTP
• /en-US/docs/Web/API/WebRTC_API/Perfect_negotiation
• /en-US/docs/Web/API/WebRTC_API/Protocols
• /en-US/docs/Web/API/WebRTC_API/Session_lifetime
• /en-US/docs/Web/API/WebRTC_API/Signaling_and_video_calling
• /en-US/docs/Web/API/WebRTC_API/Simple_RTCDataChannel_sample
• /en-US/docs/Web/API/WebRTC_API/Using_DTMF
• /en-US/docs/Web/API/WebRTC_API/Using_data_channels
• /en-US/docs/Web/API/WebRTC_API/adapter.js
• /en-US/docs/Web/API/WebRTC_API/build_a_phone_with_peerjs/connect_peers/End_a_call

Flaws (11)

Note! 18 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/RTCDTMFSender/tonechange_event
Title: RTCDTMFSender: tonechange event
Flaw count: 1

• broken_links:
  • Link points to the page it's already on

---

URL: /en-US/docs/Web/API/WebRTC_API/Using_DTMF
Title: Using DTMF with WebRTC
Flaw count: 5

• macros:
  • /en-US/docs/Web/API/MediaConstraints does not exist
  • /en-US/docs/Web/API/RTCPeerConnection/createDTMFSender does not exist
  • /en-US/docs/Web/API/RTCPeerConnection/getTracks does not exist
  • /en-US/docs/Web/API/RTCTrackEvent/stream does not exist
  • The fourth to sixth parameters of 'EmbedLiveSample' are deprecated

---

URL: /en-US/docs/Web/API/WebRTC_API/adapter.js
Title: Improving compatibility using WebRTC adapter.js
Flaw count: 1

• macros:
  • /en-US/docs/Web/API/RTCPeerConnection/urls does not exist

---

URL: /en-US/docs/Web/API/WebRTC_API/Build_a_phone_with_peerjs
Title: Building an Internet-Connected Phone with PeerJS
Flaw count: 1

• broken_links:
  • Can't resolve /en-US/docs/Web/API/WebRTC_API/Build_a_phone_with_peerjs/Connect_peers/End_a_call

---

URL: /en-US/docs/Web/API/WebRTC_API/Signaling_and_video_calling
Title: Signaling and video calling
Flaw count: 2

• macros:
  • /en-US/docs/Web/API/RTCPeerConnection/removetrack_event does not exist
  • /en-US/docs/Web/API/HTMLElement/disabled does not exist

---

URL: /en-US/docs/Web/API/WebRTC_API/Simple_RTCDataChannel_sample
Title: A simple RTCDataChannel sample
Flaw count: 1

• macros:
  • /en-US/docs/Web/API/EventListener redirects to /en-US/docs/Web/API/EventTarget/addEventListener

(this comment was updated 2022-11-24 12:20:54.092833)

[bsmth]

Taking a look shortly 👀

[bsmth]

• Prettier formatting looks good
• Sidebars look better
• Redirects look good

Why are we deleting https://developer.mozilla.org/en-US/docs/Web/Guide/API/WebRTC/Peer-to-peer_communications_with_WebRTC ?

[bsmth]

Thanks @wbamberg, LGTM 👍🏻

Once comment open about rationale for deleting the page, everything else looks good.

[wbamberg]

• Prettier formatting looks good

  • Sidebars look better

  • Redirects look good

Why are we deleting https://developer.mozilla.org/en-US/docs/Web/Guide/API/WebRTC/Peer-to-peer_communications_with_WebRTC ?

Because:

• it doesn't fit into any IA we have: it's not integrated at all with the other WebRTC docs, and isn't even linked from anywhere in the site. So it's basically impossible to find.
• I don't think it adds anything over https://developer.mozilla.org/en-US/docs/Web/API/WebRTC_API

[bsmth]

Thank you, merging now 👍🏻