Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: macro deprecation: CanvasSidebar should be removed #10516

Closed
7 tasks done
wbamberg opened this issue Dec 6, 2022 · 1 comment
Closed
7 tasks done

Chore: macro deprecation: CanvasSidebar should be removed #10516

wbamberg opened this issue Dec 6, 2022 · 1 comment
Labels
l10n-pt-br Issues related to Brazilian Portuguese l10n-ru Issues related to Russian content.
Milestone
Macros removal

Comments

@wbamberg
Copy link
Contributor

wbamberg commented Dec 6, 2022 •
edited by queengooborg
Loading

👋 l10n people!

Following on from #10177, I'm still working on removing custom sidebars from the Web/API docs. This time we are retiring the CanvasSidebar.ejs macro.

In mdn/content#22586 I removed references to CanvasSidebar from en-US content, and in mdn/yari#7760 I've deprecated it.

Note that this also uses the new "Tutorial" string from L10n-Common.json, so if you think the value given there is wrong for your locale, please make a PR against that file and tag me for a review :).

After this there is one more custom sidebar left, WebGLSidebar.ejs, which will be coming up soon!

TODO:
@yin1999 yin1999 added l10n-ja Issues related to Japanese content. l10n-fr Issues related to French content. l10n-zh Issues related to Chinese content. l10n-es Issues related to Spanish content. l10n-ru Issues related to Russian content. l10n-ko Issues related to Korean content. l10n-pt-br Issues related to Brazilian Portuguese labels Dec 7, 2022
@Graywolf9 Graywolf9 mentioned this issue Dec 7, 2022
Merged
@wbamberg wbamberg mentioned this issue Dec 7, 2022
Closed
7 tasks
@yin1999 yin1999 removed l10n-zh Issues related to Chinese content. l10n-es Issues related to Spanish content. labels Dec 8, 2022
@notJoon notJoon mentioned this issue Dec 9, 2022
Merged
@yin1999 yin1999 removed the l10n-ko Issues related to Korean content. label Dec 10, 2022
@cw118 cw118 mentioned this issue Dec 10, 2022
Merged
@cw118 cw118 added this to the Macros removal milestone Dec 10, 2022
@SphinxKnight SphinxKnight removed the l10n-fr Issues related to French content. label Dec 14, 2022
@YujiSoftware YujiSoftware mentioned this issue Dec 17, 2022
Merged
@mfuji09 mfuji09 removed the l10n-ja Issues related to Japanese content. label Feb 5, 2023
@queengooborg queengooborg mentioned this issue Feb 12, 2023
Closed
@queengooborg
Copy link
Collaborator

All {{CanvasSidebar}} instances have been removed now, thanks to all for your hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
l10n-pt-br Issues related to Brazilian Portuguese l10n-ru Issues related to Russian content.
Projects
MDN Localization
Status: Done
Milestone
Macros removal
Development

No branches or pull requests
6 participants
@wbamberg @SphinxKnight @queengooborg @mfuji09 @yin1999 @cw118