Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add font stretch CSS example #1799

Merged
merged 6 commits into from
Apr 29, 2021
Merged

Add font stretch CSS example #1799

merged 6 commits into from
Apr 29, 2021

Conversation

tannerdolby
Copy link
Contributor

@tannerdolby tannerdolby commented Apr 15, 2021

Fixes #573

I used the "Regular" style .ttf file from League Mono, but the text seems a bit "light", might just be me. Below is a demo of the working example in Chrome, (works in Firefox too).

font-stretch-demo.mov

@welcome
Copy link

welcome bot commented Apr 15, 2021

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line:

  • If this is a new or updated CSS interactive example, please ensure that you followed the CSS styleguide - If this is a new or updated JavaScript interactive example, please ensure that you followed the JavaScript styleguide - If your changes affects any of the steps in our contribution docs, please also make the relevant changes there.

@escattone
Copy link
Contributor

@tannerdolby Just FYI, if you merge the master branch into your PR, the build should work again.

@tannerdolby
Copy link
Contributor Author

@escattone Ok thanks for the heads up. Want me to merge master into this PR with another commit or is it fine in its current form?

@escattone
Copy link
Contributor

@escattone Ok thanks for the heads up. Want me to merge master into this PR with another commit or is it fine in its current form?

@tannerdolby You could either merge master into this PR with another commit, or rebase your PR on master if you'd prefer. Thanks.

@tannerdolby
Copy link
Contributor Author

tannerdolby commented Apr 16, 2021

Merged my feature branch with master and the build is working now.

@tannerdolby
Copy link
Contributor Author

@escattone Let me know if you need me to make any changes before this is ready to merge.

@escattone escattone requested a review from wbamberg April 27, 2021 23:46
@escattone
Copy link
Contributor

@wbamberg I just added you to this repo with maintainer privileges (which I should have done long ago, sorry!), and then also added you as the reviewer.

@tannerdolby All you need is @wbamberg's review/approval. Thanks for your work on this!

@tannerdolby
Copy link
Contributor Author

@escattone No problem! And thank you for initiating the review/approval from @wbamberg

Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @escattone ! It's been a while since I reviewed one of these :).

Thanks for the PR @tannerdolby ! I agree it does look a bit light. I suggested changing font-weight, unless there's a reason you went with 100 here. Apart from that this looks great.

live-examples/css-examples/fonts/font-stretch.css Outdated Show resolved Hide resolved
Copy link
Contributor

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 awesome, thanks @tannerdolby !

@wbamberg wbamberg merged commit 8a93979 into mdn:master Apr 29, 2021
@welcome
Copy link

welcome bot commented Apr 29, 2021

Congrats on merging your first pull request! 🎉🎉🎉

@wbamberg
Copy link
Contributor

Thanks for your contribution @tannerdolby ! It's already live at https://interactive-examples.mdn.mozilla.net/pages/css/font-stretch.html .

If you want to do the last bit, so this example shows up on MDN, we need to update https://developer.mozilla.org/en-US/docs/Web/CSS/font-stretch over in https://github.com/mdn/content/tree/main/files/en-us/web/css/font-stretch , replacing the big grey box at the top with a macro call like:

<div>{{EmbedInteractiveExample("pages/css/font-stretch.html")}}</div>

Then we can merge that and the new example will be live on MDN.

@tannerdolby
Copy link
Contributor Author

Fully completed when #4608 is merged in mdn/content 🎉

@tannerdolby tannerdolby deleted the 573-add-font-stretch-example branch April 29, 2021 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS examples: need example for font-stretch
3 participants