-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add font stretch CSS example #1799
Add font stretch CSS example #1799
Conversation
💖 Thanks for opening this pull request! 💖
|
@tannerdolby Just FYI, if you merge the |
@escattone Ok thanks for the heads up. Want me to merge |
@tannerdolby You could either merge |
Merged my feature branch with |
@escattone Let me know if you need me to make any changes before this is ready to merge. |
@wbamberg I just added you to this repo with maintainer privileges (which I should have done long ago, sorry!), and then also added you as the reviewer. @tannerdolby All you need is @wbamberg's review/approval. Thanks for your work on this! |
@escattone No problem! And thank you for initiating the review/approval from @wbamberg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @escattone ! It's been a while since I reviewed one of these :).
Thanks for the PR @tannerdolby ! I agree it does look a bit light. I suggested changing font-weight
, unless there's a reason you went with 100
here. Apart from that this looks great.
Co-authored-by: wbamberg <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 awesome, thanks @tannerdolby !
Congrats on merging your first pull request! 🎉🎉🎉 |
Thanks for your contribution @tannerdolby ! It's already live at https://interactive-examples.mdn.mozilla.net/pages/css/font-stretch.html . If you want to do the last bit, so this example shows up on MDN, we need to update https://developer.mozilla.org/en-US/docs/Web/CSS/font-stretch over in https://github.com/mdn/content/tree/main/files/en-us/web/css/font-stretch , replacing the big grey box at the top with a macro call like:
Then we can merge that and the new example will be live on MDN. |
Fully completed when #4608 is merged in |
Fixes #573
I used the "Regular" style
.ttf
file from League Mono, but the text seems a bit "light", might just be me. Below is a demo of the working example in Chrome, (works in Firefox too).font-stretch-demo.mov