Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EmbedInteractiveExample macro for font-stretch page #4608

Merged
merged 1 commit into from
Apr 29, 2021
Merged

Add EmbedInteractiveExample macro for font-stretch page #4608

merged 1 commit into from
Apr 29, 2021

Conversation

tannerdolby
Copy link
Contributor

Mentioned in this comment that to finish the interactive example addition that the macro needed to be inserted to font-stretch.html.

URL changed: https://developer.mozilla.org/en-US/docs/Web/CSS/font-stretch

Associated Issue and PR: Completes #573 from mdn/interactive-examples. Related PR #799

@tannerdolby tannerdolby requested a review from a team as a code owner April 29, 2021 21:59
@tannerdolby tannerdolby requested review from rachelandrew and removed request for a team April 29, 2021 21:59
@github-actions
Copy link
Contributor

Preview URLs

Flaws

URL: /en-US/docs/Web/CSS/font-stretch
Title: font-stretch
on GitHub
Flaw count: 1

  • broken_links:
    • http:// external links are not allowed (will be forced to https:// at build-time)

External URLs

URL: /en-US/docs/Web/CSS/font-stretch
Title: font-stretch
on GitHub

@tannerdolby
Copy link
Contributor Author

I moved the "Syntax" subheading above the keyword values as shown in the sibling pages near it like font-size.

Also had a look at the preview url for font-stretch and the demo is working nicely. 🎉

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to me. Thanks for writing this example @tannerdolby !

@wbamberg wbamberg merged commit 28fce80 into mdn:main Apr 29, 2021
@tannerdolby
Copy link
Contributor Author

Ok great. Your welcome @wbamberg !

@tannerdolby tannerdolby deleted the 573-complete-font-stretch-example branch April 29, 2021 22:48
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants