Skip to content

Bug-1958596 dark_theme manifest key documentation#39122

Open
rebloor wants to merge 5 commits intomdn:mainfrom
rebloor:Bug-1958596-dark_theme-manifest-key-documentation
Open

Bug-1958596 dark_theme manifest key documentation#39122
rebloor wants to merge 5 commits intomdn:mainfrom
rebloor:Bug-1958596-dark_theme-manifest-key-documentation

Conversation

@rebloor
Copy link
Contributor

@rebloor rebloor commented Apr 14, 2025

Description

Adds key details and release note for the dark_theme manifest key introduced in Firefox 68 (Bug 1525762) response to comment on Comment 15 on Bug 1958596.

Related issues and pull requests

@rebloor rebloor added the Content:WebExt WebExtensions docs label Apr 14, 2025
@rebloor rebloor self-assigned this Apr 14, 2025
@rebloor rebloor requested review from a team as code owners April 14, 2025 23:48
@rebloor rebloor requested review from dipikabh and jpmedley and removed request for a team April 14, 2025 23:48
@github-actions github-actions bot added Content:Firefox Content in the Mozilla/Firefox subtree size/m [PR only] 51-500 LoC changed labels Apr 14, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 14, 2025

rebloor and others added 3 commits April 15, 2025 14:02
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@dotproto dotproto self-requested a review May 15, 2025 21:18
@dipikabh
Copy link
Contributor

dipikabh commented Jun 2, 2025

I'll remove myself from Reviewers, please add me back if any merge or other support is needed 🙏

@dipikabh dipikabh removed their request for review June 2, 2025 15:29
@github-actions github-actions bot added the merge conflicts 🚧 [PR only] label Jul 14, 2025
@github-actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions github-actions bot removed the merge conflicts 🚧 [PR only] label Jul 15, 2025
@rebloor
Copy link
Contributor Author

rebloor commented Jul 15, 2025

@dotproto a reminder that this is waiting on your review


### Chrome compatibility

In Chrome:
Copy link
Contributor

@dotproto dotproto Dec 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As best I can tell Chrome doesn't support the dark_theme manifest key for themes. @oliverdunk, can you help verify this?

@rebloor rebloor requested a review from Rob--W January 1, 2026 17:51
@pransh15 pransh15 requested a review from bacharakis February 25, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Content:Firefox Content in the Mozilla/Firefox subtree Content:WebExt WebExtensions docs size/m [PR only] 51-500 LoC changed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants