Bug-1958596 dark_theme manifest key support#26511
Merged
Conversation
rebloor
added
the
data:webext
This was referenced Apr 14, 2025
Rob--W
reviewed
Apr 15, 2025
| "__compat": { | ||
| "support": { | ||
| "chrome": { | ||
| "version_added": "≤59" |
Member
There was a problem hiding this comment.
Chrome doesn't support any of the dark_theme properties.
Removed features with no support
Rob--W
approved these changes
May 6, 2025
| "edge": "mirror", | ||
| "firefox": { | ||
| "version_added": "68", | ||
| "notes": "Deprecated in Firefox 89. For details, see the [Changes to themeable areas of Firefox in version 89](https://blog.mozilla.org/addons/2021/04/19/changes-to-themeable-areas-of-firefox-in-version-89/) blog post ." |
Member
There was a problem hiding this comment.
Can we drop removed properties altogether, since it was never documented anyway?
Contributor
Author
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds browser compatibility data for the dark_theme manifest key introduced in Firefox 68 (Bug 1525762) response to comment on Comment 15 on Bug 1958596
Related issues
dark_thememanifest key documentation content#39122dark_themeto theme guide mozilla/extension-workshop#2050