Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipboard.write() - log and fixes #33769

Merged
merged 2 commits into from
May 27, 2024
Merged

Clipboard.write() - log and fixes #33769

merged 2 commits into from
May 27, 2024

Conversation

hamishwillee
Copy link
Collaborator

This follows on from #33262 . Sorry @wbamberg - I cleared your review blocker too quick

The live example doesn't work on Chrome "live" (though it does work on local testing) because of clipboard permissions. It does however work on FF and should work on safari.

What I've done is add a log so that users can see the error on chrome.

Also found a missing trailing CSS bracket.

This is part of #33564

@hamishwillee hamishwillee requested a review from a team as a code owner May 27, 2024 04:03
@hamishwillee hamishwillee requested review from sideshowbarker and removed request for a team May 27, 2024 04:03
@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels May 27, 2024
Copy link
Contributor

Preview URLs

Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thank you for catching that...

@wbamberg wbamberg merged commit ff105a4 into main May 27, 2024
8 checks passed
@wbamberg wbamberg deleted the typo_clibpoardwrite branch May 27, 2024 04:10
wbamberg added a commit to wbamberg/content that referenced this pull request May 28, 2024
* upstream/main: (55 commits)
  Replace `.` with `#` in example given selectors are `#ids` (mdn#33791)
  update info in cross browser testing strategies (mdn#33730)
  Clarify that `navigator.storage.persist()` depends on heuristics (mdn#33780)
  fix typo (mdn#33785)
  feat: improvements on Glossary/Hoisting (mdn#33787)
  CSS update: overview of shapes guide (mdn#33771)
  CSS update: Shapes from box values (mdn#33770)
  Fix issue 033506: correct droppedEntriesCount (mdn#33538)
  Revert "=== Symbol("foo")" (mdn#33782)
  docs(css): FF126 - Support for `shape()` function (mdn#33446)
  Bump lint-staged from 15.2.4 to 15.2.5 (mdn#33777)
  Bump ajv from 8.13.0 to 8.14.0 (mdn#33776)
  Add missing spaces for `subtlecrypto` (mdn#33774)
  fix: typo in `color_and_luminca` (mdn#33775)
  feat: improvments on gutters (mdn#33751)
  FF127Relnote- data: and javascript: URLS forbidden in base HREF (mdn#33738)
  update the content of SVG `<view>` element (mdn#33710)
  Clipboard.write() - log and fixes (mdn#33769)
  updated ClipboardItem and Clipboard documentation and examples using … (mdn#33262)
  Fix error in the code snippet for Symbol (mdn#33765)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants