feat: improvments on gutters #33751
Merged
feat: improvments on gutters #33751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PassionPenguin
requested review from
chrisdavidmills
and removed request for
a team
github-actions
bot
added
Content:Glossary
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Preview URLs External URLs (1)URL:
(comment last updated: 2024-05-27 09:31:43) |
PassionPenguin
commented
May 25, 2024
|
|
||
| ## Example | ||
|
|
||
| In the example below we have a three-column and two-row track grid, with 20-pixel gaps between column tracks and `20px`-gaps between row tracks. | ||
| In the example below we have a three-column and two-row track grid, with `20px` gaps between both column tracks and row tracks. |
There was a problem hiding this comment.
kinda redundant here (mdn/translated-content#20575 (comment))
Comment on lines
63
to
70
| ### Property reference | ||
| - [CSS Grid Layout](/en-US/docs/Web/CSS/CSS_grid_layout/Basic_concepts_of_grid_layout) | ||
| - Property reference | ||
|
|
||
| - {{cssxref("column-gap")}} | ||
| - {{cssxref("row-gap")}} | ||
| - {{cssxref("gap")}} | ||
|
|
||
| - {{cssxref("column-gap")}} | ||
| - {{cssxref("row-gap")}} | ||
| - {{cssxref("gap")}} | ||
|
|
||
| ### Further reading | ||
|
|
||
| - CSS Grid Layout Guide: _[Basic concepts of grid layout](/en-US/docs/Web/CSS/CSS_grid_layout/Basic_concepts_of_grid_layout)_ | ||
| - [Definition of gutters in the CSS Grid Layout specification](https://drafts.csswg.org/css-grid/#gutters) | ||
| - [Definition of gutters](https://drafts.csswg.org/css-grid/#gutters) in the CSS Grid Layout specification |
There was a problem hiding this comment.
- link reordered:
we have many glossary with great number of xxxxx guide and its subguides. considering that new guides may be added to this kind of section(i.e. grid layout guide here), maybe we can just have a higher-level link for reader's references
- moving link name outside
to be consistent with other links, e.g. [xxx] on Wikipedia, [] on IETF...
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
chrisdavidmills
approved these changes
May 27, 2024
There was a problem hiding this comment.
These changes look great; thank you for the continued improvements to the MDN content, @PassionPenguin!
|
Thanks for the improvements, @PassionPenguin! 🙌 |
wbamberg
added a commit
to wbamberg/content
that referenced
this pull request
May 28, 2024
* upstream/main: (55 commits) Replace `.` with `#` in example given selectors are `#ids` (mdn#33791) update info in cross browser testing strategies (mdn#33730) Clarify that `navigator.storage.persist()` depends on heuristics (mdn#33780) fix typo (mdn#33785) feat: improvements on Glossary/Hoisting (mdn#33787) CSS update: overview of shapes guide (mdn#33771) CSS update: Shapes from box values (mdn#33770) Fix issue 033506: correct droppedEntriesCount (mdn#33538) Revert "=== Symbol("foo")" (mdn#33782) docs(css): FF126 - Support for `shape()` function (mdn#33446) Bump lint-staged from 15.2.4 to 15.2.5 (mdn#33777) Bump ajv from 8.13.0 to 8.14.0 (mdn#33776) Add missing spaces for `subtlecrypto` (mdn#33774) fix: typo in `color_and_luminca` (mdn#33775) feat: improvments on gutters (mdn#33751) FF127Relnote- data: and javascript: URLS forbidden in base HREF (mdn#33738) update the content of SVG `<view>` element (mdn#33710) Clipboard.write() - log and fixes (mdn#33769) updated ClipboardItem and Clipboard documentation and examples using … (mdn#33262) Fix error in the code snippet for Symbol (mdn#33765) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modifications
Additions
Motivation
see conversations