Fix globals, part 4: `crypto` #33291

skyclouds2001 · 2024-04-27T06:03:45Z

Description

/cc @wbamberg

part of the #33019

Motivation

Additional details

Related issues and pull requests

github-actions · 2024-04-27T06:13:01Z

This pull request has merge conflicts that must be resolved before it can be merged.

github-actions · 2024-04-27T07:50:37Z

Preview URLs (12 pages)

Flaws (4)

Note! 11 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/RTCPeerConnection/generateCertificate_static
Title: RTCPeerConnection: generateCertificate() static method
Flaw count: 4

macros:
- /en-US/docs/Web/API/AlgorithmIdentifier does not exist
- /en-US/docs/Web/API/Algorithm does not exist
- /en-US/docs/Web/API/RTCCertificateExpiration does not exist
- /en-US/docs/Web/API/Algorithm does not exist

(comment last updated: 2024-05-16 09:45:29)

files/en-us/_redirects.txt

skyclouds2001 · 2024-04-30T18:46:30Z

remove /en-US/docs/Web/API/crossOriginIsolated /en-US/docs/Web/API/Window/crossOriginIsolated the redirect can pass the test, but the issue existed in the preview product

skyclouds2001 · 2024-04-30T19:03:07Z

It seems that when building the preview result, the _redirects.txt file in the repository is used, not the updated one (same behavior can be observed in #33339 )

wbamberg · 2024-04-30T20:33:45Z

It seems that when building the preview result, the _redirects.txt file in the repository is used, not the updated one (same behavior can be observed in #33339 )

Yeah, I know. It's OK, I have your branch checked out locally so I can test the redirects :).

(edited to add: oh, do you mean, that's the reason we are getting these CI errors?)

skyclouds2001 · 2024-05-01T15:48:30Z

(edited to add: oh, do you mean, that's the reason we are getting these CI errors?)

Yes, I think this is the reason

skyclouds2001 · 2024-05-06T12:27:57Z

So what should do next?

files/en-us/_redirects.txt

OnkarRuikar · 2024-05-07T05:09:02Z

It seems that when building the preview result, the _redirects.txt file in the repository is used, not the updated one

Not true. We are not using pull_request_target trigger here.

In future run yarn content fix-redirects command to fix automatically fixable errors in _redirects.txt file.

skyclouds2001 · 2024-05-07T06:48:16Z

It seems that when building the preview result, the _redirects.txt file in the repository is used, not the updated one

Not true. We are not using pull_request_target trigger here.

In future run yarn content fix-redirects command to fix automatically fixable errors in _redirects.txt file.

Got it!

wbamberg · 2024-05-07T18:14:52Z

Thanks @OnkarRuikar ! I had forgotten about sorting. Yes, AFAIK we have to edit redirects manually for some of this work because when these global properties were first added, redirect were sometimes made from API/Window/thing to API/thing_property, and we're now reinstating API/Window/thing. Maybe there's a better way but if so I don't know it.

files/en-us/web/api/crypto/index.md

files/en-us/web/api/crypto/randomuuid/index.md

files/en-us/web/api/cryptokey/algorithm/index.md

files/en-us/web/api/subtlecrypto/index.md

files/en-us/web/api/window/crypto/index.md

files/en-us/web/api/workerglobalscope/crypto/index.md

Co-authored-by: wbamberg <[email protected]>

files/en-us/web/api/cryptokey/algorithm/index.md

files/en-us/web/api/cryptokey/extractable/index.md

files/en-us/web/api/cryptokey/type/index.md

files/en-us/web/api/subtlecrypto/exportkey/index.md

files/en-us/web/api/subtlecrypto/generatekey/index.md

files/en-us/web/api/subtlecrypto/verify/index.md

files/en-us/web/api/subtlecrypto/unwrapkey/index.md

files/en-us/web/api/subtlecrypto/wrapkey/index.md

files/en-us/web/api/window/crypto/index.md

wbamberg

👍 looks great, thank you @skyclouds2001 🎉

ref: mdn/content#33291

* zh-cn: sync translated content * zh-cn: resolve global properties `crypto` ref: mdn/content#33291 --------- Co-authored-by: Allo <[email protected]>

skyclouds2001 added 3 commits April 26, 2024 23:53

move

6c929df

update note

46ee351

update

9a45190

github-actions bot added Content:WebAPI Web API docs Content:JS JavaScript docs size/m [PR only] 51-500 LoC changed labels Apr 27, 2024

github-actions bot added the merge conflicts 🚧 [PR only] label Apr 27, 2024

Merge remote-tracking branch 'upstream/main' into crypto

8b04fd5

github-actions bot removed the merge conflicts 🚧 [PR only] label Apr 27, 2024

run lint

ec974e1

skyclouds2001 commented Apr 28, 2024

View reviewed changes

files/en-us/_redirects.txt Outdated Show resolved Hide resolved

skyclouds2001 commented Apr 28, 2024

View reviewed changes

files/en-us/_redirects.txt Outdated Show resolved Hide resolved

remove

8db3e87

skyclouds2001 marked this pull request as ready for review April 28, 2024 10:23

skyclouds2001 requested review from a team as code owners April 28, 2024 10:23

skyclouds2001 requested review from wbamberg and pepelsbey and removed request for a team April 28, 2024 10:23

revert

6d1093c

Merge branch 'main' into crypto

e18097c

Merge branch 'main' into crypto

369e9d3

OnkarRuikar reviewed May 7, 2024

View reviewed changes

files/en-us/_redirects.txt Outdated Show resolved Hide resolved

fix

726990c

OnkarRuikar mentioned this pull request May 8, 2024

feat(husky): run fix-redirects command in precommit #33485

Merged

skyclouds2001 changed the title ~~Fix globals, part 4: crypto~~ Fix globals, part 4: crypto May 14, 2024

Merge branch 'main' into crypto

4a8c6e4

wbamberg requested changes May 15, 2024

View reviewed changes

skyclouds2001 and others added 3 commits May 16, 2024 16:52

Apply suggestions from code review

95632a5

Co-authored-by: wbamberg <[email protected]>

fix

57bead5

remove section as mdn#33291 (comment)

2ebe2c8

skyclouds2001 commented May 16, 2024

View reviewed changes

Apply suggestions from code review

f310f32

skyclouds2001 commented May 16, 2024

View reviewed changes

skyclouds2001 added 2 commits May 16, 2024 17:43

Apply suggestions from code review

12f21e4

Update files/en-us/web/api/subtlecrypto/wrapkey/index.md

2bd9752

skyclouds2001 commented May 16, 2024

View reviewed changes

files/en-us/web/api/window/crypto/index.md Show resolved Hide resolved

skyclouds2001 commented May 16, 2024

View reviewed changes

files/en-us/web/api/window/crypto/index.md Show resolved Hide resolved

skyclouds2001 requested review from OnkarRuikar and wbamberg May 16, 2024 09:58

wbamberg approved these changes May 16, 2024

View reviewed changes

wbamberg merged commit e897fbf into mdn:main May 16, 2024
9 checks passed

skyclouds2001 deleted the crypto branch May 16, 2024 15:45

yin1999 added a commit to mdn/translated-content that referenced this pull request May 17, 2024

zh-cn: resolve global properties crypto

480a5d7

ref: mdn/content#33291

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix globals, part 4: `crypto` #33291

Fix globals, part 4: `crypto` #33291

skyclouds2001 commented Apr 27, 2024 •

edited

Loading

github-actions bot commented Apr 27, 2024

github-actions bot commented Apr 27, 2024 •

edited

Loading

skyclouds2001 commented Apr 30, 2024

skyclouds2001 commented Apr 30, 2024 •

edited

Loading

wbamberg commented Apr 30, 2024 •

edited

Loading

skyclouds2001 commented May 1, 2024

skyclouds2001 commented May 6, 2024

OnkarRuikar commented May 7, 2024 •

edited

Loading

skyclouds2001 commented May 7, 2024

wbamberg commented May 7, 2024

wbamberg left a comment

Fix globals, part 4: crypto #33291

Fix globals, part 4: crypto #33291

Conversation

skyclouds2001 commented Apr 27, 2024 • edited Loading

Description

Motivation

Additional details

Related issues and pull requests

github-actions bot commented Apr 27, 2024

github-actions bot commented Apr 27, 2024 • edited Loading

skyclouds2001 commented Apr 30, 2024

skyclouds2001 commented Apr 30, 2024 • edited Loading

wbamberg commented Apr 30, 2024 • edited Loading

skyclouds2001 commented May 1, 2024

skyclouds2001 commented May 6, 2024

OnkarRuikar commented May 7, 2024 • edited Loading

skyclouds2001 commented May 7, 2024

wbamberg commented May 7, 2024

wbamberg left a comment

Choose a reason for hiding this comment

Fix globals, part 4: `crypto` #33291

Fix globals, part 4: `crypto` #33291

skyclouds2001 commented Apr 27, 2024 •

edited

Loading

github-actions bot commented Apr 27, 2024 •

edited

Loading

skyclouds2001 commented Apr 30, 2024 •

edited

Loading

wbamberg commented Apr 30, 2024 •

edited

Loading

OnkarRuikar commented May 7, 2024 •

edited

Loading