Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove globals from Web/API #33019

Closed
21 tasks done
wbamberg opened this issue Apr 9, 2024 · 4 comments · Fixed by #36041
Closed
21 tasks done

Remove globals from Web/API #33019

wbamberg opened this issue Apr 9, 2024 · 4 comments · Fixed by #36041
Labels
Content:Meta Content in the meta docs Content:WebAPI Web API docs MDN:Project Anything related to larger core projects on MDN

Comments

@wbamberg
Copy link
Collaborator

wbamberg commented Apr 9, 2024

This issue is to remove "globals" from Web/API, by instead having separate pages under Window and WorkerGlobalScope. This was discussed in https://github.com/orgs/mdn/discussions/360.

This has been done for indexedDB (#32040) and looks all right (https://github.com/orgs/mdn/discussions/360#discussioncomment-9023867), so let's do it for all the remaining pages.

For each page, the process is:

  • yarn content move the global page to be under Window.
  • update the page under Window to be an instance property or method page, and update the content accordingly
  • create a new version of the page as an instance property or method page under WorkerGlobalScope, that's worker-specific
  • manually delete the redirect from Web/API/WorkerGlobalScope/indexedDB to Web/API/indexedDB
  • fix any domxref links so they don't incur redirects
  • update GroupData, adding entries for the two new pages into the entry for the API that defines the feature (e.g. Indexed DB API).

Once all pages are fixed, the final step in this issue is to remove the web-api-global-function and web-api-global-property page types.

  • Remove global page types
@github-actions github-actions bot added Content:Meta Content in the meta docs Content:WebAPI Web API docs needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Apr 9, 2024
@Josh-Cena Josh-Cena added MDN:Project Anything related to larger core projects on MDN and removed needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. labels Jun 6, 2024
@skyclouds2001
Copy link
Contributor

Also, should the same thing to be done on BCD?

@wbamberg
Copy link
Collaborator Author

wbamberg commented Oct 7, 2024

Also, should the same thing to be done on BCD?

@Elchi3 , @queengooborg, wdyt?

@Josh-Cena
Copy link
Member

Josh-Cena commented Oct 7, 2024

I had been asking about this in Slack but Vinyl did not seem particularly interested—or perhaps I didn't explain it well.

@skyclouds2001
Copy link
Contributor

seems mdn/browser-compat-data#18739 is already discussing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:Meta Content in the meta docs Content:WebAPI Web API docs MDN:Project Anything related to larger core projects on MDN
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants