Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macro): remove inline status macros from CSS value sections, part 1 #32756

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

OnkarRuikar
Copy link
Contributor

There is a pending discussion about how to document CSS values and there are inconsistencies in BCD data about CSS values. Till all the issues get resolved it's been decided to stop using inline status macros in CSS pages.

The PR removes inline status macros from pages of type css-property.

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner March 20, 2024 04:19
@OnkarRuikar OnkarRuikar requested review from estelle and removed request for a team March 20, 2024 04:19
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Mar 20, 2024
Copy link
Contributor

Preview URLs (39 pages)
Flaws (4)

Note! 36 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/CSS/-moz-user-input
Title: -moz-user-input
Flaw count: 1

  • macros:
    • /en-US/docs/Web/CSS/user-input does not exist

URL: /en-US/docs/Web/CSS/-webkit-line-clamp
Title: -webkit-line-clamp
Flaw count: 2

  • macros:
    • /en-US/docs/Web/CSS/line-clamp does not exist
    • /en-US/docs/Web/CSS/line-clamp does not exist

URL: /en-US/docs/Web/CSS/ruby-position
Title: ruby-position
Flaw count: 1

  • macros:
    • /en-US/docs/Web/CSS/ruby-merge does not exist

@estelle estelle requested a review from wbamberg March 20, 2024 19:02
Copy link
Collaborator

@wbamberg wbamberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wbamberg wbamberg merged commit 69f98c6 into mdn:main Mar 23, 2024
8 checks passed
@OnkarRuikar OnkarRuikar deleted the css_remove_inline_macros branch March 23, 2024 01:09
@OnkarRuikar
Copy link
Contributor Author

@wbamberg Do we want to do the same for functions, at-rules, types, and other pages too? Or do this for all the CSS pages (only 30 pages left)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants