-
Notifications
You must be signed in to change notification settings - Fork 22.4k
-
Notifications
You must be signed in to change notification settings - Fork 22.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is "text-align: center" really deprecated and non-standard?!? #32700
Comments
The latest editor's draft includes |
I think you are misinterpreting the note, which just says you should use the html |
Thank you @Hexstream |
Thanks for flagging, I will move this to the content repo, as the deprecated/non-standard badges are declared there: content/files/en-us/web/css/text-align/index.md Lines 51 to 56 in 7889bb9
|
Thanks! (Bizarrely, I did not get a notification for your message, first time this happens...) (edit: Might have something to do with the transfer? Weird coincidence that the only time my issue gets transferred is the only time I don't get a notification...) (edit 2: I am happily getting notifications for subsequent messages! 🎉 I was getting worried there, as GitHub without email notifications would be completely unusable...) |
I suspect this was the result of an earlier update from BCD that went wrong #32371. @OnkarRuikar What's the status of the update script for BCD at the moment? Should we manually fix this up to match BCD? |
Nope. Actually, it was a bug in BCD that was fixed on 6th March. On 7th March it was supposed to be corrected in mdn/content by Synchronize with BCD v5.5.14, but the PR got stalled due to other issues in BCD.
The bot is waiting on following issues to be fixed:
We should escalate this and get the bot running. Otherwise we'll start seeing multiple issues for each missed sync page. I was hoping to discuss these with BCD maintainers in the meeting. But they refuse to join the meetings until we stop using Jitsi and OWD doen't want to use anything else. 🙅
|
@Hexstream So there you are, trust the BCD over MDN.
@OnkarRuikar I understand your point - the best way to fix this would be to be able to run the script. But if this is not converging in any way to a result and there is no sign of it doing so, we'd be dumb not to fix these as we find them. So how are the issues progressing really - are we in "never going to fix" land or stalled, or what? |
PS @OnkarRuikar W.r.t. to the bot, I understand that the issue is around presentation of "CSS Values". If that is the blocker, then IMO that specific functionality should be separated from the bot actions so the bot can run. We should not block other updates. |
??? |
I'm just saying you're right, its a bug in the docs. For now, if the BCD shows something different than the docs I would trust the compatibility data. |
:O that is why I am in favour of the sync bot being transparent and it to mimic BCD as it is no matter what. Those who feel the same please vote for Christmas tree 🎄 option in https://github.com/orgs/mdn/discussions/654 poll.
I could ignore those pages in the script and resume the bot. May I do that? |
There is some history to this issue in mdn/browser-compat-data#22524 (comment). Actually it's been wrong in BCD since June 2023, but people only started noticing when the bot started adding the labels to items in "Values" (which is an interesting user-test of how much people look at the icons in BCD tables, versus the page text). As Onkar says, it got fixed in BCD a couple of weeks ago, but the fix hasn't propagated to MDN because the bot isn't running, because of issues I raised in #32594. I don't think these issues are going to be resolved any time soon. I do think we should fix these pages. I think it would be fine to:
About the issues in #32594. I've said this elsewhere but for the record. I think if we are not to get in a mess here, we need to know what should be listed in the "Values" section. When a property's values are just taken from a list of keywords, it's easy. But take, say, https://developer.mozilla.org/en-US/docs/Web/CSS/grid-auto-rows or https://developer.mozilla.org/en-US/docs/Web/CSS/grid-area. In these pages, what should "Values" list? Are the "Values" sections in these pages correct? How can we tell? Look at it like this. For Web/API methods, we know pretty much what gets listed in "Parameters". We can look at a page, compare it with the IDL, and know if they are listed correctly. But for CSS...say https://developer.mozilla.org/en-US/docs/Web/CSS/grid-area . It lists (I can tell you what the answer to this used to be. But practice has diverged over the years, and there is no clear answer to this any more.) And then, whatever we do decide they should be, will they map cleanly onto things we want to make compat statements about? Like, say we want to make "Values" entries be the granular CSS data types that participate in a formal syntax definition. So for grid-area one of the entries might be |
This feels so good. Clearly closer the info quickly it gets consumed thus being more useful. This makes strong case for Christmas tree 🎄 strategy in https://github.com/orgs/mdn/discussions/654 poll.
In this case, if the value |
OK, so I'm not entering that discussion ^^^. But this issue is fixed by #32756 |
Awesome, thanks! |
I noticed that the MDN page for text-align claims that
text-align: left
,text-align: right
andtext-align: center
are all deprecated and non-standard.I can understand in the case of
text-align: left
andtext-align: right
, sincetext-align: start
andtext-align: end
seem like better alternatives anyway, but I thinktext-align: center
is obviously the best option in many cases, with no universal replacement. Even that page itself usestext-align: center
as an example, and I couldn't find any authoritative source explaining whytext-align: center
is or should be deprecated.I think this is a bug in the MDN documentation and
text-align: center
is not in any way deprecated or non-standard.(I don't think any of these 3 values are "non-standard" either, since they have been specified and universally supported for decades, and I am quite sure no sane browser is going to drop support for them anytime soon.)
The text was updated successfully, but these errors were encountered: