-
Notifications
You must be signed in to change notification settings - Fork 22.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix globals, part 1: indexedDB #32040
Conversation
Preview URLs (8 pages)
Flaws (3)Note! 7 documents with no flaws that don't need to be listed. 🎉 URL:
External URLs (3)URL:
URL:
URL:
(comment last updated: 2024-03-01 07:10:24) |
Co-authored-by: Jean-Yves Perrier <[email protected]>
This pull request has merge conflicts that must be resolved before it can be merged. |
- {{domxref("caches", "WorkerGlobalScope.caches")}} {{ReadOnlyInline}} | ||
- : Returns the {{domxref("CacheStorage")}} object associated with the current context. This object enables functionality such as storing assets for offline use, and generating custom responses to requests. | ||
- {{domxref("console")}} {{ReadOnlyInline}} {{Non-standard_inline}} | ||
- : Returns the {{domxref("console")}} associated with the worker. | ||
- {{domxref("crossOriginIsolated", "WorkerGlobalScope.crossOriginIsolated")}} {{ReadOnlyInline}} | ||
- : Returns a boolean value that indicates whether the website is in a cross-origin isolation state. | ||
- {{domxref("crypto_property", "WorkerGlobalScope.crypto")}} {{ReadOnlyInline}} | ||
- : Returns the {{domxref("Crypto")}} object associated to the global object. | ||
- {{domxref("WorkerGlobalScope.fonts")}} {{ReadOnlyInline}} | ||
- : Returns the {{domxref("FontFaceSet")}} associated with the worker. | ||
- {{domxref("indexedDB", "WorkerGlobalScope.indexedDB")}} {{ReadOnlyInline}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- {{domxref("indexedDB", "WorkerGlobalScope.indexedDB")}} {{ReadOnlyInline}} | |
- {{domxref("WorkerGlobalScope.indexedDB")}} {{ReadOnlyInline}} |
RX \{\{ ?domxref ?\(['"]indexedDB
will give you 11 more occurrences.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can only find 5:
files/en-us/web/api/window/index.md
60:- {{domxref("indexedDB", "Window.indexedDB")}} {{ReadOnlyInline}}
files/en-us/web/api/workerglobalscope/index.md
30:- {{domxref("indexedDB", "WorkerGlobalScope.indexedDB")}} {{ReadOnlyInline}}
files/en-us/web/api/indexeddb_api/index.md
38: - : Provides access to a database. This is the interface implemented by the global object {{domxref("indexedDB")}} and is therefore the entry point for the API.
files/en-us/web/progressive_web_apps/how_to/share_data_between_apps/index.md
282:In this code example, the shared files are extracted from the form data and the user is redirected to a different page. It's up to you, using the code in your service worker, to handle the extracted files as you want. For example, you can send them to your app's main JavaScript code using the {{domxref("Worker.postMessage()")}} method or store them in an {{domxref("IndexedDB")}} database which can be accessed both by your service worker and app's main JavaScript code.
files/en-us/mozilla/firefox/releases/38/index.md
87:- The prefixed version of {{domxref("indexedDB")}}, `mozIndexedDB` has been removed ([Firefox bug 975699](https://bugzil.la/975699)).
...can you list the others please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...can you list the others please?
My bad. The regex included {{domxref("IndexedDB API", "IndexedDB", "", "nocode")}}
as well.
However following could be changed
content/files/jsondata/GroupData.json
Line 871 in d77e0bb
"properties": ["indexedDB"], |
to one of the following:
"properties": ["Window.indexedDB"],
"properties": ["Window.indexedDB", "WorkerGlobalScope.indexedDB"],
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, good call on groupdata -> e9fbac9.
Don't know why
still redirect and throw 404? May be rebasing will help. |
I think but am not sure that preview doesn't handle changes to redirects. I think these links work locally. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the change.
This looks exactly how I expect globals to be. (We point to the same BCD id, which is the right thing to do for now)
This is the first piece of updating globals, as discussed in https://github.com/orgs/mdn/discussions/360.
It updates a single page,
indexedDB
, as a test.The procedure is:
Window
.Window
to be an instance property page, and update the content accordinglyWorkerGlobalScope
, that's worker-specificWeb/API/WorkerGlobalScope/indexedDB
toWeb/API/indexedDB
The BCD is still weird, "api.indexedDB" rather than "api.Window.indexedDB", but I'm not going to try to fix that here.
(In this PR I also updated the main
WorkerGlobalScope
page to not have a separate section for nonstandard members. For the sake of simplicity, I probably should have left that alone.)