Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ConstrainULong/ULongRange #6936

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Remove ConstrainULong/ULongRange #6936

merged 1 commit into from
Nov 18, 2020

Conversation

saschanaz
Copy link
Contributor

A checklist to help your pull request get merged faster:

  • Summarize your changes
  • Data: link to resources that verify support information (such as browser's docs, changelogs, source control, bug trackers, and tests)
  • Data: if you tested something, describe how you tested with details like browser and version
  • Review the results of the linter and fix problems reported (If you need help, please ask in a comment!)
  • Link to related issues or pull requests, if any: Remove items that has never been supported #6854, Remove totally unimplemented things #6768

These are enums anyway.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 16, 2020
queengooborg
queengooborg approved these changes Nov 18, 2020
View reviewed changes
Copy link
Collaborator

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, since these are enums, there's no reason for these to be in BCD!

@queengooborg queengooborg merged commit ea8e8a7 into mdn:master Nov 18, 2020
@saschanaz saschanaz deleted the nosupport-ulong branch November 18, 2020 21:32
@ddbeck
Copy link
Collaborator

ddbeck commented Nov 19, 2020

I'm going to revert this PR. Broadly speaking, we don't have an answer to the question of dictionaries; #7287 is open to address it. Narrowly, I don't how don't know how to extricate this content from MDN without rewriting several pages.

(Also, curiously, @vinyldarkscratch merged this data into BCD earlier this year #5577. 🤷‍♂️)

I'm happy to revisit this, but we need to make a plan for not wrecking things downstream first.

ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Nov 19, 2020
@ddbeck
Revert "Remove ConstrainULong/ULongRange (mdn#6936)"
4d71429 
See mdn#6936 (comment)

This reverts commit ea8e8a7.
@ddbeck ddbeck mentioned this pull request Nov 19, 2020
Merged
ddbeck added a commit that referenced this pull request Nov 19, 2020
@ddbeck
Revert "Remove ConstrainULong/ULongRange (#6936)" (#7415)
c2bc40e 
See #6936 (comment)

This reverts commit ea8e8a7.
@ddbeck
Copy link
Collaborator

ddbeck commented Nov 19, 2020

Reverted by #7415.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@queengooborg queengooborg queengooborg approved these changes

Assignees
No one assigned
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@saschanaz @ddbeck @queengooborg