-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove items that has never been supported #6854
Conversation
@saschanaz this is a great PR and much needed cruft cleanup, and cross checking against collector results to make sure we're not deleting entries that actually have been implemented is a great idea. It's a pretty big PR to review/land at once though, could it be split into smaller bits? Did you use a script to produce it, so that it could be recreated on master at any time? @ddbeck thoughts on this, given that you marked it not ready? What are the checks you'd like to see, other than careful manual review of each removal? |
As a compat overview, here are the entries removed by this PR: api.AuthenticatorAttestationResponse.getTransports |
Yes, this is from a customized version of #6809 where things are autodeleted. I'll try splitting this into smaller pieces. |
Sorry, I apologize for forgetting to say why I marked it as not ready. I was going to suggest that we put it into draft status, like a few other PRs, and use it as a burndown for removing these topic-by-topic. For all- Alternatively, if we want to qualify each of these features within a big PR like this, I'm thinking we ought to hold back on this until the |
Oh, also, there's a bit of work to do on MDN: if there exist actual pages for any of these, we should archive them. That's another thing I wanted to check before merging any of this. |
I think review will inevitably turn up some issues that will take some back and forth, so splitting into a few groups would be great. I'd be happy to review smaller PRs and do some source code archeology for Blink, Gecko and WebKit to ensure no implementation has existed. |
Thanks for the feedback. First things first, converting this to draft: |
api/VRDisplay.json
Outdated
@@ -1051,54 +1051,6 @@ | |||
} | |||
} | |||
}, | |||
"hardwareUnitId": { | |||
"__compat": { | |||
"mdn_url": "https://developer.mozilla.org/docs/Web/API/VRDisplay/hardwareUnitId", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt anyone is willing to add anything for deprecated WebVR, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to remove this entry but got stuck cleaning up MDN. It's referenced in examples that I didn't know how to rewrite.
This pull request has merge conflicts that must be resolved before it can be merged. |
This pull request has merge conflicts that must be resolved before it can be merged. |
|
This pull request has merge conflicts that must be resolved before it can be merged. |
A checklist to help your pull request get merged faster:
@vinyldarkscratch Could these be checked via mdn-bcd-collector results? I found at least one item that actually has a support (
AuthenticatorAttestationResponse.prototype.getTransports
) and I'm sure there are several more.