Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Constrain* typedefs from BCD #11000

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Remove Constrain* typedefs from BCD #11000

merged 1 commit into from
Jul 28, 2021

Conversation

queengooborg
Copy link
Collaborator

This PR removes ConstrainBoolean, ConstrainDOMString, ConstrainDouble, and DoubleRange from BCD. The first three are WebIDL typedefs, which are never exposed to web developers and shouldn't really be documented in BCD (see #9930). The DoubleRange is also a dictionary that correlates with ConstrainDouble.

@foolip
Copy link
Collaborator

foolip commented Jun 14, 2021

I'm very happy to see these removed, but would like to merge it together with a PR on the MDN size. @vinyldarkscratch will you take care of that too?

@foolip foolip added the not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. label Jun 14, 2021
@queengooborg
Copy link
Collaborator Author

Certainly -- @teoli2003 put together a step-by-step list in an issue over there (thank you!), so I'll be following that and getting a content PR made!

@queengooborg queengooborg self-assigned this Jun 14, 2021
@queengooborg queengooborg added the needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation label Jun 16, 2021
@queengooborg queengooborg removed their assignment Jul 27, 2021
@queengooborg queengooborg removed needs content update 📝 This PR needs a corresponding update to mdn/content to update the documentation not ready ⛔ This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. labels Jul 27, 2021
@sideshowbarker sideshowbarker merged commit d952181 into main Jul 28, 2021
@sideshowbarker sideshowbarker deleted the remove-typedefs branch July 28, 2021 06:07
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Jul 29, 2021
ddbeck added a commit that referenced this pull request Jul 29, 2021
* Bump version to v3.3.13

* Add release note for #11717

* Add release note for #11753

* Add release note for #11459

* Add release note for #11720

* Add release note for #11722

* Add release note for #11721

* Add release note for #11763

* Add release note for #10623

* Add release note for #11000

* Add stats and release date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants