Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove non-interface/mixin data from api directory #6810

Closed
saschanaz opened this issue Oct 3, 2020 · 10 comments
Closed

Remove non-interface/mixin data from api directory #6810

saschanaz opened this issue Oct 3, 2020 · 10 comments
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API

Comments

@saschanaz
Copy link
Contributor

saschanaz commented Oct 3, 2020

Found some non-interface things:

Dictionaries:

Mixins:

Other:

@queengooborg queengooborg added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 4, 2020
@foolip
Copy link
Collaborator

foolip commented Apr 20, 2021

Note that some of the Constrain* types you listed are not dictionaries in the spec, just incorrectly claimed to be dictionaries on MDN. (They should still be removed IMHO.)

@foolip
Copy link
Collaborator

foolip commented Jun 7, 2021

Another enum spotted in #10784: XRSessionMode

@foolip
Copy link
Collaborator

foolip commented Aug 31, 2021

These are the *Init.json files we all, all dictionaries:

api/MutationObserverInit.json
api/RTCIceCandidateInit.json
api/VRLayerInit.json
api/DOMPointInit.json
api/RTCTrackEventInit.json
api/RTCRtpTransceiverInit.json

@queengooborg
Copy link
Collaborator

I've found some other dictionaries in our BCD by searching for the word "dictionary" in the MDN content, as well as greping the files for "options", "configuration", "parameters", etc. There are...a lot of dictionaries still in BCD, it looks like.

I've updated the issue to turn it into a checklist of what we have left to remove and added all of the additional problematic files we've found. I'm also pinning this issue since it's an important goal and even helps bring our real value percentage up some!

@queengooborg queengooborg pinned this issue Sep 9, 2021
queengooborg added a commit to queengooborg/browser-compat-data that referenced this issue Sep 10, 2021
This PR removes the `DOMPointInit` dictionary from BCD.  Part of work for mdn#6810.
queengooborg added a commit that referenced this issue Sep 11, 2021
This PR removes the `DOMPointInit` dictionary from BCD.  Part of work for #6810.
@Elchi3
Copy link
Member

Elchi3 commented Sep 13, 2021

I believe https://developer.mozilla.org/en-US/docs/Web/API/Transferable is also a non-interface page / BCD data.

@queengooborg
Copy link
Collaborator

Good catch, thanks @Elchi3! Yeah, this looks like something we can remove. I've added it to the list!

@skyclouds2001
Copy link
Contributor

  • RTCIceCredentialType

RTCIceCredentialType is removed via #18496 yet

@skyclouds2001
Copy link
Contributor

  • RTCRtpSynchronizationSource

RTCRtpSynchronizationSource is also removed via #21759 yet

@skyclouds2001
Copy link
Contributor

  • MediaTrackConstraints
  • MediaTrackSettings
  • MediaTrackSupportedConstraints

these three are in #21761

@Elchi3
Copy link
Member

Elchi3 commented Jun 5, 2024

Thanks @skyclouds2001, I believe this is all merged and done now.

Closing 🎉

@Elchi3 Elchi3 closed this as completed Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

No branches or pull requests

7 participants
@Elchi3 @foolip @saschanaz @queengooborg @skyclouds2001 and others