Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safari 15 beta updates #10898

Merged
merged 7 commits into from
Jun 24, 2021
Merged

Safari 15 beta updates #10898

merged 7 commits into from
Jun 24, 2021

Conversation

jdatapple
Copy link
Contributor

@jdatapple jdatapple commented Jun 9, 2021

Summary

Updates for Safari 15 beta from the Safari/WebKit teams at Apple.

Test results and supporting details

This information has been compiled from Safari/WebKit engineers at Apple, combined with the results of the BCD collector where suspicious data was manually reviewed and corrected when necessary.

For more details see: Safari 15 Beta Release Notes

@github-actions github-actions bot added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS labels Jun 9, 2021
@tomayac
Copy link
Contributor

tomayac commented Jun 10, 2021

@apple-web-evangelist One more thing to flip from false to "15" is Ecmascript module support for workers, here's the deeplink:

"version_added": false

@foolip
Copy link
Contributor

foolip commented Jun 10, 2021

I can take a look at the API data here at some point. I've filed mdn/yari#4005 about a problem I anticipate. (Didn't know there was already so much Firefox beta data, or I would have suggested this earlier.)

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @apple-web-evangelist. I spotted a few issues and logged a few questions in line comments.

(I was looking for structural issues mostly, more or less trusting any false"15" change. I didn't think through the API changes too closely, so there might be things implied by these changes I haven't noticed.)

css/properties/scroll-margin-block-end.json Outdated Show resolved Hide resolved
css/types/color.json Outdated Show resolved Hide resolved
css/types/color.json Outdated Show resolved Hide resolved
css/types/color.json Outdated Show resolved Hide resolved
html/elements/meta.json Outdated Show resolved Hide resolved
html/elements/meta.json Outdated Show resolved Hide resolved
javascript/builtins/Error.json Show resolved Hide resolved
api/WebGLVertexArrayObjectOES.json Outdated Show resolved Hide resolved
html/elements/meta.json Outdated Show resolved Hide resolved
@mdn mdn deleted a comment from Teimtem Jun 11, 2021
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more, mostly small suggestions. Thank you!

css/types/color.json Outdated Show resolved Hide resolved
css/types/color.json Outdated Show resolved Hide resolved
javascript/builtins/Error.json Outdated Show resolved Hide resolved
@ddbeck
Copy link
Collaborator

ddbeck commented Jun 23, 2021

@apple-web-evangelist looking this over again, I think there's one unresolved comment and the conflict in api/Worker.json to resolve. Getting quite close to merging this!

Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes in api/ look good to me, just one question about the very last one.

@@ -171,10 +171,10 @@
"version_added": "57"
},
"safari": {
"version_added": "14.1"
"version_added": "15"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like I didn't submit my comment here. Is the original 14.1 wrong here, where did that data come from?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It is wrong. I don't know where it came from.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming, no need to track it down if you're confident it's wrong.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I verified it was wrong on Safari 14.1 using wpt.live tests. The change appears to have come from this: #10749 That PR cites a blogger discussing it, but the blogger discussed it in the context of Safari Technology Preview, not the Safari 14.1 release.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I merged that, oops! @tomayac FYI that this turned out to be wrong.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry. I was under the impression the TP version numbers could be used for this. Honest mistake.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, and I didn't realize it was intended to mean STP :)

Soon we will have "preview" as an allowed string for things that are only in STP (and Chrome Canary or Firefox Nightly).

@github-actions github-actions bot added data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript labels Jun 24, 2021
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. If there's anything else to do, let's get to it in a follow up PR. Thank you! 🎉

@danburzo
Copy link
Contributor

danburzo commented Aug 14, 2021

I stumbled upon the MDN page for color() and saw the note about new support in Safari 15. It seems, however, that srgb was supported in addition to display-p3 since Safari 10.1.

Confirmed with this test case in BrowserStack:

<!DOCTYPE html>
<html lang='en'>
<head>
	<meta charset="utf-8">
	<title></title>
</head>
<body style='background: color(srgb 0.9 0.25 0.3)'>
</body>
</html>

Shall I submit a PR?

@ddbeck
Copy link
Collaborator

ddbeck commented Aug 19, 2021

@danburzo

Shall I submit a PR?

Please do (or open an issue)! It's easy for follow ups on merged PRs to get forgotten (like I almost did here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants