-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari 15 beta updates #10898
Safari 15 beta updates #10898
Conversation
@apple-web-evangelist One more thing to flip from browser-compat-data/api/Worker.json Line 177 in 14781ad
|
I can take a look at the API data here at some point. I've filed mdn/yari#4005 about a problem I anticipate. (Didn't know there was already so much Firefox beta data, or I would have suggested this earlier.) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, @apple-web-evangelist. I spotted a few issues and logged a few questions in line comments.
(I was looking for structural issues mostly, more or less trusting any false
→ "15"
change. I didn't think through the API changes too closely, so there might be things implied by these changes I haven't noticed.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple more, mostly small suggestions. Thank you!
@apple-web-evangelist looking this over again, I think there's one unresolved comment and the conflict in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes in api/ look good to me, just one question about the very last one.
@@ -171,10 +171,10 @@ | |||
"version_added": "57" | |||
}, | |||
"safari": { | |||
"version_added": "14.1" | |||
"version_added": "15" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like I didn't submit my comment here. Is the original 14.1 wrong here, where did that data come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. It is wrong. I don't know where it came from.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for confirming, no need to track it down if you're confident it's wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified it was wrong on Safari 14.1 using wpt.live tests. The change appears to have come from this: #10749 That PR cites a blogger discussing it, but the blogger discussed it in the context of Safari Technology Preview, not the Safari 14.1 release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, I merged that, oops! @tomayac FYI that this turned out to be wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, sorry. I was under the impression the TP version numbers could be used for this. Honest mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, and I didn't realize it was intended to mean STP :)
Soon we will have "preview" as an allowed string for things that are only in STP (and Chrome Canary or Firefox Nightly).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. If there's anything else to do, let's get to it in a follow up PR. Thank you! 🎉
I stumbled upon the MDN page for Confirmed with this test case in BrowserStack: <!DOCTYPE html>
<html lang='en'>
<head>
<meta charset="utf-8">
<title></title>
</head>
<body style='background: color(srgb 0.9 0.25 0.3)'>
</body>
</html> Shall I submit a PR? |
Please do (or open an issue)! It's easy for follow ups on merged PRs to get forgotten (like I almost did here). |
Summary
Updates for Safari 15 beta from the Safari/WebKit teams at Apple.
Test results and supporting details
This information has been compiled from Safari/WebKit engineers at Apple, combined with the results of the BCD collector where suspicious data was manually reviewed and corrected when necessary.
For more details see: Safari 15 Beta Release Notes