Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aspect-ratio.json #10634

Closed
wants to merge 1 commit into from
Closed

Update aspect-ratio.json #10634

wants to merge 1 commit into from

Conversation

aburymichael
Copy link
Contributor

Summary

Safari TP release 123 enables aspect ratio CSS property by default.

Test results and supporting details

https://bugs.webkit.org/show_bug.cgi?id=223117

@github-actions github-actions bot added the data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label May 25, 2021
@ddbeck ddbeck added the not ready This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. label May 26, 2021
@ddbeck
Copy link
Collaborator

ddbeck commented May 26, 2021

Thanks for this PR and welcome to the project, @aburymichael.

This PR is blocked (by #10334) and will fail CI because we don't yet have a way of tracking Safari TP and similar in-development versions of browsers. We're working on it, but this will be on hold until then.

@aburymichael
Copy link
Contributor Author

Thanks for the feedback @ddbeck.

My apologies, I had seen "TP" in a couple json files whilst learning the structure - granted I was looking for "TP" specifically as I noticed that caniuse.com had "support unknown" for the TP browser when in fact it is supported - assumed this was the place to do so. Will wait on #10334 to be resolved, thanks!

@ddbeck
Copy link
Collaborator

ddbeck commented Aug 18, 2021

Though #10334 is now resolved, this specific change was resolved with a specific version number by #10898. Thank you for starting this PR, @aburymichael, even though I have to close it without merging.

@ddbeck ddbeck closed this Aug 18, 2021
@ddbeck ddbeck removed not ready This is not yet ready to be merged. It's pending a decision, other PR, or a prerequisite action. rebase needed 🚧 labels Aug 18, 2021
@aburymichael aburymichael deleted the patch-1 branch August 18, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants