Skip to content

Update Dependencies #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 23, 2018
Merged

Update Dependencies #14

merged 2 commits into from
Sep 23, 2018

Conversation

rayliverified
Copy link
Contributor

*Update dependencies to work with Flutter v0.8.3 and Dart v2.1.

*Update dependencies to work with Flutter v0.8.3 and Dart v2.1.
@rayliverified
Copy link
Contributor Author

Did you have a chance to test this PR?

@mdanics
Copy link
Owner

mdanics commented Sep 20, 2018

Sorry for the delay, been busy. Taking a look now, seems like there is a conflict with google play service versions, getting Unable to merge dex

@mdanics
Copy link
Owner

mdanics commented Sep 20, 2018

Looks like addingmultiDexEnabled true to defaultConfig in /android/app/build.gradle fixes the issue for me.

Before merging, want to find out if this is what you had to do to get it to work for you. Ideally I don't want to enable something I don't completely know what it does.

Other than that, everything seems to be working fine - thank you for going through and updating the breaking changes for updated packages.

@rayliverified
Copy link
Contributor Author

Thanks for looking over the PR and this app! Let me check to see if I had to enable multidex, will get back to you on this. Also, there's been so many changes since this PR I need to make sure everything is still up to date.

*Enable MultiDex to build successfully.
@rayliverified
Copy link
Contributor Author

Just tested and you're right. I need to enable multidex in order to build. Done!

@mdanics mdanics merged commit 0dedf8b into mdanics:master Sep 23, 2018
@mdanics
Copy link
Owner

mdanics commented Sep 23, 2018

Looks good! Thanks for the PR

@rayliverified
Copy link
Contributor Author

Thank you for the quick merge! I'm learning how to build Flutter apps and your example is really helpful. There's some parts that don't work that well and if I figure out how to do it better, I'll make sure to send a PR.

I'm currently tackling Firebase login and authentication. Fluttergram often displays the SignIn screen even when you're already logged which isn't desirable. I'm looking at how to avoid that!.

@mdanics
Copy link
Owner

mdanics commented Sep 23, 2018

Hm yeah thats not ideal. I haven't experienced that which makes it hard for me to look into it, but I agree the login logic isn't the best.

Do you have a way we can talk privately? Would love to talk Flutter and your experience with it.

@rayliverified
Copy link
Contributor Author

Are you part of the FlutterDev Reddit Discord? I'd love to talk Flutter too! https://discord.gg/W6eyk7

@rayliverified
Copy link
Contributor Author

Also, my email is [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants