Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use png images in generated reports #853

Merged
merged 2 commits into from
Mar 16, 2024

Conversation

nkelemen18
Copy link
Contributor

  • Added generated and optimized .png images (generated from .svgs).
  • Report generation refactored to use png images
  • Testcases refactored to check the usage of png images
  • Old, SVG images removed

Based on #721, fixes #558

@mc1arke
Copy link
Owner

mc1arke commented Feb 25, 2024

I don't think we should delete the SVG images, as anyone with existing PR/MR decoration referencing these images will fail to get icons when opening those PR/MRs.

Given the comments on the original issue, have you confirmed these images render properly for you on a system where the SVGs were previously failing to render?

@nkelemen18
Copy link
Contributor Author

Hello,

Keeping the old, svg images is a good idea, I've restored them.

Yes, I can confirm, that png images are working in GMail. You have to allow to load images once, but after that it renders the images as you can see:

image

They are a little bit misaligned, but this error comes from GitLab's Markdown renderer: images have 8px bottom margin

The following image cropped from GitLab's UI:
image

@mc1arke mc1arke merged commit e039e72 into mc1arke:master Mar 16, 2024
7 checks passed
@mc1arke
Copy link
Owner

mc1arke commented Mar 16, 2024

Merged, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SVG images in emails generated by plugin do not render in gmail client
2 participants