SVG images in emails generated by plugin do not render in gmail client #558
Comments
gamerson
changed the title
|
Could this be because of this issue? https://stackoverflow.com/questions/20815613/svg-images-blocked-by-gmail-proxy |
|
Yes, this issue is actually a restriction in the way Gmail works. I'm happy for someone to raise a PR against the plugin to support other image types if this is critical to them, but I have no plans on changing this myself. |
|
Thanks for responding. Could you give a quick outline of the work that
would be involved? Lets say that we wanted to add ability to use
just emojis characters (unicode) in the generated email template. Maybe a
plugin setting? Other suggestion
…On Mon, Apr 4, 2022 at 3:49 PM Michael Clarke ***@***.***> wrote:
Yes, this issue is actually a restriction in the way Gmail works. I'm
happy for someone to raise a PR against the plugin to support other image
types if this is critical to them, but I have no plans on changing this
myself.
—
Reply to this email directly, view it on GitHub
<#558 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAERKFMG37UAFESE3BOLC73VDNIVLANCNFSM5QD44L2Q>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
--
Greg Amerson
Liferay Cloud. liferay.com
|
|
You'd need to add the new icons to the plugin, and then update the references in the |
I opened a PR for this: #721 |
|
@mc1arke Could you check the PR if there is something, I should improve? |
|
Hey @nkelemen18 I have tried your change in #721 but unfortunately even the PNG images will not display in a github PR comment in either github UI or in gmail email display. I think it just don't want to load images from random domains. I'm starting to consider an emoji may be a better recourse here, what do you think? |
|
Hello all, Sorry for my late reply I had other stuffs to do. Based on comments here, and on my previous PR (#721) I refactored my previous work to use PNGs only. The new PR: #853. @gamerson You asked what is the reason behind generating pngs from svgs instead of using the images from the original plugin. |
|
Thanks for the response. Personally for my company's use of this plugin,
we had to switch to Emojis. Even PNGs would not display in github
reviews. You can see my changes to our fork here:
master...LiferayCloud:sonarqube-community-branch-plugin:1.14.0.emoji
I'd like to make even more improvements to this to use emoji's even
smarter, like for "50%" code coverage rendering
🟩🟩🟥🟥 (2 green block emojis and 2 red block emojis)
But I don't know if I will have time. If others here would be interested
in such changes I may try to find personal time to make that change.
…On Thu, Jan 4, 2024 at 4:50 PM Norbert Kelemen ***@***.***> wrote:
Hello all,
Sorry for my late reply I had other stuffs to do.
Based on comments here, and on my previous PR (#721
<#721>)
I refactored my previous work to use PNGs only.
The new PR: #853
<#853>.
@gamerson <https://github.com/gamerson> You asked what is the reason
behind generating pngs from svgs instead of using the images from the
original plugin.
My answer is: Some images missing from the original plugin which are used
by this one.
—
Reply to this email directly, view it on GitHub
<#558 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAERKFL7GSGICQFIWOA26KLYM4W43AVCNFSM5QD44L22U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBXG44DMOJTGI4A>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
--
Greg Amerson
Liferay Cloud. liferay.com
|
Some email clients block the loading of SVG images, resulting in the summary reports not displaying cleanly. PNG equivalents of those images has been generated and the report generation switched to use them. The old SVG images have been retained to ensure that existing reports continue to render where possible.
Describe the bug
When sonarqube generates a new PR comment via this plugin and posts it to a github PR, it renders the SVGs correct in the github UI. However, when that same comment is viewed in gmail web UI, the svg images appear broken (see attached screenshot).
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The SVG images will be displayed instead of borken.
Software Versions
8.9-communityHere is screenshot of a github PR comment in github web UI:
Here is screenshot of the content when viewed in gmail.
The text was updated successfully, but these errors were encountered: