Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[env+ga] fix: fix versions for building local and on github #100

Merged
merged 1 commit into from
Sep 21, 2023
Merged

[env+ga] fix: fix versions for building local and on github #100

merged 1 commit into from
Sep 21, 2023

Conversation

grejdi-mbta
Copy link
Collaborator

@grejdi-mbta grejdi-mbta commented Sep 21, 2023 •
edited
Loading

Address two issues:

  • Glue build was not working, hence we couldn't deploy.
  • Local build was failing due to python3.7 version update and a poetry issue with the latest version.

grejdi-mbta
grejdi-mbta commented Sep 21, 2023
View reviewed changes
.github/workflows/glue-python-deploy.yaml
@@ -58,7 +58,7 @@ jobs:
- name: Prepare for installing dependencies and package
working-directory: ${{github.workspace}}/py_cubic_ingestion
run: |
poetry export --output requirements.txt
poetry export --without-hashes --output requirements.txt
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressing this issue: python-poetry/poetry#3472

@github-actions
Copy link

Coverage of commit a1f76ae

Summary coverage rate:
  lines......: 93.1% (529 of 568 lines)
  functions..: 74.2% (178 of 240 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

napilla
napilla approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@napilla napilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approving and wonder if we need to document where versions should be changed in the project, if we need to update poetry versions again.

docker/Dockerfile.glue_2_0__local Show resolved Hide resolved
@grejdi-mbta grejdi-mbta force-pushed the gg-fix-versions-for-building branch from a1f76ae to 814efdb Compare September 21, 2023 13:34
@grejdi-mbta grejdi-mbta merged commit 0d9e31c into main Sep 21, 2023
@grejdi-mbta grejdi-mbta deleted the gg-fix-versions-for-building branch September 21, 2023 13:37
@github-actions
Copy link

Coverage of commit 814efdb

Summary coverage rate:
  lines......: 93.1% (529 of 568 lines)
  functions..: 74.2% (178 of 240 functions)
  branches...: no data found

Files changed coverage rate: n/a

Download coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@napilla napilla napilla approved these changes

@paulswartz paulswartz Awaiting requested review from paulswartz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grejdi-mbta @napilla