Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[env+ga] fix: fix versions for building local and on github #100

Merged
merged 1 commit into from
Sep 21, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/glue-python-deploy.yaml
Original file line number Diff line number Diff line change
@@ -58,7 +58,7 @@ jobs:
- name: Prepare for installing dependencies and package
working-directory: ${{github.workspace}}/py_cubic_ingestion
run: |
poetry export --output requirements.txt
poetry export --without-hashes --output requirements.txt
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressing this issue: python-poetry/poetry#3472

poetry build
- name: Install dependencies and py_cubic_ingestion package into 'libs'
working-directory: ${{github.workspace}}/py_cubic_ingestion
4 changes: 2 additions & 2 deletions .tool-versions
Original file line number Diff line number Diff line change
@@ -2,6 +2,6 @@ adr-tools 3.0.0
elixir 1.13.2-otp-24
erlang 24.2.1
java openjdk-11
poetry 1.4.2
python 3.7.12
poetry 1.3.2
python 3.7.17
terraform 1.1.8
3 changes: 2 additions & 1 deletion docker/Dockerfile.glue_2_0__local
Original file line number Diff line number Diff line change
@@ -31,7 +31,8 @@ ENV SPARK_HOME=/spark-2.4.3-bin-spark-2.4.3-bin-hadoop2.8
RUN /glue/bin/gluesparksubmit --version

# python packaging
RUN pip install poetry
### Note: This version here needs to match .tool-versions
RUN pip install poetry==1.3.2
# install py_cubic_ingestion's required python dependencies
COPY ./py_cubic_ingestion /data_platform/py_cubic_ingestion
WORKDIR /data_platform/py_cubic_ingestion
3 changes: 2 additions & 1 deletion docker/Dockerfile.glue_3_0__local
Original file line number Diff line number Diff line change
@@ -32,7 +32,8 @@ ENV SPARK_HOME=/spark-3.1.1-amzn-0-bin-3.2.1-amzn-3
RUN /glue/bin/gluesparksubmit --version

# python packaging
RUN pip install poetry
### Note: This version here needs to match .tool-versions
RUN pip install poetry==1.3.2
# install py_cubic_ingestion's required python dependencies
COPY ./py_cubic_ingestion /data_platform/py_cubic_ingestion
WORKDIR /data_platform/py_cubic_ingestion
3 changes: 2 additions & 1 deletion py_cubic_ingestion/pyproject.toml
Original file line number Diff line number Diff line change
@@ -9,7 +9,8 @@ packages = [
]

[tool.poetry.dependencies]
python = "3.7.12"
### Note: This version here needs to match .tool-versions
python = "3.7.17"
python-dateutil = "^2.8.2"
boto3-stubs = {extras = ["glue"], version = "^1.24.23"}