Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1895] Make postcode field non-nullable #874

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

pi-sigma
Copy link
Contributor

@pi-sigma pi-sigma commented Dec 4, 2023

Prevent None for postcode in profile templates by making postcode field non-nullable

Taiga #1895

@pi-sigma pi-sigma force-pushed the fix/1895-profile-page-null-values branch from 356e5ad to f2503d7 Compare December 4, 2023 10:47
@pi-sigma pi-sigma force-pushed the fix/1895-profile-page-null-values branch from f2503d7 to b1a297d Compare December 4, 2023 10:57
@codecov-commenter
Copy link

codecov-commenter commented Dec 4, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (bbc1a2a) 92.79% compared to head (b1a297d) 92.80%.
Report is 2 commits behind head on develop.

Files Patch % Lines
src/open_inwoner/accounts/models.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #874   +/-   ##
========================================
  Coverage    92.79%   92.80%           
========================================
  Files          800      801    +1     
  Lines        27482    27500   +18     
========================================
+ Hits         25503    25522   +19     
+ Misses        1979     1978    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pi-sigma pi-sigma marked this pull request as ready for review December 4, 2023 12:52
@stevenbal stevenbal merged commit 345147d into develop Dec 4, 2023
14 checks passed
@stevenbal stevenbal deleted the fix/1895-profile-page-null-values branch December 4, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants