Merge pull request #874 from maykinmedia/fix/1895-profile-page-null-v…

…alues [#1895] Make postcode field non-nullable
maykinmedia · Dec 4, 2023 · 345147d · 345147d
2 parents fb7829f + b1a297d
commit 345147d
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 4 deletions.
diff --git a/src/open_inwoner/accounts/migrations/0069_alter_user_postcode.py b/src/open_inwoner/accounts/migrations/0069_alter_user_postcode.py
@@ -0,0 +1,22 @@
+# Generated by Django 3.2.20 on 2023-12-04 09:07
+
+from django.db import migrations
+
+import localflavor.nl.models
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ("accounts", "0068_relax_email_constraint_for_eherkenning"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="user",
+            name="postcode",
+            field=localflavor.nl.models.NLZipCodeField(
+                blank=True, default="", max_length=7, verbose_name="Postcode"
+            ),
+        ),
+    ]
diff --git a/src/open_inwoner/accounts/models.py b/src/open_inwoner/accounts/models.py
@@ -151,7 +151,7 @@ class User(AbstractBaseUser, PermissionsMixin):
         verbose_name=_("House number"), default="", blank=True, max_length=250
     )
     postcode = NLZipCodeField(
-        verbose_name=_("Postcode"), null=True, blank=True, max_length=250
+        verbose_name=_("Postcode"), blank=True, default="", max_length=250
     )
     city = models.CharField(
         verbose_name=_("City"),
@@ -350,7 +350,7 @@ def get_age(self):
 
     def get_address(self):
         if self.street:
-            return f"{self.street} {self.housenumber}, {self.city}"
+            return f"{self.street} {self.housenumber}, {self.postcode} {self.city}"
         return ""
 
     def get_new_messages_total(self) -> int:

diff --git a/src/open_inwoner/templates/pages/profile/me.html b/src/open_inwoner/templates/pages/profile/me.html
@@ -11,7 +11,7 @@
 
 <div class="tabled tabled--flexible">
     <h1 class="h1 tabled__title">{% trans "Welkom" %}, {{ user.first_name }}</h1>
-    <span class="tabled__key">{%trans "voor het laatst ingelogd op" %}: <span class="tabled__value">{{ user.last_login|date:"d-m-Y" }} om {{ user.last_login|date:"H:i" }} uur</span></span>
+    <span class="tabled__key">{%trans "voor het laatst ingelogd op" %}: <span class="tabled__value">{{ user.last_login|date:"d F Y" }} om {{ user.last_login|date:"H:i" }} uur</span></span>
 </div>
 
 {# Personal information #}
@@ -38,7 +38,7 @@ <h2 class="h2 title" id="personal-overview">{% trans "Persoonlijke gegevens" %}
     </div>
     <div class="tabled__row tabled__row--blank">
         <div class="tabled__item tabled__key">{% trans "Geboortedatum" %}</div>
-        <div class="tabled__item tabled__value">{{ user.birthday|date:"d.m.Y" }}</div>
+        <div class="tabled__item tabled__value">{{ user.birthday|date:"d F Y" }}</div>
     </div>
     <div class="tabled__row tabled__row--blank">
         <div class="tabled__item tabled__key">{% trans "Adres" %}</div>