✨ [#1797] Show filename(s) in success msg for document upload

src/open_inwoner/cms/cases/views/status.py

@@ -477,12 +477,22 @@ def handle_document_upload(self, request, form):
                         filename=file.name,
                     ),
                 )
+
+                # TODO implement `created_documents` properly when uploading of multiple
+                # docs is implemented
+                created_documents = [created_document]
+                success_message = (
+                    _(
+                        "Wij hebben **{num_uploaded} bestand(en)** succesvol geüpload:"
+                    ).format(num_uploaded=len(created_documents))
+                    + "\n\n"
+                    + "\n".join(f"- {doc['titel']}" for doc in created_documents)
+                )
                 messages.add_message(
                     request,
                     messages.SUCCESS,
-                    _("{filename} has been successfully uploaded").format(
-                        filename=file.name
-                    ),
+                    success_message,
+                    extra_tags="as_markdown local_message",
                 )
 
                 return HttpResponseClientRedirect(

src/open_inwoner/components/templates/components/Notification/Notification.html

@@ -1,4 +1,4 @@
-{% load i18n button_tags icon_tags button_tags icon_tags %}
+{% load i18n ssd_tags button_tags icon_tags button_tags icon_tags %}
 <div class="notification{% if contents %} notification--contents{% endif %}{% if type %} notification--{{ type }}{% endif %}{% if compact %} notification--compact{% endif %} {% if ctx %}notification--{{ ctx }}{% endif %}">
     {% if not icon == False %}
         <div class="notification__icon">
@@ -13,7 +13,11 @@
         {% if contents %}
             {{ contents }}
         {% else %}
-            <p class="p p--compact">{{ message }}</p>
+            {% if as_markdown %}
+                {{ message|markdown|safe }}
+            {% else %}
+                <p class="p p--compact">{{ message }}</p>
+            {% endif %}
         {% endif %}
     </div>
 

src/open_inwoner/components/templates/components/Notification/Notifications.html

@@ -1,7 +1,13 @@
-{% load notification_tags %}
+{% load notification_tags string_tags %}
 
 <div class="notifications">
     {% for message in messages %}
-        {% notification icon=message.icon type=message.level_tag message=message.message closable=True compact=compact %}
+        {% with as_markdown=message.extra_tags|is_substring:"as_markdown" %}
+            {% with local_message=message.extra_tags|is_substring:"local_message" %}
+                {% if show_local_messages and local_message or not show_local_messages and not local_message %}
+                    {% notification icon=message.icon type=message.level_tag message=message.message as_markdown=as_markdown closable=True compact=compact %}
+                {% endif %}
+            {% endwith %}
+        {% endwith %}
     {% endfor %}
 </div>

src/open_inwoner/components/templatetags/string_tags.py

@@ -29,3 +29,12 @@ def optional_paragraph(optional_text: str) -> str:
             optional_text=linebreaksbr(optional_text)
         )
     )
+
+
+@register.filter
+def is_substring(arg1, arg2):
+    """check if arg2 is a substring of arg1"""
+    if not arg1:
+        return False
+
+    return arg2 in arg1

src/open_inwoner/openzaak/tests/test_case_detail.py

@@ -275,6 +275,7 @@ def setUpTestData(cls):
             vertrouwelijkheidaanduiding=VertrouwelijkheidsAanduidingen.openbaar,
             bestandsnaam="upload.txt",
             bestandsomvang=123,
+            titel="uploaded file",
         )
 
         cls.zaak_informatie_object_invisible = generate_oas_component(
@@ -905,8 +906,8 @@ def test_successful_document_upload_flow(self, m):
 
         self.assertEqual(
             redirect_messages[0].message,
-            _(
-                f"{self.uploaded_informatie_object['bestandsnaam']} is succesvol geüpload"
+            _("Wij hebben **1 bestand(en)** succesvol geüpload:\n\n- {title}").format(
+                title="uploaded file"
             ),
         )
 
@@ -942,10 +943,18 @@ def test_successful_document_upload_flow_with_uppercase_extension(self, m):
 
         redirect = self.app.get(form_response.headers["HX-Redirect"])
         redirect_messages = list(redirect.context["messages"])
+        upload_request = next(
+            request
+            for request in m.request_history
+            if request.url == f"{DOCUMENTEN_ROOT}enkelvoudiginformatieobjecten"
+        )
 
+        self.assertEqual(upload_request.json()["bestandsnaam"], "upload.TXT")
         self.assertEqual(
             redirect_messages[0].message,
-            _("upload.TXT is succesvol geüpload"),
+            _("Wij hebben **1 bestand(en)** succesvol geüpload:\n\n- {title}").format(
+                title="uploaded file"
+            ),
         )
 
     def test_upload_file_flow_fails_with_invalid_file_extension(self, m):

src/open_inwoner/scss/components/Notification/_Notification.scss

@@ -92,4 +92,12 @@
       position: inherit;
     }
   }
+
+  & &__content {
+    margin-top: 0.15em;
+
+    & * {
+      margin: 0;
+    }
+  }
 }

src/open_inwoner/templates/pages/cases/status_inner.html

@@ -31,6 +31,8 @@ <h2 class="h2" id="documents">{% trans 'Documenten' %}</h2>
             {% if case.internal_upload_enabled %}
                 <h2 class="h2" id="documents-upload">{% trans "Document uploaden" %}</h2>
 
+                {% notifications messages show_local_messages=True %}
+
                 {% if case.case_type_document_upload_description %}
                 <div class="card card--compact card--info">
                     <div class="card__body document-upload-description">