✨ [#1797] Show filename(s) in success msg for document upload #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenbal
force-pushed
the
feature/1797-success-message-after-file-upload
branch
3 times, most recently
from
7565db0
to
08da81a
Compare
stevenbal
force-pushed
the
feature/1797-success-message-after-file-upload
branch
from
08da81a
to
136638f
Compare
Codecov Report
@@ Coverage Diff @@
## develop #837 +/- ##
===========================================
- Coverage 92.84% 92.84% -0.01%
===========================================
Files 752 752
Lines 26127 26136 +9
===========================================
+ Hits 24257 24265 +8
- Misses 1870 1871 +1
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
stevenbal
changed the title
pi-sigma
reviewed
Nov 9, 2023
| @@ -92,4 +92,12 @@ | |||
| position: inherit; | |||
| } | |||
| } | |||
|
|
|||
| & &__content { | |||
There was a problem hiding this comment.
Is it usual to have block and element as part of the same class? I'm familiar with block__element block__element--modifier but haven't seen block block__element before. Or perhaps I misunderstand the & & syntax.
pi-sigma
reviewed
Nov 9, 2023
|
|
||
| <div class="notifications"> | ||
| {% for message in messages %} | ||
| {% notification icon=message.icon type=message.level_tag message=message.message closable=True compact=compact %} | ||
| {% with as_markdown=message.extra_tags|is_substring:"as_markdown" %} |
There was a problem hiding this comment.
extra_tags|has_as_substring:"as_markdown" would read more natural imho (similarly for the signature of the tag).
pi-sigma
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taiga: https://taiga.maykinmedia.nl/project/open-inwoner/task/1797