Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1268] Disable case document button when form is being submitted #553

Merged
merged 2 commits into from
Apr 2, 2023

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Mar 23, 2023

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #553 (8c29141) into develop (f0437e6) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #553   +/-   ##
========================================
  Coverage    96.47%   96.47%           
========================================
  Files          540      540           
  Lines        19216    19216           
========================================
  Hits         18539    18539           
  Misses         677      677           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@Bartvaderkin Bartvaderkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, maybe it should change style to show disabled state?

@jiromaykin
Copy link
Contributor

How can I test this in the front-end? Do I need to add a new Aanvraag through Open Forms first?

1 similar comment
@jiromaykin
Copy link
Contributor

How can I test this in the front-end? Do I need to add a new Aanvraag through Open Forms first?

Copy link
Contributor

@jiromaykin jiromaykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested something that needs to be checked if it works, maybe you'll need a more specific selector for the disabled button inside a form.

src/open_inwoner/js/components/cases/index.js Show resolved Hide resolved
@alextreme alextreme merged commit a90a00e into develop Apr 2, 2023
@alextreme alextreme deleted the fix/1268-prevent-multiple-case-documents-upload branch April 2, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants