♿ [#2357] Correct product-pages 400% zoom #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiromaykin
force-pushed
the
issue/2357-A11y-zoom-400
branch
from
ea5e06c
to
26077e3
Compare
jiromaykin
force-pushed
the
issue/2357-A11y-zoom-400
branch
from
3ff41ee
to
a4bd73e
Compare
pi-sigma
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: https://taiga.maykinmedia.nl/project/open-inwoner/task/2357
This Zoom issue was already solved for just the Tables by #1258 (by making them break on word normally)
so all that was left, is to actually show the overflowing content...
Problem happens for example when zooming in 400% in case of a product-page with an extremely long H1 title, with more than 24 characters without any breaking dashes etc. which will make an overflow dus to its large font-size.
So here the 'readmore' content should only remain hidden when that functionality is toggled.
When 'readmore' is off or toggled 'open', all content should be visible at all zoom-levels.
Note: Scrollbars appearing are OK for accessibility.
We cannot control the use of long words, and words like 'Verkiezingsprogrammalijst' do exist in Dutch, so if these are in a Heading, scrollbars will appear.
Toggle functionality for editing/posting a product-page >> "Productcontent ingeklapt / Bepaalt of de productcontent standaard is ingeklapt."