Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1186] Hiding Geboorteland from Mijn Gegevens (BRP) #504

Merged
merged 3 commits into from
Feb 28, 2023
Merged

[#1186] Hiding Geboorteland from Mijn Gegevens (BRP) #504

merged 3 commits into from
Feb 28, 2023

Conversation

alextreme
Copy link
Member

No description provided.

vaszig
vaszig approved these changes Feb 28, 2023
View reviewed changes
Copy link
Contributor

@vaszig vaszig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not temporary removal, we should maybe update the view as well (MyDataView ), by removing the field from there as well.

@alextreme
Copy link
Member Author

If it's not temporary removal, we should maybe update the view as well (MyDataView ), by removing the field from there as well.

Good idea, fixed

@alextreme alextreme merged commit 0bd3c56 into develop Feb 28, 2023
@alextreme alextreme deleted the issue-1186-remove-geboorteland branch February 28, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaszig vaszig vaszig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alextreme @vaszig