Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2322] Added Celery and Celery-beat #1186

Merged
merged 9 commits into from
May 27, 2024
Merged

[#2322] Added Celery and Celery-beat #1186

merged 9 commits into from
May 27, 2024

Conversation

Bartvaderkin
Copy link
Contributor

No description provided.

@Bartvaderkin Bartvaderkin force-pushed the feature/2322-celery branch 2 times, most recently from e87ed3e to 3874d34 Compare May 13, 2024 13:38
@pi-sigma pi-sigma force-pushed the feature/2322-celery branch 2 times, most recently from b8948ad to 7ba53ad Compare May 14, 2024 14:27
@codecov-commenter
Copy link

codecov-commenter commented May 14, 2024

Codecov Report

Attention: Patch coverage is 83.16832% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 95.18%. Comparing base (062dcb4) to head (3219f0e).

Files Patch % Lines
src/open_inwoner/utils/admin.py 53.12% 15 Missing ⚠️
src/open_inwoner/celery.py 85.71% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1186      +/-   ##
===========================================
- Coverage    95.21%   95.18%   -0.03%     
===========================================
  Files          963      966       +3     
  Lines        34813    34912      +99     
===========================================
+ Hits         33148    33232      +84     
- Misses        1665     1680      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bartvaderkin Bartvaderkin force-pushed the feature/2322-celery branch 2 times, most recently from c94d608 to 83e0596 Compare May 16, 2024 11:38
@Bartvaderkin Bartvaderkin marked this pull request as ready for review May 23, 2024 08:19
@pi-sigma pi-sigma force-pushed the feature/2322-celery branch from 83e0596 to e89538d Compare May 24, 2024 09:02
@pi-sigma pi-sigma force-pushed the feature/2322-celery branch from e89538d to a8562bb Compare May 24, 2024 13:42
@pi-sigma pi-sigma self-requested a review May 24, 2024 14:21
@alextreme alextreme self-requested a review May 24, 2024 14:32
@alextreme
Copy link
Member

FYI, the following appeared during the first migrate. After running it again the django-admin-index fixture was loaded in properly:

Error: Unable to load django-admin-index fixture (ContentTypeProxy matching query does not exist.: (admin_index.appgroup:pk=544) field_value was '['django_celery_beat', 'periodictask']')

Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there, a few final remarks. And we need to update deployment + helm charts, but thats for a separate PR

@alextreme
Copy link
Member

Can be merged after CI is green

@alextreme alextreme merged commit 336f9fa into develop May 27, 2024
18 checks passed
@alextreme alextreme deleted the feature/2322-celery branch May 27, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants