Replace django-mailer with django-yubin #1231
Conversation
| class DailyFailingEmailDigestTestCase(TestCase): | ||
| def test_no_recipients_configured(self): | ||
| config = SiteConfiguration.get_solo() | ||
| config.recipients_email_digest = [] | ||
| config.save() | ||
|
|
||
| with freeze_time("2024-01-01T12:00:00"): | ||
| make_message_log(["[email protected]"], "failed message", RESULT_FAILURE) | ||
| message = Message.objects.create( |
There was a problem hiding this comment.
My sense is that it would make more sense to use Django's send_mail rather than manually creating the artifacts we expect django-yubin to create as a consequence of that call.
We should also double-check we've configured the correct testing backends where yubin expects them. The Django docs say that EMAIL_BACKEND is automatically set to "django.core.mail.backends.locmem.EmailBackend" during testing , but I believe what we want here is for the EMAIL_BACKEND to be explicitly set to "django_yubin.backends.QueuedEmailBackend" and for MAILSER_USE_BACKEND to be set to the in-memory variety.
There was a problem hiding this comment.
This seems okay but isn't fully complete. Note that only the send_mail task seems to be added automatically (this will need to be verified after merging and deploying to the testenvironment).
The management commands are gone with Yubin 2.x so afaik we need to add all yubin tasks we need to CELERY_BEAT_SCHEDULE (we don't want to manually add celery beat tasks individually per install)
https://django-yubin.readthedocs.io/en/latest/queue.html#tasks
For retry_emails (1x per hour) and delete_old_emails (1x per day) we also have (less frequent) cronjobs
You don’t usually need to create a send_email task, Yubin email backend does it automatically. For retry_emails and delete_old_emails, you can use Celery Beat to schedule periodic task.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1231 +/- ##
===========================================
- Coverage 95.22% 95.22% -0.01%
===========================================
Files 968 968
Lines 35254 35245 -9
===========================================
- Hits 33571 33562 -9
Misses 1683 1683 ☔ View full report in Codecov by Sentry. |
|
Can be merged in develop, however PR is still in draft |
Reverting the previous change in #1090