Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2199] Replaced django-yubin with django-mailer #1090

Merged
merged 6 commits into from
Mar 14, 2024

Conversation

Bartvaderkin
Copy link
Contributor

@Bartvaderkin Bartvaderkin commented Mar 14, 2024

.

@Bartvaderkin Bartvaderkin changed the title [#2199] Updated settings for django-yubin [#2199] Replaced django-yubin with django-mailer Mar 14, 2024
@Bartvaderkin Bartvaderkin requested review from alextreme and removed request for pi-sigma March 14, 2024 12:53
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.88%. Comparing base (cd7160b) to head (63a378e).

❗ Current head 63a378e differs from pull request most recent head 3246ff9. Consider uploading reports for the commit 3246ff9 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1090      +/-   ##
===========================================
- Coverage    95.00%   94.88%   -0.12%     
===========================================
  Files          896      894       -2     
  Lines        31449    31421      -28     
===========================================
- Hits         29879    29815      -64     
- Misses        1570     1606      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Bartvaderkin
Copy link
Contributor Author

Bartvaderkin commented Mar 14, 2024

@alextreme This should be good for testing.

I'm currently updating the 'send_failed_mail_digest' cronjob I disabled to get this green quickly.

I added the fixed 'send_failed_mail_digest' as a PR on this PR Merged it to here after review

…-inform

[#2199] Re-implemented `inform_admins_about_failing_emails()` for django-mailer
@alextreme
Copy link
Member

Only one way to check this...

@alextreme alextreme merged commit 8c390ce into develop Mar 14, 2024
17 checks passed
@alextreme alextreme deleted the fix/2199-yubin-problems branch March 14, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants