Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep .ruby_version file in Docker #523

Merged

Conversation

corsonknowles
Copy link
Contributor

@corsonknowles corsonknowles commented Mar 7, 2024

Copy link
Collaborator

@zachgoll zachgoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @robzolkos, looks like this is the default for rails new now?

Dockerfile Outdated Show resolved Hide resolved
@robzolkos
Copy link
Contributor

Good catch @robzolkos, looks like this is the default for rails new now?

No rails new will spit out unchanged Dockerfile

This functionality was reverted in Rails main. I suspect largely due to it being a generator.

I think copying over the .ruby-version prior to the Gemfile should work fine. Maybe is already generated so little risk in smoothing over these edges.

@zachgoll
Copy link
Collaborator

zachgoll commented Mar 7, 2024

Good catch @robzolkos, looks like this is the default for rails new now?

No rails new will spit out unchanged Dockerfile

This functionality was reverted in Rails main. I suspect largely due to it being a generator.

I think copying over the .ruby-version prior to the Gemfile should work fine. Maybe is already generated so little risk in smoothing over these edges.

Ahh, hadn't seen that commit. Sounds good, and we can revisit this with more scrutiny later when implementing #295

Signed-off-by: Zach Gollwitzer <[email protected]>
@zachgoll zachgoll merged commit 0e77bab into maybe-finance:main Mar 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants