Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use our .ruby-version file in Bundler so it is managed in only 1 place #520

Merged

Conversation

corsonknowles
Copy link
Contributor

@corsonknowles corsonknowles commented Mar 6, 2024

This provides a single source of truth and simplifies staying current on Ruby.

Background writeup: https://gorails.com/episodes/bundler-ruby-version-file
Original issue: rubygems/rubygems#6742
Implementation: rubygems/rubygems#6876

@zachgoll zachgoll merged commit 680a91d into maybe-finance:main Mar 6, 2024
@robzolkos
Copy link
Contributor

This change will break the Dockerfile as the .ruby-version file isn't copied over when bundler is run. (I think we reverted this change due to this a while back). Rails main has removed the ruby version from the Gemfile completely last I checked (a couple of weeks ago). Anyway you may get some issues raised with Docker no longer working for some peeps.

@corsonknowles
Copy link
Contributor Author

Thanks @robzolkos This is a widely used and much beloved new feature of Bundler. I was about to say I'll take a look at what is idiosyncratic about our Dockerfile tomorrow, but from the helpful description you provided, I think we can simply do this:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants