feat: add MCP server filter to MCP sessions sidebar - #5918
Merged
Conversation
This was referenced Aug 6, 2026
Merged
Merged
Merged
Merged
refactor: migrate OAuth flow state/PKCE fields from
oauth_configs to new mcp_oauth_flows table
#5709
Merged
Merged
Collaborator
Author
This was referenced Aug 6, 2026
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ui/app/workspace/mcp-sessions/views/mcpSessionsFilterSidebar.tsx`:
- Around line 394-416: Update the useGetMCPClientsQuery usage in the MCP filter
sidebar to read its isError state and pass that failure state to
SearchableCheckboxList using the component’s existing error and retry APIs.
Ensure failed requests render an error message with a retry action instead of
the empty “No results” state, while preserving the current loading, empty, and
successful client-list behavior.
- Around line 386-411: The MCP client filter UI must keep every ID in
filters.mcp_client_id visible and removable even when authType, searchQuery, or
the offset-0 pagination excludes it. Update the mcpClients construction in the
MCP client filter section to merge selected clients into the fetched results,
resolving their labels as needed, while preserving the existing query results
and avoiding duplicates.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 310c035f-d94c-42b2-9973-54b08d6b827f
📒 Files selected for processing (2)
ui/app/workspace/mcp-sessions/page.tsxui/app/workspace/mcp-sessions/views/mcpSessionsFilterSidebar.tsx
Pratham-Mishra04
force-pushed
the
08-06-feat_replace_mcp_oauth_grants_top_filter_bar_with_a_side_filter_panel
branch
from
August 6, 2026 21:53
ee6329e to
67a9f01
Compare
Pratham-Mishra04
force-pushed
the
08-06-feat_add_mcp_server_filter_to_auth_sessions_sidebar_scoped_to_per-user_auth_types_and_the_selected_type_filter
branch
from
August 6, 2026 21:53
e77affc to
195a3dc
Compare
Contributor
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Pratham-Mishra04
force-pushed
the
08-06-feat_replace_mcp_oauth_grants_top_filter_bar_with_a_side_filter_panel
branch
from
August 8, 2026 10:29
67a9f01 to
faca1fc
Compare
Pratham-Mishra04
force-pushed
the
08-06-feat_add_mcp_server_filter_to_auth_sessions_sidebar_scoped_to_per-user_auth_types_and_the_selected_type_filter
branch
from
August 8, 2026 10:29
195a3dc to
9f7e91b
Compare
This was referenced Aug 8, 2026
Collaborator
Author
Merge activity
|
Pratham-Mishra04
changed the base branch from
08-06-feat_replace_mcp_oauth_grants_top_filter_bar_with_a_side_filter_panel
to
graphite-base/5918
August 8, 2026 11:18
Pratham-Mishra04
dismissed
coderabbitai[bot]’s stale review
August 8, 2026 11:21
The base branch was changed.
…ser auth types and the selected Type filter
Pratham-Mishra04
force-pushed
the
08-06-feat_add_mcp_server_filter_to_auth_sessions_sidebar_scoped_to_per-user_auth_types_and_the_selected_type_filter
branch
from
August 8, 2026 11:21
9f7e91b to
58f2e0e
Compare
Pratham-Mishra04
deleted the
08-06-feat_add_mcp_server_filter_to_auth_sessions_sidebar_scoped_to_per-user_auth_types_and_the_selected_type_filter
branch
August 8, 2026 11:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Adds an "MCP Server" filter section to the MCP Sessions filter sidebar, allowing users to narrow sessions down to one or more specific MCP clients. The
mcp_client_idfilter is now fully integrated into the shared filter state rather than being managed separately through URL state.Changes
mcp_client_idto theMCPSessionFiltersinterface andEMPTY_FILTERS, bringing it in line with the other filter fields (kind,status,auth_mode) so it participates in filter count, reset, and URL sync correctly.mcp_client_idwas being read directly fromurlStatefor the query instead of from the unifiedfiltersobject, causing it to be out of sync with the rest of the filter pipeline.MCPClientFilterSectionto the filter sidebar — a collapsible section with a searchable checkbox list of MCP clients. The list is fetched lazily (only when the section is opened or a selection already exists) and scoped toper_user_oauthand/orper_user_headersauth types, narrowed automatically based on the active "Type" filter.SearchableCheckboxList, a reusable component combining a debounced search input with checkbox rows, supporting server-side search via anonSearchcallback and a loading indicator.useAutoFocusOnOpen, a hook that focuses the search input when the section is explicitly opened by the user, skipping the initial mount to avoid stealing focus on page load.FilterSectionwith anonOpenChangecallback so parent components can react to collapse/expand events.filtersActiveandactiveFilterCountto includemcp_client_id, ensuring the reset button and active filter badge reflect this filter correctly.Type of change
Affected areas
How to test
mcp_client_idis cleared along with the other filters.mcp_client_idin the URL and confirm the section opens pre-populated.Screenshots/Recordings
Add before/after screenshots of the filter sidebar showing the new "MCP Server" section.
Breaking changes
Related issues
Security considerations
No new auth or PII concerns. The MCP client list query is scoped to per-user auth types and respects existing access controls.
Checklist
docs/contributing/README.mdand followed the guidelines