docs: document make-before-break reconnection and shared-client retry behavior - #5728
Merged
Pratham-Mishra04 merged 1 commit intoAug 8, 2026
Conversation
This was referenced Jul 30, 2026
|
|
This was referenced Jul 30, 2026
Merged
refactor: migrate OAuth flow state/PKCE fields from
oauth_configs to new mcp_oauth_flows table
#5709
Merged
Merged
Merged
This was referenced Aug 6, 2026
Pratham-Mishra04
force-pushed
the
07-31-docs_document_make-before-break_reconnection_and_shared-client_retry_behavior
branch
from
August 6, 2026 21:53
2622dc5 to
eb95068
Compare
Pratham-Mishra04
marked this pull request as ready for review
August 8, 2026 08:41
Contributor
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Pratham-Mishra04
force-pushed
the
07-30-feat_make_mcp_reconnection_make-before-break_for_http_and_sse_clients
branch
from
August 8, 2026 08:43
5c06241 to
a48cdde
Compare
Pratham-Mishra04
force-pushed
the
07-31-docs_document_make-before-break_reconnection_and_shared-client_retry_behavior
branch
from
August 8, 2026 08:43
eb95068 to
521a4f1
Compare
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/mcp/tool-execution.mdx`:
- Around line 389-390: Update the shared-client retry documentation around the
“Shared clients” and “Safety opt-out” bullets to state that retries require an
explicit idempotency/retry-safety annotation. Include missing or unsafe
annotations among the conditions that prevent retries, while preserving the
background reconnect behavior and original-error semantics.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: cec7d011-a8eb-4849-8cee-1e5f7012ab74
📒 Files selected for processing (4)
docs/mcp/auth/oauth.mdxdocs/mcp/auth/overview.mdxdocs/mcp/gateway.mdxdocs/mcp/tool-execution.mdx
🚧 Files skipped from review as they are similar to previous changes (3)
- docs/mcp/auth/overview.mdx
- docs/mcp/gateway.mdx
- docs/mcp/auth/oauth.mdx
Pratham-Mishra04
changed the base branch from
07-30-feat_make_mcp_reconnection_make-before-break_for_http_and_sse_clients
to
graphite-base/5728
August 8, 2026 10:08
Pratham-Mishra04
force-pushed
the
graphite-base/5728
branch
from
August 8, 2026 10:12
a48cdde to
942cedf
Compare
Pratham-Mishra04
force-pushed
the
07-31-docs_document_make-before-break_reconnection_and_shared-client_retry_behavior
branch
from
August 8, 2026 10:12
521a4f1 to
1e66c03
Compare
graphite-app
Bot
dismissed
coderabbitai[bot]’s stale review
August 8, 2026 10:13
The base branch was changed.
Pratham-Mishra04
force-pushed
the
07-31-docs_document_make-before-break_reconnection_and_shared-client_retry_behavior
branch
from
August 8, 2026 10:13
1e66c03 to
b01a319
Compare
This was referenced Aug 8, 2026
Collaborator
Author
Merge activity
|
Pratham-Mishra04
deleted the
07-31-docs_document_make-before-break_reconnection_and_shared-client_retry_behavior
branch
August 8, 2026 10:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Briefly explain the purpose of this PR and the problem it solves.
Changes
Type of change
Affected areas
How to test
Describe the steps to validate this change. Include commands and expected outcomes.
If adding new configs or environment variables, document them here.
Screenshots/Recordings
If UI changes, add before/after screenshots or short clips.
Breaking changes
If yes, describe impact and migration instructions.
Related issues
Link related issues and discussions. Example: Closes #123
Security considerations
Note any security implications (auth, secrets, PII, sandboxing, etc.).
Checklist
docs/contributing/README.mdand followed the guidelines