override ux fixes - #5523
Merged
Merged
override ux fixes#5523
Conversation
Contributor
📝 WalkthroughWalkthroughVirtual key views add fallback components for managed-profile actions and user details, show unset provider weights as “Not Set,” expose managing-profile details, and standardize the budget override trigger styling. ChangesManaged Virtual Key UI
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 3❌ Failed checks (2 warnings, 1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
|
akshaydeo
marked this pull request as ready for review
July 24, 2026 09:28
Contributor
Author
Merge activity
|
akshaydeo
added a commit
that referenced
this pull request
Jul 24, 2026
## Summary Bumps several Go dependencies to their latest patch/minor versions and adds two new UI components to improve the virtual key management experience for access-profile-managed keys. ## Changes - **Dependency upgrades:** - `GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp`: `v1.31.0` → `v1.32.0` - `go.opentelemetry.io/contrib/detectors/gcp`: `v1.42.0` → `v1.43.0` - `google.golang.org/genproto/googleapis/api`: `20260401` → `20260414` - `google.golang.org/grpc`: `v1.81.1` → `v1.82.1` - **`ManagedVirtualKeyActions` component:** Added a new enterprise component (with an OSS no-op fallback) rendered inside the access-profile alert banner in `virtualKeySheet.tsx`. Exposes the managing profile to allow enterprise-specific actions on managed virtual keys. - **`ViewUserDetailsButton` component:** Added a new enterprise component (with an OSS no-op fallback) rendered in the Budget Information header of `virtualKeyDetailsSheet.tsx` when a key is managed by a profile. Links to the managing profile's user details using `managingProfile.user_id`. - **`managingProfile` exposed from `useVirtualKeyUsage`:** The hook's `managingProfile` value is now destructured and passed down in `virtualKeySheet.tsx` so it can be forwarded to `ManagedVirtualKeyActions`. - **Weight display fix:** Provider config weight in `virtualKeyDetailsSheet.tsx` now renders `"Not Set"` (muted italic) instead of a blank value when `weight` is `null` or `undefined`. - **`BudgetOverrideDialog` button variant:** Changed the trigger button variant from conditionally `"outline"` (when active) to always `"ghost"` for visual consistency. ## Type of change - [ ] Bug fix - [x] Feature - [ ] Refactor - [ ] Documentation - [x] Chore/CI ## Affected areas - [ ] Core (Go) - [ ] Transports (HTTP) - [ ] Providers/Integrations - [x] Plugins - [x] UI (React) - [ ] Docs ## How to test ```sh # UI cd ui pnpm i pnpm build # Verify Go modules resolve cleanly cd framework && go mod verify cd transports && go mod verify ``` - Open a virtual key managed by an access profile and confirm the `ManagedVirtualKeyActions` slot renders (enterprise) or is invisible (OSS). - Open the details sheet for a managed key and confirm the `ViewUserDetailsButton` appears next to the Budget Information heading. - Open a provider config with no weight set and confirm `"Not Set"` is displayed instead of a blank. - Open the budget override dialog and confirm the trigger button always uses the ghost variant regardless of active state. ## Screenshots/Recordings If UI changes, add before/after screenshots or short clips. ## Breaking changes - [ ] Yes - [x] No ## Related issues Link related issues and discussions. ## Security considerations No new auth, secrets, or PII handling introduced. The `ViewUserDetailsButton` receives a `userId` prop but rendering is delegated to the enterprise implementation. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable
This was referenced Jul 28, 2026
18 tasks
akhsaul
pushed a commit
to akhsaul/bifrost
that referenced
this pull request
Aug 27, 2026
## Summary Bumps several Go dependencies to their latest patch/minor versions and adds two new UI components to improve the virtual key management experience for access-profile-managed keys. ## Changes - **Dependency upgrades:** - `GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp`: `v1.31.0` → `v1.32.0` - `go.opentelemetry.io/contrib/detectors/gcp`: `v1.42.0` → `v1.43.0` - `google.golang.org/genproto/googleapis/api`: `20260401` → `20260414` - `google.golang.org/grpc`: `v1.81.1` → `v1.82.1` - **`ManagedVirtualKeyActions` component:** Added a new enterprise component (with an OSS no-op fallback) rendered inside the access-profile alert banner in `virtualKeySheet.tsx`. Exposes the managing profile to allow enterprise-specific actions on managed virtual keys. - **`ViewUserDetailsButton` component:** Added a new enterprise component (with an OSS no-op fallback) rendered in the Budget Information header of `virtualKeyDetailsSheet.tsx` when a key is managed by a profile. Links to the managing profile's user details using `managingProfile.user_id`. - **`managingProfile` exposed from `useVirtualKeyUsage`:** The hook's `managingProfile` value is now destructured and passed down in `virtualKeySheet.tsx` so it can be forwarded to `ManagedVirtualKeyActions`. - **Weight display fix:** Provider config weight in `virtualKeyDetailsSheet.tsx` now renders `"Not Set"` (muted italic) instead of a blank value when `weight` is `null` or `undefined`. - **`BudgetOverrideDialog` button variant:** Changed the trigger button variant from conditionally `"outline"` (when active) to always `"ghost"` for visual consistency. ## Type of change - [ ] Bug fix - [x] Feature - [ ] Refactor - [ ] Documentation - [x] Chore/CI ## Affected areas - [ ] Core (Go) - [ ] Transports (HTTP) - [ ] Providers/Integrations - [x] Plugins - [x] UI (React) - [ ] Docs ## How to test ```sh # UI cd ui pnpm i pnpm build # Verify Go modules resolve cleanly cd framework && go mod verify cd transports && go mod verify ``` - Open a virtual key managed by an access profile and confirm the `ManagedVirtualKeyActions` slot renders (enterprise) or is invisible (OSS). - Open the details sheet for a managed key and confirm the `ViewUserDetailsButton` appears next to the Budget Information heading. - Open a provider config with no weight set and confirm `"Not Set"` is displayed instead of a blank. - Open the budget override dialog and confirm the trigger button always uses the ghost variant regardless of active state. ## Screenshots/Recordings If UI changes, add before/after screenshots or short clips. ## Breaking changes - [ ] Yes - [x] No ## Related issues Link related issues and discussions. ## Security considerations No new auth, secrets, or PII handling introduced. The `ViewUserDetailsButton` receives a `userId` prop but rendering is delegated to the enterprise implementation. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable
occcat
pushed a commit
to occcat/bifrost
that referenced
this pull request
Sep 2, 2026
## Summary Bumps several Go dependencies to their latest patch/minor versions and adds two new UI components to improve the virtual key management experience for access-profile-managed keys. ## Changes - **Dependency upgrades:** - `GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp`: `v1.31.0` → `v1.32.0` - `go.opentelemetry.io/contrib/detectors/gcp`: `v1.42.0` → `v1.43.0` - `google.golang.org/genproto/googleapis/api`: `20260401` → `20260414` - `google.golang.org/grpc`: `v1.81.1` → `v1.82.1` - **`ManagedVirtualKeyActions` component:** Added a new enterprise component (with an OSS no-op fallback) rendered inside the access-profile alert banner in `virtualKeySheet.tsx`. Exposes the managing profile to allow enterprise-specific actions on managed virtual keys. - **`ViewUserDetailsButton` component:** Added a new enterprise component (with an OSS no-op fallback) rendered in the Budget Information header of `virtualKeyDetailsSheet.tsx` when a key is managed by a profile. Links to the managing profile's user details using `managingProfile.user_id`. - **`managingProfile` exposed from `useVirtualKeyUsage`:** The hook's `managingProfile` value is now destructured and passed down in `virtualKeySheet.tsx` so it can be forwarded to `ManagedVirtualKeyActions`. - **Weight display fix:** Provider config weight in `virtualKeyDetailsSheet.tsx` now renders `"Not Set"` (muted italic) instead of a blank value when `weight` is `null` or `undefined`. - **`BudgetOverrideDialog` button variant:** Changed the trigger button variant from conditionally `"outline"` (when active) to always `"ghost"` for visual consistency. ## Type of change - [ ] Bug fix - [x] Feature - [ ] Refactor - [ ] Documentation - [x] Chore/CI ## Affected areas - [ ] Core (Go) - [ ] Transports (HTTP) - [ ] Providers/Integrations - [x] Plugins - [x] UI (React) - [ ] Docs ## How to test ```sh # UI cd ui pnpm i pnpm build # Verify Go modules resolve cleanly cd framework && go mod verify cd transports && go mod verify ``` - Open a virtual key managed by an access profile and confirm the `ManagedVirtualKeyActions` slot renders (enterprise) or is invisible (OSS). - Open the details sheet for a managed key and confirm the `ViewUserDetailsButton` appears next to the Budget Information heading. - Open a provider config with no weight set and confirm `"Not Set"` is displayed instead of a blank. - Open the budget override dialog and confirm the trigger button always uses the ghost variant regardless of active state. ## Screenshots/Recordings If UI changes, add before/after screenshots or short clips. ## Breaking changes - [ ] Yes - [x] No ## Related issues Link related issues and discussions. ## Security considerations No new auth, secrets, or PII handling introduced. The `ViewUserDetailsButton` receives a `userId` prop but rendering is delegated to the enterprise implementation. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Bumps several Go dependencies to their latest patch/minor versions and adds two new UI components to improve the virtual key management experience for access-profile-managed keys.
Changes
Dependency upgrades:
GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp:v1.31.0→v1.32.0go.opentelemetry.io/contrib/detectors/gcp:v1.42.0→v1.43.0google.golang.org/genproto/googleapis/api:20260401→20260414google.golang.org/grpc:v1.81.1→v1.82.1ManagedVirtualKeyActionscomponent: Added a new enterprise component (with an OSS no-op fallback) rendered inside the access-profile alert banner invirtualKeySheet.tsx. Exposes the managing profile to allow enterprise-specific actions on managed virtual keys.ViewUserDetailsButtoncomponent: Added a new enterprise component (with an OSS no-op fallback) rendered in the Budget Information header ofvirtualKeyDetailsSheet.tsxwhen a key is managed by a profile. Links to the managing profile's user details usingmanagingProfile.user_id.managingProfileexposed fromuseVirtualKeyUsage: The hook'smanagingProfilevalue is now destructured and passed down invirtualKeySheet.tsxso it can be forwarded toManagedVirtualKeyActions.Weight display fix: Provider config weight in
virtualKeyDetailsSheet.tsxnow renders"Not Set"(muted italic) instead of a blank value whenweightisnullorundefined.BudgetOverrideDialogbutton variant: Changed the trigger button variant from conditionally"outline"(when active) to always"ghost"for visual consistency.Type of change
Affected areas
How to test
ManagedVirtualKeyActionsslot renders (enterprise) or is invisible (OSS).ViewUserDetailsButtonappears next to the Budget Information heading."Not Set"is displayed instead of a blank.Screenshots/Recordings
If UI changes, add before/after screenshots or short clips.
Breaking changes
Related issues
Link related issues and discussions.
Security considerations
No new auth, secrets, or PII handling introduced. The
ViewUserDetailsButtonreceives auserIdprop but rendering is delegated to the enterprise implementation.Checklist
docs/contributing/README.mdand followed the guidelines