chore: ui descriptions cleanup by roroghost17 · Pull Request #5493 · maximhq/bifrost

roroghost17 · 2026-07-23T11:01:51Z

Summary

Replaces em-dash (—) separators used as clause connectors in UI copy with grammatically appropriate alternatives: semicolons, colons, commas, or periods. This improves readability and consistency across tooltips, descriptions, labels, alerts, and inline help text throughout the UI.

Changes

Replaced em-dashes used to join independent clauses with semicolons (e.g. "token is not revoked at the provider — it stays detached" → "...provider; it stays detached")
Replaced em-dashes used to introduce elaborations or examples with colons or commas (e.g. "Large payload request — input content..." → "Large payload request: input content...")
Replaced em-dashes used in parenthetical asides with parentheses or commas where appropriate
Changed one em-dash team name separator in a combobox label to a standard hyphen (-) since it appears in a data label context rather than prose

Type of change

Affected areas

How to test

cd ui
pnpm i || npm i
pnpm build || npm run build

Visually inspect affected UI surfaces (logging config, MCP config, routing rules, virtual keys, provider keys, pprof page, log detail view, sessions table, observability fragments) to confirm copy reads correctly with no regressions.

Screenshots/Recordings

No visual layout changes expected; only text content is affected.

Breaking changes

Yes
No

Related issues

Security considerations

None.

Checklist

I read docs/contributing/README.md and followed the guidelines
I added/updated tests where appropriate
I updated documentation where needed
I verified builds succeed (Go and UI)
I verified the CI pipeline passes locally if applicable

coderabbitai · 2026-07-23T11:02:00Z

📝 Walkthrough

Walkthrough

Changes

UI copy updates

Layer / File(s)	Summary
Diagnostics and logging copy `ui/app/pprof/page.tsx`, `ui/app/workspace/config/views/loggingView.tsx`, `ui/app/workspace/observability/fragments/*`	Updates heap allocation, leak, logging, and request-header descriptions.
MCP configuration and session copy `ui/app/workspace/config/views/mcpView.tsx`, `ui/app/workspace/mcp-registry/...`, `ui/app/workspace/mcp-sessions/views/sessionsTable.tsx`	Revises MCP warnings, helper text, OAuth messaging, and session tooltips.
Workspace form and routing copy `ui/app/workspace/governance/...`, `ui/app/workspace/model-catalog/...`, `ui/app/workspace/providers/...`, `ui/app/workspace/routing-rules/...`, `ui/app/workspace/virtual-keys/...`	Adjusts labels, validation messages, tooltips, and alerts across workspace forms.
Payload and shared feedback copy `ui/app/workspace/logs/sheets/logDetailView.tsx`, `ui/components/prompts/context.tsx`, `ui/components/ui/multibudgets.tsx`	Reformats large-payload warnings and updates shared error and validation messages.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Suggested reviewers: impoiler, pratham-mishra04

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 13.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title is concise and accurately summarizes the PR's main UI copy cleanup.
Description check	✅ Passed	The description follows the template closely and includes the key sections; only the checklist is left unfilled, which is non-critical.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch 07-23-chore_ui_descriptions_cleanup

_{Comment @coderabbitai help to get the list of available commands.}

CLAassistant · 2026-07-23T11:02:01Z

All committers have signed the CLA.

roroghost17 · 2026-07-23T11:02:08Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ui/app/workspace/routing-rules/views/routingRuleSheet.tsx`:
- Line 366: Update the user-facing text near the rule-composition description to
add a comma after “e.g.”, so it reads “e.g., normalize a model alias first”
while preserving the rest of the wording.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d0275e66-e468-4b80-8f4e-491e98c22ec9

📥 Commits

Reviewing files that changed from the base of the PR and between c019b24 and 03a0b73.

📒 Files selected for processing (20)

ui/app/pprof/page.tsx
ui/app/workspace/config/views/loggingView.tsx
ui/app/workspace/config/views/mcpView.tsx
ui/app/workspace/governance/views/teamSheet.tsx
ui/app/workspace/logs/sheets/logDetailView.tsx
ui/app/workspace/mcp-registry/library/views/mcpLibraryAddServerSheet.tsx
ui/app/workspace/mcp-registry/views/oauth2Authorizer.tsx
ui/app/workspace/mcp-sessions/views/sessionsTable.tsx
ui/app/workspace/model-catalog/views/attributeSheet.tsx
ui/app/workspace/observability/fragments/maximFormFragment.tsx
ui/app/workspace/observability/fragments/otelFormFragment.tsx
ui/app/workspace/providers/fragments/betaHeadersFormFragment.tsx
ui/app/workspace/providers/fragments/deploymentsTable.tsx
ui/app/workspace/providers/views/modelProviderKeysTableView.tsx
ui/app/workspace/routing-rules/tree/views/node/rfRuleNode.tsx
ui/app/workspace/routing-rules/tree/views/routingTreeView.tsx
ui/app/workspace/routing-rules/views/routingRuleSheet.tsx
ui/app/workspace/virtual-keys/views/virtualKeySheet.tsx
ui/components/prompts/context.tsx
ui/components/ui/multibudgets.tsx

akshaydeo · 2026-07-23T16:00:14Z

Merge activity

Jul 23, 4:00 PM UTC: A user started a stack merge that includes this pull request via Graphite.
Jul 23, 4:01 PM UTC: Graphite couldn't merge this pull request because a downstack PR fix: fixes error forwarding to connectors #5491 failed to merge.
Jul 23, 4:02 PM UTC: A user started a stack merge that includes this pull request via Graphite.
Jul 23, 4:05 PM UTC: @akshaydeo merged this pull request with Graphite.

The base branch was changed.

## Summary Replaces em-dash (`—`) separators used as clause connectors in UI copy with grammatically appropriate alternatives: semicolons, colons, commas, or periods. This improves readability and consistency across tooltips, descriptions, labels, alerts, and inline help text throughout the UI. ## Changes - Replaced em-dashes used to join independent clauses with semicolons (e.g. "token is not revoked at the provider — it stays detached" → "...provider; it stays detached") - Replaced em-dashes used to introduce elaborations or examples with colons or commas (e.g. "Large payload request — input content..." → "Large payload request: input content...") - Replaced em-dashes used in parenthetical asides with parentheses or commas where appropriate - Changed one em-dash team name separator in a combobox label to a standard hyphen (`-`) since it appears in a data label context rather than prose ## Type of change - [ ] Bug fix - [ ] Feature - [ ] Refactor - [ ] Documentation - [x] Chore/CI ## Affected areas - [ ] Core (Go) - [ ] Transports (HTTP) - [ ] Providers/Integrations - [ ] Plugins - [x] UI (React) - [ ] Docs ## How to test ```sh cd ui pnpm i || npm i pnpm build || npm run build ``` Visually inspect affected UI surfaces (logging config, MCP config, routing rules, virtual keys, provider keys, pprof page, log detail view, sessions table, observability fragments) to confirm copy reads correctly with no regressions. ## Screenshots/Recordings No visual layout changes expected; only text content is affected. ## Breaking changes - [ ] Yes - [x] No ## Related issues ## Security considerations None. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable

roroghost17 added 4 commits July 23, 2026 14:58

fix: fixes whitespace trimming on connectors form fields

d16b3ef

fix: fixes error forwarding to connectors

e36ff50

chore: update OTEL test harness with error scenarios

c019b24

chore: ui descriptions cleanup

03a0b73

This was referenced Jul 23, 2026

fix: fixes whitespace trimming on connectors form fields #5484

Merged

fix: fixes error forwarding to connectors #5491

Merged

roroghost17 mentioned this pull request Jul 23, 2026

chore: update OTEL test harness with error scenarios #5492

Merged

18 tasks

roroghost17 marked this pull request as ready for review July 23, 2026 11:02

coderabbitai Bot requested review from Pratham-Mishra04 and impoiler July 23, 2026 11:03

coderabbitai Bot requested changes Jul 23, 2026

View reviewed changes

Comment thread ui/app/workspace/routing-rules/views/routingRuleSheet.tsx

coderabbitai Bot previously approved these changes Jul 23, 2026

View reviewed changes

akshaydeo previously approved these changes Jul 23, 2026

View reviewed changes

akshaydeo changed the base branch from 07-23-chore_update_otel_test_harness_with_error_scenarios to graphite-base/5493 July 23, 2026 16:04

akshaydeo changed the base branch from graphite-base/5493 to dev July 23, 2026 16:04

akshaydeo merged commit 3801edc into dev Jul 23, 2026
9 of 10 checks passed

akshaydeo deleted the 07-23-chore_ui_descriptions_cleanup branch July 23, 2026 16:05

coderabbitai Bot mentioned this pull request Jul 24, 2026

override ux fixes #5523

Merged

18 tasks

Navigation Menu

chore: ui descriptions cleanup - #5493

chore: ui descriptions cleanup#5493
akshaydeo merged 4 commits into
devfrom
07-23-chore_ui_descriptions_cleanup

roroghost17 commented Jul 23, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Jul 23, 2026 •

edited

Loading

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

CLAassistant commented Jul 23, 2026 •

edited

Loading

Uh oh!

roroghost17 commented Jul 23, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

akshaydeo commented Jul 23, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

roroghost17 commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Type of change

Affected areas

How to test

Screenshots/Recordings

Breaking changes

Related issues

Security considerations

Checklist

Uh oh!

coderabbitai Bot commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

❌ Failed checks (1 warning)

Uh oh!

CLAassistant commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

roroghost17 commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

akshaydeo commented Jul 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

roroghost17 commented Jul 23, 2026 •

edited

Loading

coderabbitai Bot commented Jul 23, 2026 •

edited

Loading

CLAassistant commented Jul 23, 2026 •

edited

Loading

roroghost17 commented Jul 23, 2026 •

edited

Loading

akshaydeo commented Jul 23, 2026 •

edited

Loading