chore: test fixes - #5152
chore: test fixes#5152
Conversation
|
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe configuration schema synchronization tests now classify ChangesEnterprise alerting schema validation
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies" 🔧 ast-grep (0.44.1)transports/bifrost-http/lib/config_test.goast-grep timed out on this file Comment |
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "chore: test fixes" | Re-trigger Greptile |
Merge activity
|
ccee45b to
c0f5bc8
Compare
## Summary Adds `alerting` to the list of enterprise schema fields recognized in the HTTP transport config schema tests, ensuring it is correctly classified as an enterprise-level configuration path. ## Changes - Added `alerting` to the `enterpriseSchemaPaths` map and the `enterpriseSchemaFields` map in the config schema sync test, so that the `alerting` top-level field is properly validated as an enterprise schema field. ## Type of change - [ ] Bug fix - [x] Feature - [ ] Refactor - [ ] Documentation - [ ] Chore/CI ## Affected areas - [ ] Core (Go) - [x] Transports (HTTP) - [ ] Providers/Integrations - [ ] Plugins - [ ] UI (React) - [ ] Docs ## How to test ```sh go test ./transports/bifrost-http/lib/... ``` The `TestConfigSchemaSyncTopLevel` test should pass with `alerting` recognized as an enterprise schema field. ## Screenshots/Recordings N/A ## Breaking changes - [ ] Yes - [x] No ## Related issues N/A ## Security considerations No security implications. This change only affects schema classification in tests. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [x] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable
## Summary Adds `alerting` to the list of enterprise schema fields recognized in the HTTP transport config schema tests, ensuring it is correctly classified as an enterprise-level configuration path. ## Changes - Added `alerting` to the `enterpriseSchemaPaths` map and the `enterpriseSchemaFields` map in the config schema sync test, so that the `alerting` top-level field is properly validated as an enterprise schema field. ## Type of change - [ ] Bug fix - [x] Feature - [ ] Refactor - [ ] Documentation - [ ] Chore/CI ## Affected areas - [ ] Core (Go) - [x] Transports (HTTP) - [ ] Providers/Integrations - [ ] Plugins - [ ] UI (React) - [ ] Docs ## How to test ```sh go test ./transports/bifrost-http/lib/... ``` The `TestConfigSchemaSyncTopLevel` test should pass with `alerting` recognized as an enterprise schema field. ## Screenshots/Recordings N/A ## Breaking changes - [ ] Yes - [x] No ## Related issues N/A ## Security considerations No security implications. This change only affects schema classification in tests. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [x] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable
## Summary Adds `alerting` to the list of enterprise schema fields recognized in the HTTP transport config schema tests, ensuring it is correctly classified as an enterprise-level configuration path. ## Changes - Added `alerting` to the `enterpriseSchemaPaths` map and the `enterpriseSchemaFields` map in the config schema sync test, so that the `alerting` top-level field is properly validated as an enterprise schema field. ## Type of change - [ ] Bug fix - [x] Feature - [ ] Refactor - [ ] Documentation - [ ] Chore/CI ## Affected areas - [ ] Core (Go) - [x] Transports (HTTP) - [ ] Providers/Integrations - [ ] Plugins - [ ] UI (React) - [ ] Docs ## How to test ```sh go test ./transports/bifrost-http/lib/... ``` The `TestConfigSchemaSyncTopLevel` test should pass with `alerting` recognized as an enterprise schema field. ## Screenshots/Recordings N/A ## Breaking changes - [ ] Yes - [x] No ## Related issues N/A ## Security considerations No security implications. This change only affects schema classification in tests. ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [x] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable

Summary
Adds
alertingto the list of enterprise schema fields recognized in the HTTP transport config schema tests, ensuring it is correctly classified as an enterprise-level configuration path.Changes
alertingto theenterpriseSchemaPathsmap and theenterpriseSchemaFieldsmap in the config schema sync test, so that thealertingtop-level field is properly validated as an enterprise schema field.Type of change
Affected areas
How to test
go test ./transports/bifrost-http/lib/...The
TestConfigSchemaSyncTopLeveltest should pass withalertingrecognized as an enterprise schema field.Screenshots/Recordings
N/A
Breaking changes
Related issues
N/A
Security considerations
No security implications. This change only affects schema classification in tests.
Checklist
docs/contributing/README.mdand followed the guidelines