Skip to content

chore: test fixes - #5152

Merged
Pratham-Mishra04 merged 1 commit into
devfrom
07-13-chore_test_fixes
Jul 13, 2026
Merged

Pratham-Mishra04 merged 1 commit into
devfrom
07-13-chore_test_fixes

Conversation

@TejasGhatte

@TejasGhatte TejasGhatte commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

Adds alerting to the list of enterprise schema fields recognized in the HTTP transport config schema tests, ensuring it is correctly classified as an enterprise-level configuration path.

Changes

  • Added alerting to the enterpriseSchemaPaths map and the enterpriseSchemaFields map in the config schema sync test, so that the alerting top-level field is properly validated as an enterprise schema field.

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore/CI

Affected areas

  • Core (Go)
  • Transports (HTTP)
  • Providers/Integrations
  • Plugins
  • UI (React)
  • Docs

How to test

go test ./transports/bifrost-http/lib/...

The TestConfigSchemaSyncTopLevel test should pass with alerting recognized as an enterprise schema field.

Screenshots/Recordings

N/A

Breaking changes

  • Yes
  • No

Related issues

N/A

Security considerations

No security implications. This change only affects schema classification in tests.

Checklist

  • I read docs/contributing/README.md and followed the guidelines
  • I added/updated tests where appropriate
  • I updated documentation where needed
  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

@CLAassistant

CLAassistant commented Jul 13, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5328d2a1-43c9-4832-a802-762fa11368a2

📥 Commits

Reviewing files that changed from the base of the PR and between 056ee59 and c0f5bc8.

📒 Files selected for processing (1)
  • transports/bifrost-http/lib/config_test.go

📝 Walkthrough

Summary by CodeRabbit

  • Tests
    • Updated configuration schema validation checks to recognize the enterprise-only alerting field.
    • No user-facing runtime behavior changed.

Walkthrough

The configuration schema synchronization tests now classify alerting as an enterprise-only field in both deep and top-level validation allowlists. No production logic changed.

Changes

Enterprise alerting schema validation

Layer / File(s) Summary
Extend enterprise schema allowlists
transports/bifrost-http/lib/config_test.go
Adds alerting to the deep schema-path and top-level schema-field enterprise allowlists.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • maximhq/bifrost#5078: Adds the alerting schema referenced by these synchronization test allowlists.

Suggested reviewers: danpiths, roroghost17

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 07-13-chore_test_fixes

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.12.2)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"

🔧 ast-grep (0.44.1)
transports/bifrost-http/lib/config_test.go

ast-grep timed out on this file


Comment @coderabbitai help to get the list of available commands.

@TejasGhatte
TejasGhatte marked this pull request as ready for review July 13, 2026 12:41

TejasGhatte commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@coderabbitai
coderabbitai Bot requested review from danpiths and roroghost17 July 13, 2026 12:43
@greptile-apps

greptile-apps Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.

Important Files Changed

Filename Overview
transports/bifrost-http/lib/config_test.go Updates the config schema sync test allowlists so alerting is treated like the other enterprise-only top-level schema fields.

Reviews (2): Last reviewed commit: "chore: test fixes" | Re-trigger Greptile

@TejasGhatte TejasGhatte mentioned this pull request Jul 13, 2026
17 tasks

Pratham-Mishra04 commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Merge activity

  • Jul 13, 2:17 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 13, 2:18 PM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 13, 2:19 PM UTC: @Pratham-Mishra04 merged this pull request with Graphite.

@Pratham-Mishra04
Pratham-Mishra04 force-pushed the 07-13-chore_test_fixes branch from ccee45b to c0f5bc8 Compare July 13, 2026 14:18
@Pratham-Mishra04
Pratham-Mishra04 merged commit 77d390e into dev Jul 13, 2026
13 of 15 checks passed
@Pratham-Mishra04
Pratham-Mishra04 deleted the 07-13-chore_test_fixes branch July 13, 2026 14:19
akshaydeo pushed a commit that referenced this pull request Jul 14, 2026
## Summary

Adds `alerting` to the list of enterprise schema fields recognized in the HTTP transport config schema tests, ensuring it is correctly classified as an enterprise-level configuration path.

## Changes

- Added `alerting` to the `enterpriseSchemaPaths` map and the `enterpriseSchemaFields` map in the config schema sync test, so that the `alerting` top-level field is properly validated as an enterprise schema field.

## Type of change

- [ ] Bug fix
- [x] Feature
- [ ] Refactor
- [ ] Documentation
- [ ] Chore/CI

## Affected areas

- [ ] Core (Go)
- [x] Transports (HTTP)
- [ ] Providers/Integrations
- [ ] Plugins
- [ ] UI (React)
- [ ] Docs

## How to test

```sh
go test ./transports/bifrost-http/lib/...
```

The `TestConfigSchemaSyncTopLevel` test should pass with `alerting` recognized as an enterprise schema field.

## Screenshots/Recordings

N/A

## Breaking changes

- [ ] Yes
- [x] No

## Related issues

N/A

## Security considerations

No security implications. This change only affects schema classification in tests.

## Checklist

- [ ] I read `docs/contributing/README.md` and followed the guidelines
- [x] I added/updated tests where appropriate
- [ ] I updated documentation where needed
- [ ] I verified builds succeed (Go and UI)
- [ ] I verified the CI pipeline passes locally if applicable
akhsaul pushed a commit to akhsaul/bifrost that referenced this pull request Aug 27, 2026
## Summary

Adds `alerting` to the list of enterprise schema fields recognized in the HTTP transport config schema tests, ensuring it is correctly classified as an enterprise-level configuration path.

## Changes

- Added `alerting` to the `enterpriseSchemaPaths` map and the `enterpriseSchemaFields` map in the config schema sync test, so that the `alerting` top-level field is properly validated as an enterprise schema field.

## Type of change

- [ ] Bug fix
- [x] Feature
- [ ] Refactor
- [ ] Documentation
- [ ] Chore/CI

## Affected areas

- [ ] Core (Go)
- [x] Transports (HTTP)
- [ ] Providers/Integrations
- [ ] Plugins
- [ ] UI (React)
- [ ] Docs

## How to test

```sh
go test ./transports/bifrost-http/lib/...
```

The `TestConfigSchemaSyncTopLevel` test should pass with `alerting` recognized as an enterprise schema field.

## Screenshots/Recordings

N/A

## Breaking changes

- [ ] Yes
- [x] No

## Related issues

N/A

## Security considerations

No security implications. This change only affects schema classification in tests.

## Checklist

- [ ] I read `docs/contributing/README.md` and followed the guidelines
- [x] I added/updated tests where appropriate
- [ ] I updated documentation where needed
- [ ] I verified builds succeed (Go and UI)
- [ ] I verified the CI pipeline passes locally if applicable
occcat pushed a commit to occcat/bifrost that referenced this pull request Sep 2, 2026
## Summary

Adds `alerting` to the list of enterprise schema fields recognized in the HTTP transport config schema tests, ensuring it is correctly classified as an enterprise-level configuration path.

## Changes

- Added `alerting` to the `enterpriseSchemaPaths` map and the `enterpriseSchemaFields` map in the config schema sync test, so that the `alerting` top-level field is properly validated as an enterprise schema field.

## Type of change

- [ ] Bug fix
- [x] Feature
- [ ] Refactor
- [ ] Documentation
- [ ] Chore/CI

## Affected areas

- [ ] Core (Go)
- [x] Transports (HTTP)
- [ ] Providers/Integrations
- [ ] Plugins
- [ ] UI (React)
- [ ] Docs

## How to test

```sh
go test ./transports/bifrost-http/lib/...
```

The `TestConfigSchemaSyncTopLevel` test should pass with `alerting` recognized as an enterprise schema field.

## Screenshots/Recordings

N/A

## Breaking changes

- [ ] Yes
- [x] No

## Related issues

N/A

## Security considerations

No security implications. This change only affects schema classification in tests.

## Checklist

- [ ] I read `docs/contributing/README.md` and followed the guidelines
- [x] I added/updated tests where appropriate
- [ ] I updated documentation where needed
- [ ] I verified builds succeed (Go and UI)
- [ ] I verified the CI pipeline passes locally if applicable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants