adds alerting schema to config.schema.json by SahilChoudhary22 · Pull Request #5078 · maximhq/bifrost

SahilChoudhary22 · 2026-07-09T21:25:48Z

Summary

Briefly explain the purpose of this PR and the problem it solves.

Changes

What was changed and why
Any notable design decisions or trade-offs

Type of change

Affected areas

How to test

Describe the steps to validate this change. Include commands and expected outcomes.

# Core/Transports
go version
go test ./...

# UI
cd ui
pnpm i || npm i
pnpm test || npm test
pnpm build || npm run build

If adding new configs or environment variables, document them here.

Screenshots/Recordings

If UI changes, add before/after screenshots or short clips.

Breaking changes

Yes
No

If yes, describe impact and migration instructions.

Related issues

Link related issues and discussions. Example: Closes #123

Security considerations

Note any security implications (auth, secrets, PII, sandboxing, etc.).

Checklist

I read docs/contributing/README.md and followed the guidelines
I added/updated tests where appropriate
I updated documentation where needed
I verified builds succeed (Go and UI)
I verified the CI pipeline passes locally if applicable

coderabbitai · 2026-07-09T21:25:55Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: bb5b1533-92bb-42c8-b23d-37847831cd7e

📥 Commits

Reviewing files that changed from the base of the PR and between 0cc5c1c and 3840063.

📒 Files selected for processing (1)

transports/config.schema.json

🚧 Files skipped from review as they are similar to previous changes (1)

transports/config.schema.json

📝 Walkthrough

Summary by CodeRabbit

New Features
- Added a new alerting configuration section with support for alert history retention, outbound webhook network controls, configurable channels, and rule-based alerting.
- Expanded channel setup options with validation for different channel types and required connection details.
- Added rule definitions with scope settings, optional query filters, cooldown/notification controls, and targeted evaluation options.

Walkthrough

The transport configuration schema adds an alerting object with retention and webhook network controls, channel definitions with type-specific validation, and CEL-based rules with channel targeting and optional target coupling.

Changes

Alerting schema

Layer / File(s)	Summary
Alerting controls and channels `transports/config.schema.json`	Adds alert history retention, webhook network validation options, and conditional configuration validation for Slack, Microsoft Teams, PagerDuty, and generic webhook channels.
Alerting rule definitions `transports/config.schema.json`	Adds rules requiring scope and CEL expressions, with optional queries, cooldowns, single-notify behavior, channel targeting, and coupled target fields.

Estimated code review effort: 2 (Simple) | ~15 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 3

❌ Failed checks (2 warnings, 1 inconclusive)

Check name	Status	Explanation	Resolution
Linked Issues check	⚠️ Warning	[123] The PR adds alerting schema config, but the linked issue requires Files API support via POST /v1/files.	Implement the files upload endpoint for providers, or relink this PR to the correct alerting issue.
Out of Scope Changes check	⚠️ Warning	The only code change is an alerting schema addition, which is unrelated to the linked Files API requirement.	Remove the unrelated alerting schema changes or update the PR scope and linked issue to match the actual work.
Description check	❓ Inconclusive	The description is just the untouched template and lacks a real summary, changes, testing, issues, and other required details.	Replace the template with a filled-in PR description covering summary, changes, testing, related issues, security, and breaking changes.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: adding an alerting schema to config.schema.json.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch 07-10-adds_alerting_schema_to_config.schema.json

_{Comment @coderabbitai help to get the list of available commands.}

SahilChoudhary22 · 2026-07-09T21:26:01Z

This stack of pull requests is managed by Graphite. Learn more about stacking.

greptile-apps · 2026-07-09T21:28:16Z

Confidence Score: 5/5

This looks safe to merge.

No blocking issues found in the changed code.

Important Files Changed

Filename	Overview
transports/config.schema.json	Adds the alerting schema for retention, webhook networking, channels, and rules.

_{Reviews (3): Last reviewed commit: "adds alerting schema to config.schema.js..." | Re-trigger Greptile}

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@transports/config.schema.json`:
- Around line 1027-1034: The alert webhook fields in the schema are still
defined as plain strings, so invalid values can slip through validation. Update
the `webhook_url` and `url` definitions in `transports/config.schema.json` to
enforce URI-style validation using the schema’s existing string constraints or
equivalent pattern/rule guardrails, keeping `url` aligned as an alias of
`webhook_url`.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f73f538f-28bd-49ac-a2ac-79761f880a6d

📥 Commits

Reviewing files that changed from the base of the PR and between 3fbd9a4 and d8b2335.

📒 Files selected for processing (1)

transports/config.schema.json

akshaydeo · 2026-07-10T12:04:18Z

Merge activity

Jul 10, 12:04 PM UTC: A user started a stack merge that includes this pull request via Graphite.
Jul 10, 12:04 PM UTC: @akshaydeo merged this pull request with Graphite.

## Summary Briefly explain the purpose of this PR and the problem it solves. ## Changes - What was changed and why - Any notable design decisions or trade-offs ## Type of change - [ ] Bug fix - [ ] Feature - [ ] Refactor - [ ] Documentation - [ ] Chore/CI ## Affected areas - [ ] Core (Go) - [ ] Transports (HTTP) - [ ] Providers/Integrations - [ ] Plugins - [ ] UI (React) - [ ] Docs ## How to test Describe the steps to validate this change. Include commands and expected outcomes. ```sh # Core/Transports go version go test ./... # UI cd ui pnpm i || npm i pnpm test || npm test pnpm build || npm run build ``` If adding new configs or environment variables, document them here. ## Screenshots/Recordings If UI changes, add before/after screenshots or short clips. ## Breaking changes - [ ] Yes - [ ] No If yes, describe impact and migration instructions. ## Related issues Link related issues and discussions. Example: Closes #123 ## Security considerations Note any security implications (auth, secrets, PII, sandboxing, etc.). ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable

## Summary Briefly explain the purpose of this PR and the problem it solves. ## Changes - What was changed and why - Any notable design decisions or trade-offs ## Type of change - [ ] Bug fix - [ ] Feature - [ ] Refactor - [ ] Documentation - [ ] Chore/CI ## Affected areas - [ ] Core (Go) - [ ] Transports (HTTP) - [ ] Providers/Integrations - [ ] Plugins - [ ] UI (React) - [ ] Docs ## How to test Describe the steps to validate this change. Include commands and expected outcomes. ```sh # Core/Transports go version go test ./... # UI cd ui pnpm i || npm i pnpm test || npm test pnpm build || npm run build ``` If adding new configs or environment variables, document them here. ## Screenshots/Recordings If UI changes, add before/after screenshots or short clips. ## Breaking changes - [ ] Yes - [ ] No If yes, describe impact and migration instructions. ## Related issues Link related issues and discussions. Example: Closes maximhq#123 ## Security considerations Note any security implications (auth, secrets, PII, sandboxing, etc.). ## Checklist - [ ] I read `docs/contributing/README.md` and followed the guidelines - [ ] I added/updated tests where appropriate - [ ] I updated documentation where needed - [ ] I verified builds succeed (Go and UI) - [ ] I verified the CI pipeline passes locally if applicable

SahilChoudhary22 marked this pull request as ready for review July 9, 2026 21:25

greptile-apps Bot reviewed Jul 9, 2026

View reviewed changes

Comment thread transports/config.schema.json

Comment thread transports/config.schema.json

Comment thread transports/config.schema.json

coderabbitai Bot requested changes Jul 9, 2026

View reviewed changes

Comment thread transports/config.schema.json

coderabbitai Bot previously approved these changes Jul 9, 2026

View reviewed changes

SahilChoudhary22 dismissed coderabbitai[bot]’s stale review via 0cc5c1c July 9, 2026 21:42

SahilChoudhary22 force-pushed the 07-10-adds_alerting_schema_to_config.schema.json branch from d8b2335 to 0cc5c1c Compare July 9, 2026 21:42

coderabbitai Bot approved these changes Jul 9, 2026

View reviewed changes

adds alerting schema to config.schema.json

3840063

greptile-apps Bot reviewed Jul 9, 2026

View reviewed changes

Comment thread transports/config.schema.json

BearTS force-pushed the 07-10-adds_alerting_schema_to_config.schema.json branch from 0cc5c1c to 3840063 Compare July 9, 2026 21:45

akshaydeo merged commit e4bf522 into dev Jul 10, 2026
18 checks passed

akshaydeo deleted the 07-10-adds_alerting_schema_to_config.schema.json branch July 10, 2026 12:04

coderabbitai Bot mentioned this pull request Jul 13, 2026

chore: test fixes #5152

Merged

18 tasks

Navigation Menu

adds alerting schema to config.schema.json - #5078

adds alerting schema to config.schema.json#5078
akshaydeo merged 1 commit into
devfrom
07-10-adds_alerting_schema_to_config.schema.json

SahilChoudhary22 commented Jul 9, 2026

Uh oh!

coderabbitai Bot commented Jul 9, 2026 •

edited

Loading

Summary by CodeRabbit

Walkthrough

Changes

❌ Failed checks (2 warnings, 1 inconclusive)

Uh oh!

SahilChoudhary22 commented Jul 9, 2026 •

edited by BearTS

Loading

Uh oh!

greptile-apps Bot commented Jul 9, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Uh oh!

Uh oh!

Uh oh!

akshaydeo commented Jul 10, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

SahilChoudhary22 commented Jul 9, 2026

Summary

Changes

Type of change

Affected areas

How to test

Screenshots/Recordings

Breaking changes

Related issues

Security considerations

Checklist

Uh oh!

coderabbitai Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Walkthrough

Changes

❌ Failed checks (2 warnings, 1 inconclusive)

Uh oh!

SahilChoudhary22 commented Jul 9, 2026 • edited by BearTS Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-apps Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Important Files Changed

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

akshaydeo commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Jul 9, 2026 •

edited

Loading

SahilChoudhary22 commented Jul 9, 2026 •

edited by BearTS

Loading

greptile-apps Bot commented Jul 9, 2026 •

edited

Loading

akshaydeo commented Jul 10, 2026 •

edited

Loading