chore: replace manual helm registry login steps with step-security/docker-login-action

[BearTS]

Summary

Replaces manual helm registry login shell commands with the step-security/docker-login-action for authenticating to both GitHub Container Registry (GHCR) and Docker Hub during Helm chart releases.

Changes

• Replaced inline helm registry login shell commands for GHCR and Docker Hub with step-security/docker-login-action@870af644803bf9f204aed474adbad2958fec048b (v4.1.0)
• Removed continue-on-error: true from both login steps, meaning login failures will now correctly fail the workflow rather than silently continuing
• Credentials are now passed directly via the action's with inputs rather than environment variables

Type of change

• Bug fix
• Feature
• Refactor
• Documentation
• Chore/CI

Affected areas

• Core (Go)
• Transports (HTTP)
• Providers/Integrations
• Plugins
• UI (React)
• Docs

How to test

Trigger a Helm release workflow and verify that both GHCR and Docker Hub login steps complete successfully and the chart is pushed as an OCI artifact.

Breaking changes

• Yes
• No

Security considerations

Using the pinned step-security/docker-login-action action (pinned to a full commit SHA) is a supply chain security improvement over manually invoking helm registry login in shell. Removing continue-on-error: true ensures that credential failures are surfaced immediately rather than allowing the workflow to proceed with potentially unauthenticated pushes.

Checklist

• I read docs/contributing/README.md and followed the guidelines
• I added/updated tests where appropriate
• I updated documentation where needed
• I verified builds succeed (Go and UI)
• I verified the CI pipeline passes locally if applicable

[coderabbitai]

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes
  • Improved authentication reliability when publishing Helm charts to GitHub Container Registry and Docker Hub.
  • Updated the Docker Hub publishing destination for Helm charts.

Walkthrough

The Helm release workflow replaces shell-based GHCR and Docker Hub authentication with conditional Docker login actions, and changes the Docker Hub OCI destination for the packaged Helm chart.

Changes

Helm release registry flow

Layer / File(s)	Summary
Replace Helm registry logins .github/workflows/helm-release.yml	GHCR and Docker Hub authentication now use dedicated Docker login actions with repository secrets when the release does not already exist.
Update Docker Hub chart destination .github/workflows/helm-release.yml	The Helm chart OCI publish target changes from the helm-charts repository path to the maximhq namespace root.

Estimated code review effort: 1 (Trivial) | ~5 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: replacing manual Helm registry login with docker-login-action.
Description check	✅ Passed	The description covers the required sections with clear summary, changes, testing, breaking changes, security, and checklist details.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 07-13-fix_auth_on_docker_and_github_for_helm_chart

---

_{Comment @coderabbitai help to get the list of available commands.}

[BearTS]

• chore: replace manual helm registry login steps with step-security/docker-login-action #5132 👈 (View in Graphite)
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

[greptile-apps]

Confidence Score: 5/5

This looks safe to merge.

• No blocking issues found in the changed workflow code.

Important Files Changed

Filename	Overview
.github/workflows/helm-release.yml	The workflow now uses a pinned Docker login action for registry authentication before Helm chart publishing.

_{Reviews (2): Last reviewed commit: "fix: auth on docker and github for helm ..." | Re-trigger Greptile}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/helm-release.yml:
- Around line 141-153: Remove continue-on-error: true from the Docker Hub login
step and both subsequent helm push steps in the release workflow, while
preserving their existing conditions and actions so authentication or
publication failures fail the workflow.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 58b893e8-cb51-4bc9-b89e-bd1041e0c875

📥 Commits

Reviewing files that changed from the base of the PR and between b2218f7 and c0d8545.

📒 Files selected for processing (1)

• .github/workflows/helm-release.yml

[Pratham-Mishra04]

Merge activity

• Jul 13, 9:03 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• Jul 13, 9:03 AM UTC: @Pratham-Mishra04 merged this pull request with Graphite.