Skip to content

minor patches - #5126

Merged
akshaydeo merged 2 commits into
devfrom
07-12-dds_new_harness_skill_and_updates_based_on_merged_prs
Jul 13, 2026
Merged

minor patches#5126
akshaydeo merged 2 commits into
devfrom
07-12-dds_new_harness_skill_and_updates_based_on_merged_prs

Conversation

@akshaydeo

@akshaydeo akshaydeo commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@akshaydeo
akshaydeo requested a review from a team as a code owner July 13, 2026 01:03
@CLAassistant

CLAassistant commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@coderabbitai

coderabbitai Bot commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The head commit changed during the review from 77adcf3 to 90a97fc.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 07-12-dds_new_harness_skill_and_updates_based_on_merged_prs

Comment @coderabbitai help to get the list of available commands.

@coderabbitai
coderabbitai Bot requested review from danpiths and roroghost17 July 13, 2026 01:04
@greptile-apps

greptile-apps Bot commented Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

The changed flow looks mergeable after tightening the new harness coverage and skill command.

  • The issues are limited to test coverage reliability and skill instructions.
  • Production request handling is not changed.
  • Some new harness cases can report success without exercising the intended path.

tests/e2e/api/collections/provider-harness.json, .claude/skills/harness-test-writer/SKILL.md

Important Files Changed

Filename Overview
.claude/skills/harness-test-writer/SKILL.md Adds a detailed workflow for creating provider harness regression cases, but the final harness command is documented from the wrong working directory.
README.md Adds a Trendshift badge near the existing project badges.
tests/e2e/api/collections/provider-harness.json Adds three provider harness regression folders, with a few cases that can skip or miss the exact intended assertion path under common runner states.

Comments Outside Diff (1)

  1. tests/e2e/api/collections/provider-harness.json, line 37639-37642 (link)

    P2 Persistence Check Depends On Runner

    This case only asserts usage on the SSE wire response; the database persistence check is described in comments and depends on an external reporter honoring x-bf-expect-cost. If the collection is run without that reporter, the original logs-persistence regression can pass even when the DB still records zero tokens.

Reviews (1): Last reviewed commit: "dds new harness skill and updates based ..." | Re-trigger Greptile

greptile-apps[bot]
greptile-apps Bot reviewed Jul 13, 2026
View reviewed changes
Comment thread tests/e2e/api/collections/provider-harness.json
Comment thread .claude/skills/harness-test-writer/SKILL.md
Comment thread tests/e2e/api/collections/provider-harness.json
@akshaydeo
Merge branch 'dev' into 07-12-dds_new_harness_skill_and_updates_based…
90a97fc 
…_on_merged_prs

Signed-off-by: Akshay Deo <akshay@akshaydeo.com>
@akshaydeo
akshaydeo merged commit f4f7716 into dev Jul 13, 2026
9 of 12 checks passed
@akshaydeo
akshaydeo deleted the 07-12-dds_new_harness_skill_and_updates_based_on_merged_prs branch July 13, 2026 01:06
tcx4c70 added a commit to tcx4c70/bifrost that referenced this pull request Jul 13, 2026
@tcx4c70
Merge remote-tracking branch 'origin/dev' into fix/namespace-tools
73bad38 
* origin/dev: (79 commits)
  chore: add `helm-update` Claude skill for syncing Helm chart with `config.schema.json` (maximhq#5144)
  fix: web search options to google search mapping in gemini api (maximhq#5139)
  feat: add `postgresql.external.port` string support and `bifrost.mcp.toolGroups[*].id` to Helm chart (maximhq#5143)
  fix: parse `SecretVar` JSON with `ref`/`env_var` fields even when `value` is absent (maximhq#5146)
  Revert "fix: less strict unmarshalling for secret var (maximhq#4723)" (maximhq#5145)
  fix: max reasoning effort in openai (maximhq#5130)
  chore: replace manual `helm registry login` steps with `step-security/docker-login-action` (maximhq#5132)
  fix: support GA transcription-type sessions in POST /v1/realtime/client_secrets (maximhq#5092)
  community: add Xquik to MCP library (maximhq#5069)
  fix: warn callers not to truncate the #t= temp-token fragment on MCP inline-auth links (maximhq#5104)
  chore: build fix in core (maximhq#5129)
  fix: never persist masked provider key previews (maximhq#5106)
  Filter out provider-level keys from selector in prompt manager (maximhq#5018)
  fix: show user popover when `userInfo` exists and include `preferred_username` as display name fallback (maximhq#5098)
  fix: use `AutoMigrate` and add `runner_id`/`created_by_user_id` columns to sidekiq table migration (maximhq#5085)
  dds new harness skill and updates based on merged PRs (maximhq#5126)
  dds new harness skill and updates based on merged PRs (maximhq#5123)
  Add Trendshift badge to README (maximhq#5124)
  fix: make tracing span lookup nil-safe to prevent panic on streaming errors (maximhq#4896)
  Revert "fix: synthesize per-query rerank usage for Bedrock and Vertex (maximhq#4322)" (maximhq#5122)
  ...
akshaydeo added a commit that referenced this pull request Jul 14, 2026
@akshaydeo
dds new harness skill and updates based on merged PRs (#5126)
9b02782 
Signed-off-by: Akshay Deo <akshay@akshaydeo.com>
akshaydeo added a commit that referenced this pull request Jul 14, 2026
@akshaydeo
dds new harness skill and updates based on merged PRs (#5126)
9284cb6 
Signed-off-by: Akshay Deo <akshay@akshaydeo.com>
Shaik-Sirajuddin pushed a commit to Shaik-Sirajuddin/bifrost that referenced this pull request Jul 15, 2026
@akshaydeo @Shaik-Sirajuddin
dds new harness skill and updates based on merged PRs (maximhq#5126)
c49cf65 
Signed-off-by: Akshay Deo <akshay@akshaydeo.com>
Shaik-Sirajuddin pushed a commit to Shaik-Sirajuddin/bifrost that referenced this pull request Jul 15, 2026
@akshaydeo @Shaik-Sirajuddin
dds new harness skill and updates based on merged PRs (maximhq#5126)
f9063fa 
Signed-off-by: Akshay Deo <akshay@akshaydeo.com>
akshaydeo added a commit that referenced this pull request Jul 24, 2026
@akshaydeo
dds new harness skill and updates based on merged PRs (#5126)
a5cc71b 
Signed-off-by: Akshay Deo <akshay@akshaydeo.com>
akshaydeo added a commit that referenced this pull request Jul 29, 2026
@akshaydeo
dds new harness skill and updates based on merged PRs (#5126)
3311977 
Signed-off-by: Akshay Deo <akshay@akshaydeo.com>
akshaydeo added a commit that referenced this pull request Jul 30, 2026
@akshaydeo
dds new harness skill and updates based on merged PRs (#5126)
3baee63 
Signed-off-by: Akshay Deo <akshay@akshaydeo.com>
akshaydeo added a commit that referenced this pull request Jul 30, 2026
@akshaydeo
dds new harness skill and updates based on merged PRs (#5126)
31c2900 
Signed-off-by: Akshay Deo <akshay@akshaydeo.com>
akshaydeo added a commit that referenced this pull request Jul 30, 2026
@akshaydeo
dds new harness skill and updates based on merged PRs (#5126)
d604933 
Signed-off-by: Akshay Deo <akshay@akshaydeo.com>
akhsaul pushed a commit to akhsaul/bifrost that referenced this pull request Aug 27, 2026
@akshaydeo
dds new harness skill and updates based on merged PRs (maximhq#5126)
3481a5a 
Signed-off-by: Akshay Deo <akshay@akshaydeo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes
@danpiths danpiths Awaiting requested review from danpiths
@roroghost17 roroghost17 Awaiting requested review from roroghost17

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akshaydeo @CLAassistant