Skip to content

refactor: move the logs cost calculation to sidekiq - #4934

Closed
impoiler wants to merge 1 commit into
07-07-feat_respect_sidekiq_over_clusteringfrom
07-06-refactor_move_the_logs_cost_calculation_to_sidekiq
Closed

refactor: move the logs cost calculation to sidekiq#4934
impoiler wants to merge 1 commit into
07-07-feat_respect_sidekiq_over_clusteringfrom
07-06-refactor_move_the_logs_cost_calculation_to_sidekiq

Conversation

@impoiler

@impoiler impoiler commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Summary

Briefly explain the purpose of this PR and the problem it solves.

Changes

  • What was changed and why
  • Any notable design decisions or trade-offs

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore/CI

Affected areas

  • Core (Go)
  • Transports (HTTP)
  • Providers/Integrations
  • Plugins
  • UI (React)
  • Docs

How to test

Describe the steps to validate this change. Include commands and expected outcomes.

# Core/Transports
go version
go test ./...

# UI
cd ui
pnpm i || npm i
pnpm test || npm test
pnpm build || npm run build

If adding new configs or environment variables, document them here.

Screenshots/Recordings

If UI changes, add before/after screenshots or short clips.

Breaking changes

  • Yes
  • No

If yes, describe impact and migration instructions.

Related issues

Link related issues and discussions. Example: Closes #123

Security considerations

Note any security implications (auth, secrets, PII, sandboxing, etc.).

Checklist

  • I read docs/contributing/README.md and followed the guidelines
  • I added/updated tests where appropriate
  • I updated documentation where needed
  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

@coderabbitai

coderabbitai Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: db765401-adba-47f3-a6fa-094cf8f9e9f9

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 07-06-refactor_move_the_logs_cost_calculation_to_sidekiq

Comment @coderabbitai help to get the list of available commands.

impoiler commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@impoiler
impoiler force-pushed the 07-06-refactor_move_the_logs_cost_calculation_to_sidekiq branch 3 times, most recently from 6534081 to 69989b2 Compare July 7, 2026 08:34
@impoiler
impoiler changed the base branch from dev to graphite-base/4934 July 7, 2026 11:52
@impoiler
impoiler force-pushed the 07-06-refactor_move_the_logs_cost_calculation_to_sidekiq branch from 69989b2 to 639ca38 Compare July 7, 2026 11:52
@impoiler
impoiler changed the base branch from graphite-base/4934 to 07-07-feat_add_sidekiq_job_runner July 7, 2026 11:52
@BearTS
BearTS changed the base branch from 07-07-feat_add_sidekiq_job_runner to graphite-base/4934 July 7, 2026 12:01
@impoiler
impoiler force-pushed the 07-06-refactor_move_the_logs_cost_calculation_to_sidekiq branch from 639ca38 to fbec380 Compare July 7, 2026 13:10
@impoiler
impoiler force-pushed the graphite-base/4934 branch from 05da938 to 6257422 Compare July 7, 2026 13:10
@impoiler
impoiler changed the base branch from graphite-base/4934 to 07-07-feat_add_sidekiq_job_runner July 7, 2026 13:10
@impoiler
impoiler force-pushed the 07-06-refactor_move_the_logs_cost_calculation_to_sidekiq branch from fbec380 to 0bee041 Compare July 7, 2026 13:29
@impoiler
impoiler changed the base branch from 07-07-feat_add_sidekiq_job_runner to graphite-base/4934 July 7, 2026 13:31
@impoiler
impoiler force-pushed the 07-06-refactor_move_the_logs_cost_calculation_to_sidekiq branch from 0bee041 to 7ebbbe7 Compare July 7, 2026 13:31
@impoiler
impoiler changed the base branch from graphite-base/4934 to 07-07-feat_respect_sidekiq_over_clustering July 7, 2026 13:31
@impoiler impoiler self-assigned this Jul 7, 2026
@impoiler impoiler closed this Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Files API Support

1 participant