fix: match model filter on canonical_model_name and restore routing info for cost recalc

[impoiler]

Summary

Model filtering in the log store only matched against the wire model column, so filtering by a canonical model name (e.g. gpt-4o-mini) would miss requests routed through an alias whose wire model differed. Similarly, cost recalculation for stored logs dropped the canonical model name, causing pricing lookups to fail and return null costs for those entries.

Changes

• Updated applyFilters in rdb.go to match against both model and canonical_model_name when filtering by model, so alias-routed requests surface correctly under their canonical name.
• In calculateCostForLog, the RoutingInfo field is now populated with provider and model from the log entry. When a canonical_model_name is present, a ResolvedKeyAlias is reconstructed so that cost recalculation has the same routing context that live logging used, preventing null costs.

Type of change

• Bug fix
• Feature
• Refactor
• Documentation
• Chore/CI

Affected areas

• Core (Go)
• Transports (HTTP)
• Providers/Integrations
• Plugins
• UI (React)
• Docs

How to test

1. Create a key alias that maps to a model with a different wire model name (e.g. an alias for gpt-4o-mini that routes to a provider-specific wire model).
2. Send a request through that alias and confirm the log entry is stored with both model and canonical_model_name populated.
3. Filter logs by the canonical model name and verify the aliased request appears in results.
4. Trigger a cost recalculation for that log entry and confirm a non-null cost is returned.

go test ./framework/logstore/...
go test ./plugins/logging/...

Screenshots/Recordings

N/A

Breaking changes

• Yes
• No

Related issues

N/A

Security considerations

No security implications. Changes are scoped to log filtering and cost recalculation logic.

Checklist

• I read docs/contributing/README.md and followed the guidelines
• I added/updated tests where appropriate
• I updated documentation where needed
• I verified builds succeed (Go and UI)
• I verified the CI pipeline passes locally if applicable

[coderabbitai]

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 43 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: c23d21ed-1fbe-4103-803b-e60fac25775c

📥 Commits

Reviewing files that changed from the base of the PR and between ca6e660 and 838e2d5.

📒 Files selected for processing (3)

• framework/logstore/migrations.go
• framework/logstore/rdb.go
• plugins/logging/operations.go

📝 Walkthrough

Walkthrough

Log storage now indexes canonical model names, log filtering matches either wire model or canonical model name, and cost recalculation now rebuilds routing info from stored canonical model data.

Changes

Canonical Model Name Handling

Layer / File(s)	Summary
Log storage index for canonical model framework/logstore/migrations.go	performanceIndexes adds idx_logs_canonical_model_name on logs(canonical_model_name) with a non-null predicate.
Log filter includes canonical model name framework/logstore/rdb.go	applyFilters extends the Models predicate to match either model or canonical_model_name.
Cost calculation reconstructs routing info plugins/logging/operations.go	calculateCostForLog populates RoutingInfo with provider and requested model, and reconstructs ResolvedKeyAlias from stored CanonicalModelName.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers: akshaydeo, danpiths, roroghost17

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title is concise and accurately captures the main changes to model filtering and cost recalculation.
Description check	✅ Passed	The description follows the template and includes summary, changes, type, affected areas, testing, breaking changes, security, and checklist sections.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 07-08-feat_consider_canonical_model_name_as_fallback_into_filters_and_recalculation

---

_{Comment @coderabbitai help to get the list of available commands.}

[impoiler]

• feat: add object storage archival docs for audit logs #4992
• feat: add S3/GCS object storage config schema for audit log archival #4991
• feat: add schema_url/BIFROST_SCHEMA_URL support for mirrored schema locations in isolated deployments #4614
• fix: preserve active time period when applying dimension filters #5030
• fix: match model filter on canonical_model_name and restore routing info for cost recalc #5029 👈 (View in Graphite)
• feat: replace SSE streaming with background job polling for cost recalculation #5006
• feat: migrate cost recalculation to durable background sidekiq job with resume and dedup #5005
• feat: add GetInFlightSidekiqJobByKind to config store interface #5004
• feat: add durable background-job sidekiq table, store methods, and runner with recovery and reaper #4989 : 1 other dependent PR (#5000 )
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

[greptile-apps]

Confidence Score: 5/5

Safe to merge — both bug fixes are logically correct, the new index is non-blocking (CONCURRENTLY + partial), and the RoutingInfo reconstruction preserves the same candidate order resolvePricing used at live-log time.

The OR predicate in applyFilters is correctly grouped and backed by an appropriate partial index. The ResolvedKeyAlias reconstruction in calculateCostForLog accurately mirrors the live-logging path for entries that have a canonical model name. No data correctness, concurrency, or security issues were found in the changed code.

plugins/logging/operations.go — the CanonicalModelName reconstruction path has no dedicated test, so a future change to resolvePricing candidate ordering could silently regress the fix.

Important Files Changed

Filename	Overview
framework/logstore/rdb.go	Adds OR predicate (model IN ? OR canonical_model_name IN ?) so model filters match alias-routed requests by canonical name; parens preserve correct GORM AND grouping.
framework/logstore/migrations.go	Appends idx_logs_canonical_model_name as a concurrent partial index (WHERE canonical_model_name IS NOT NULL), enabling BitmapOr plans alongside idx_logs_model without blocking writes.
plugins/logging/operations.go	Populates RoutingInfo and conditionally reconstructs ResolvedKeyAlias (with ModelID = wire model and ModelName = canonical name) for cost recalculation; fixes null costs for canonical-name alias entries but no new tests cover this path.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[SearchLogs / applyFilters] -->|filters.Models set| B{"model IN filters.Models?"}
    B -->|yes| C[Row matches]
    B -->|no| D{"canonical_model_name IN filters.Models?"}
    D -->|yes| C
    D -->|no| E[Row excluded]

    F[calculateCostForLog] --> G[Build RoutingInfo\nProvider + Model]
    G --> H{"CanonicalModelName != nil?"}
    H -->|yes| I[Reconstruct ResolvedKeyAlias\nModelID=wire_model\nModelName=canonical]
    H -->|no| J[ResolvedKeyAlias stays nil]
    I --> K[resolvePricing candidates:\n1. canonical name\n2. wire model\n3. alias key]
    J --> L[resolvePricing candidates:\n1. alias key only]
    K --> M[Cost resolved]
    L --> N[May return nil cost\nif alias key not in catalog]

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    A[SearchLogs / applyFilters] -->|filters.Models set| B{"model IN filters.Models?"}
    B -->|yes| C[Row matches]
    B -->|no| D{"canonical_model_name IN filters.Models?"}
    D -->|yes| C
    D -->|no| E[Row excluded]

    F[calculateCostForLog] --> G[Build RoutingInfo\nProvider + Model]
    G --> H{"CanonicalModelName != nil?"}
    H -->|yes| I[Reconstruct ResolvedKeyAlias\nModelID=wire_model\nModelName=canonical]
    H -->|no| J[ResolvedKeyAlias stays nil]
    I --> K[resolvePricing candidates:\n1. canonical name\n2. wire model\n3. alias key]
    J --> L[resolvePricing candidates:\n1. alias key only]
    K --> M[Cost resolved]
    L --> N[May return nil cost\nif alias key not in catalog]

Loading

_{Reviews (12): Last reviewed commit: "feat: consider canonical_model_name as f..." | Re-trigger Greptile}

[Pratham-Mishra04]

Merge activity

• Jul 9, 12:16 PM UTC: A user started a stack merge that includes this pull request via Graphite.
• Jul 9, 12:31 PM UTC: Graphite rebased this pull request as part of a merge.
• Jul 9, 12:32 PM UTC: @Pratham-Mishra04 merged this pull request with Graphite.

The base branch was changed.