feat: expose skills repository navigation and access state

[danpiths]

Summary

Exposes Skills Repository in the workspace navigation and wires frontend access
state so the page is only visible/usable to users with SkillsRepository:View
permission.

Changes

• Added a page-level SkillsRepository:View guard for /workspace/skills-repo,
  rendering NoPermissionView when access is denied.
• Added the Skills Repository sidebar item under the DB-backed repository
  section, gated by is_db_connected and SkillsRepository:View.
• Updated OSS fallback enterprise RBAC resource handling for Skills Repository.
• Updated frontend config types and schema to include backend-provided
  is_git_available.

Type of change

• Bug fix
• Feature
• Refactor
• Documentation
• Chore/CI

Affected areas

• Core (Go)
• Transports (HTTP)
• Providers/Integrations
• Plugins
• UI (React)
• Docs

How to test

Validated with:

# From bifrost/ui
direnv exec . npm run build

Expected outcome: the UI production build completes successfully.

Recommended manual UI verification before merge:

1. Sign in with a role that has SkillsRepository:View and confirm the sidebar
   item and page are visible.
2. Sign in with a role without SkillsRepository:View and confirm the sidebar
   item is hidden and the route guard blocks access.
3. Confirm the Skills Repository page still renders when access is allowed.

No new automated tests were added; this PR was validated through the UI build
and manual RBAC/navigation checks.

No new configs or environment variables are added in this PR.

Screenshots/Recordings

UI changes include the workspace sidebar entry and no-permission behavior for
Skills Repository. Screenshots should be added before submitting if required by
review.

Breaking changes

• Yes
• No

Related issues

N/A

Security considerations

This adds frontend gating only. Backend route protection remains enforced by the
server and enterprise RBAC middleware; the UI guard is not treated as the source
of authorization truth.

Checklist

• I read docs/contributing/README.md and followed the guidelines
• I added/updated tests where appropriate
• I updated documentation where needed
• I verified builds succeed (Go and UI)
• I verified the CI pipeline passes locally if applicable

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: e68fc4e0-0be6-4b6a-9d85-05610cbf2600

📥 Commits

Reviewing files that changed from the base of the PR and between 5f3cb4a and a8da75e.

📒 Files selected for processing (5)

• ui/app/_fallbacks/enterprise/lib/contexts/rbacContext.tsx
• ui/app/workspace/skills-repo/layout.tsx
• ui/components/sidebar.tsx
• ui/lib/types/config.ts
• ui/lib/types/schemas.ts

💤 Files with no reviewable changes (5)

• ui/app/workspace/skills-repo/layout.tsx
• ui/lib/types/schemas.ts
• ui/lib/types/config.ts
• ui/app/_fallbacks/enterprise/lib/contexts/rbacContext.tsx
• ui/components/sidebar.tsx

---

📝 Walkthrough

Summary by CodeRabbit

• New Features

  • Added Skills Repository section to workspace navigation, highlighted with "New" badge and access controlled by permissions.
  • Extended navigation items with "New" badge capability for highlighting recently added features.

• Configuration

  • Added git availability status flag to system configuration.

Walkthrough

Adds RbacResource.SkillsRepository, a guarded /workspace/skills-repo file route, sidebar "New" badge support and a gated "Skills Repository" menu item, and a new is_git_available config/schema flag.

Changes

Skills Repository Feature with RBAC, Config, and Sidebar Integration

Layer / File(s)	Summary
RBAC and context updates ui/app/_fallbacks/enterprise/lib/contexts/rbacContext.tsx	RbacResource enum adds SkillsRepository; OSS dummy RBAC provider and hooks remain functionally unchanged (formatting/wrapping changes).
Skills Repository route with RBAC enforcement ui/app/workspace/skills-repo/layout.tsx	New /workspace/skills-repo file route that checks RbacResource.SkillsRepository View permission and renders SkillsRepoPage or NoPermissionView.
Sidebar framework and RBAC hook ui/components/sidebar.tsx	Adds BookOpenText import, cn and newBadgeClass, extends SidebarItem with new?: boolean, updates main item class template, and introduces hasSkillsRepositoryAccess hook.
Badge rendering, href refinements, and menu integration ui/components/sidebar.tsx	Conditionally renders "New" Badge for top-level and sub-items, reformats preserveTimeFilters calls (no behavior change), adds "Skills Repository" menu item (/workspace/skills-repo, new: true) gated by RBAC, and updates useMemo deps.
Config and schema flag ui/lib/types/config.ts, ui/lib/types/schemas.ts	Add is_git_available: boolean to BifrostConfig; bifrostConfigSchema validates is_git_available as z.boolean().optional().default(false).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

• akshaydeo
• Pratham-Mishra04

Poem

🐰 A skills repository wakes at dawn,
A tiny badge hops proudly on,
RBAC nods as doors unlock,
Git flag set — no stumbling block.
Sidebar shines, the rabbit’s drawn 🥕📚

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 60.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately reflects the main objective of the PR: exposing Skills Repository in workspace navigation and wiring frontend access state/RBAC controls.
Description check	✅ Passed	The description covers all major required template sections: summary, changes, type of change, affected areas, testing approach, breaking changes, security considerations, and a completed checklist.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch 06-10-feat_expose_skills_repository_navigation_and_access_state

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[danpiths]

• feat: removes from_memory handling from API handlers to make them only serve data from DB #4286
• feat: expose skills repository navigation and access state #4234 👈 (View in Graphite)
• feat: add skills repository dashboard #4233
• feat: add config-based skills registry #4232
• feat: add skills management and serving APIs #4231
• feat: add object store prefix listing for skill cleanup #4230
• feat: add skills repository data model and config store support #4229
• chore: update skills repository dependencies and workspace tooling #4228 : 1 other dependent PR (#4287 )
• dev

This stack of pull requests is managed by Graphite. Learn more about stacking.

[greptile-apps]

Confidence Score: 5/5

Safe to merge — all UI changes follow established patterns and the RBAC guard is correctly wired

The route guard, sidebar gating, enum addition, and schema update all follow patterns already in use throughout the workspace. No logic regressions were identified in the changed files.

transports/go.mod adds go-git as a direct dependency; the backend source files that import it are not in this PR's diff and should be confirmed reviewed in the prior commits that introduced them

Important Files Changed

Filename	Overview
ui/app/workspace/skills-repo/layout.tsx	New route file adding RBAC guard for Skills Repository page; follows the exact same pattern as rbac/layout.tsx
ui/components/sidebar.tsx	Adds Skills Repository sidebar item gated by isDbConnected and hasSkillsRepositoryAccess, and introduces new optional badge field with animation; dependency array updated correctly
ui/app/_fallbacks/enterprise/lib/contexts/rbacContext.tsx	Adds SkillsRepository to the OSS fallback RbacResource enum; rest of the change is indentation reformatting only
ui/lib/types/config.ts	Adds is_git_available: boolean to BifrostConfig; consistent with the Zod schema's .optional().default(false) since parsed output is always boolean
ui/lib/types/schemas.ts	Adds is_git_available as optional with default false to the bifrostConfigSchema, ensuring backward-compat with backends that don't yet emit the field
transports/go.mod	Promotes go-git/go-billy to direct dependencies and adds ~15 transitive packages; no corresponding backend Go source changes are visible in this PR's diff

_{Reviews (44): Last reviewed commit: "feat: expose skills repository navigatio..." | Re-trigger Greptile}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@ui/components/sidebar.tsx`:
- Around line 562-566: The sub-item badge in the expanded submenu is missing the
data-new-badge attribute and the custom class prop used elsewhere; update the
badge rendering for subItem (the conditional that renders <Badge
className="ml-auto">New</Badge>) to include data-new-badge="true" and apply the
existing newBadgeClassName (merge with "ml-auto" or replace as appropriate) so
it matches the top-level and flyout sub-item badges and receives the shine
animation.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 0dae1f57-28bb-4b21-98d7-03bc6d1df734

📥 Commits

Reviewing files that changed from the base of the PR and between 089771f and ba8d9d7.

📒 Files selected for processing (5)

• ui/app/_fallbacks/enterprise/lib/contexts/rbacContext.tsx
• ui/app/workspace/skills-repo/layout.tsx
• ui/components/sidebar.tsx
• ui/lib/types/config.ts
• ui/lib/types/schemas.ts

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

ui/components/sidebar.tsx (1)

1132-1162: 🧹 Nitpick | 🔵 Trivial | ⚡ Quick win

Missing hasFeatureFlagsAccess in useMemo dependency array.

The hasFeatureFlagsAccess hook is declared at line 739-742 and used in the items array at line 1127 for the Feature Flags sub-item, but it's not included in the useMemo dependency array. When this permission changes, the sidebar items won't recompute, potentially showing stale access state.

Since this PR is already adding hasSkillsRepositoryAccess to the dependency array, it's a good opportunity to include the missing hasFeatureFlagsAccess as well.

♻️ Proposed fix to complete the dependency array

     hasSettingsAccess,
     hasPromptRepositoryAccess,
     hasSkillsRepositoryAccess,
     hasAccessProfilesAccess,
     isDbConnected,
+    hasFeatureFlagsAccess,
   ],
 );

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ui/components/sidebar.tsx` around lines 1132 - 1162, The useMemo that builds
the sidebar items (the items array used in the sidebar component) is missing
hasFeatureFlagsAccess in its dependency list, so update the useMemo dependency
array to include hasFeatureFlagsAccess (alongside the already-added
hasSkillsRepositoryAccess and the other permission flags) to ensure the Feature
Flags sub-item recomputes when its permission changes; locate the useMemo that
returns items and add hasFeatureFlagsAccess to that dependency array.

♻️ Duplicate comments (1)

ui/components/sidebar.tsx (1)

562-566: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Inconsistent badge styling in expanded submenu sub-items.

This badge rendering is missing data-new-badge="true" and the newBadgeClassName that the other two badge locations (lines 316-326 for top-level items, lines 474-481 for flyout sub-items) include. Without these, the shine animation defined in newBadgeClassName won't apply to badges in the expanded submenu, creating visual inconsistency.

🐛 Proposed fix for consistent badge styling

 {subItem.new && (
-  <Badge className="ml-auto">
+  <Badge
+    data-new-badge="true"
+    className={cn("ml-auto", newBadgeClassName)}
+  >
     New
   </Badge>
 )}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ui/components/sidebar.tsx` around lines 562 - 566, The expanded submenu badge
rendering for subItem (inside ui/components/sidebar.tsx) is missing the data
attribute and class used elsewhere, so add data-new-badge="true" and apply the
same newBadgeClassName used for top-level items and flyout sub-items to the
Badge for expanded sub-items (the Badge rendered for subItem.new) so the shine
animation is consistent; locate the Badge instance inside the expanded submenu
rendering and update it to include data-new-badge="true" and the existing
newBadgeClassName prop/variable.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@ui/components/sidebar.tsx`:
- Around line 1132-1162: The useMemo that builds the sidebar items (the items
array used in the sidebar component) is missing hasFeatureFlagsAccess in its
dependency list, so update the useMemo dependency array to include
hasFeatureFlagsAccess (alongside the already-added hasSkillsRepositoryAccess and
the other permission flags) to ensure the Feature Flags sub-item recomputes when
its permission changes; locate the useMemo that returns items and add
hasFeatureFlagsAccess to that dependency array.

---

Duplicate comments:
In `@ui/components/sidebar.tsx`:
- Around line 562-566: The expanded submenu badge rendering for subItem (inside
ui/components/sidebar.tsx) is missing the data attribute and class used
elsewhere, so add data-new-badge="true" and apply the same newBadgeClassName
used for top-level items and flyout sub-items to the Badge for expanded
sub-items (the Badge rendered for subItem.new) so the shine animation is
consistent; locate the Badge instance inside the expanded submenu rendering and
update it to include data-new-badge="true" and the existing newBadgeClassName
prop/variable.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: fe64f931-6456-45fa-be1c-53372dc6ad16

📥 Commits

Reviewing files that changed from the base of the PR and between ba8d9d7 and bd75352.

📒 Files selected for processing (5)

• ui/app/_fallbacks/enterprise/lib/contexts/rbacContext.tsx
• ui/app/workspace/skills-repo/layout.tsx
• ui/components/sidebar.tsx
• ui/lib/types/config.ts
• ui/lib/types/schemas.ts

[coderabbitai]

♻️ Duplicate comments (1)

ui/components/sidebar.tsx (1)

562-566: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Badge styling inconsistency still present (duplicate).

The expanded submenu sub-item badge is missing data-new-badge="true" and the newBadgeClassName that the other two badge locations (lines 316-326 for top-level items, lines 474-481 for flyout sub-items) include. The shine animation won't apply here.

This was flagged in a previous review and marked as addressed, but the current code still shows the incomplete styling.

🐛 Proposed fix for consistent badge styling

 {subItem.new && (
-  <Badge className="ml-auto">
+  <Badge
+    data-new-badge="true"
+    className={cn("ml-auto", newBadgeClassName)}
+  >
     New
   </Badge>
 )}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ui/components/sidebar.tsx` around lines 562 - 566, The expanded submenu's
"New" Badge rendering (the block checking subItem.new) is missing the
data-new-badge="true" attribute and the shared newBadgeClassName styling; update
that Badge to include data-new-badge="true" and combine its className with
newBadgeClassName (e.g., preserve "ml-auto" and merge newBadgeClassName) so it
matches the other Badge instances; reference the Badge element inside the
subItem.new conditional and the newBadgeClassName variable to locate and fix the
code.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Duplicate comments:
In `@ui/components/sidebar.tsx`:
- Around line 562-566: The expanded submenu's "New" Badge rendering (the block
checking subItem.new) is missing the data-new-badge="true" attribute and the
shared newBadgeClassName styling; update that Badge to include
data-new-badge="true" and combine its className with newBadgeClassName (e.g.,
preserve "ml-auto" and merge newBadgeClassName) so it matches the other Badge
instances; reference the Badge element inside the subItem.new conditional and
the newBadgeClassName variable to locate and fix the code.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c08733c9-c8d9-42d4-977b-053ceb29ff7d

📥 Commits

Reviewing files that changed from the base of the PR and between bd75352 and 6c2cbec.

📒 Files selected for processing (5)

• ui/app/_fallbacks/enterprise/lib/contexts/rbacContext.tsx
• ui/app/workspace/skills-repo/layout.tsx
• ui/components/sidebar.tsx
• ui/lib/types/config.ts
• ui/lib/types/schemas.ts

[coderabbitai]

♻️ Duplicate comments (1)

ui/components/sidebar.tsx (1)

562-566: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Expanded submenu badge still missing styling attributes (duplicate issue).

The Badge at lines 562-566 lacks data-new-badge="true" and newBadgeClassName that are present in the top-level badge (lines 318-321) and flyout sub-item badge (lines 476-478). Without these, the shine animation defined in newBadgeClassName (line 95-96) will not apply here, creating an inconsistent visual experience.

This was flagged in a previous review and marked as addressed, but the current code still shows the issue.

🐛 Proposed fix for consistent badge styling

 {subItem.new && (
-  <Badge className="ml-auto">
+  <Badge
+    data-new-badge="true"
+    className={cn("ml-auto", newBadgeClassName)}
+  >
     New
   </Badge>
 )}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ui/components/sidebar.tsx` around lines 562 - 566, The expanded submenu Badge
rendering for subItem.new (in ui/components/sidebar.tsx) is missing the
data-new-badge="true" attribute and the newBadgeClassName prop; update the JSX
where Badge is rendered for subItem.new (the block containing {subItem.new &&
(<Badge ...>New</Badge>)}) to include data-new-badge="true" and pass
newBadgeClassName (the same class prop used on the top-level badge and flyout
sub-item badge) so the shine animation applies consistently.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Duplicate comments:
In `@ui/components/sidebar.tsx`:
- Around line 562-566: The expanded submenu Badge rendering for subItem.new (in
ui/components/sidebar.tsx) is missing the data-new-badge="true" attribute and
the newBadgeClassName prop; update the JSX where Badge is rendered for
subItem.new (the block containing {subItem.new && (<Badge ...>New</Badge>)}) to
include data-new-badge="true" and pass newBadgeClassName (the same class prop
used on the top-level badge and flyout sub-item badge) so the shine animation
applies consistently.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: c6fde5d2-4662-46a2-a934-cf91e1a417eb

📥 Commits

Reviewing files that changed from the base of the PR and between 6c2cbec and 5f3cb4a.

📒 Files selected for processing (5)

• ui/app/_fallbacks/enterprise/lib/contexts/rbacContext.tsx
• ui/app/workspace/skills-repo/layout.tsx
• ui/components/sidebar.tsx
• ui/lib/types/config.ts
• ui/lib/types/schemas.ts

[coderabbitai]

♻️ Duplicate comments (1)

ui/components/sidebar.tsx (1)

562-566: ⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Inconsistent badge styling in expanded submenu sub-items (duplicate).

This badge rendering is missing data-new-badge="true" and newBadgeClassName that the other two badge locations (lines 316-326 for top-level items, lines 474-481 for flyout sub-items) include. The shine animation won't apply here.

🐛 Proposed fix for consistent badge styling

 {subItem.new && (
-  <Badge className="ml-auto">
+  <Badge
+    data-new-badge="true"
+    className={cn("ml-auto", newBadgeClassName)}
+  >
     New
   </Badge>
 )}

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@ui/components/sidebar.tsx` around lines 562 - 566, The expanded submenu
sub-item badge rendering (when subItem.new is true) is missing the
data-new-badge="true" attribute and the newBadgeClassName applied elsewhere;
update the Badge usage inside the expanded submenu (the branch that checks
subItem.new) to include data-new-badge="true" and pass the newBadgeClassName
prop/class to match the other Badge usages (same pattern as the top-level Badge
and flyout sub-item Badge), ensuring consistent styling and the shine animation
is applied.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Duplicate comments:
In `@ui/components/sidebar.tsx`:
- Around line 562-566: The expanded submenu sub-item badge rendering (when
subItem.new is true) is missing the data-new-badge="true" attribute and the
newBadgeClassName applied elsewhere; update the Badge usage inside the expanded
submenu (the branch that checks subItem.new) to include data-new-badge="true"
and pass the newBadgeClassName prop/class to match the other Badge usages (same
pattern as the top-level Badge and flyout sub-item Badge), ensuring consistent
styling and the shine animation is applied.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6988d5c1-6cde-48f2-8da8-6ef73106f25e

📥 Commits

Reviewing files that changed from the base of the PR and between 5f3cb4a and cf6ff45.

📒 Files selected for processing (5)

• ui/app/_fallbacks/enterprise/lib/contexts/rbacContext.tsx
• ui/app/workspace/skills-repo/layout.tsx
• ui/components/sidebar.tsx
• ui/lib/types/config.ts
• ui/lib/types/schemas.ts

[akshaydeo]

Merge activity

• Jun 15, 4:44 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• Jun 15, 4:49 AM UTC: Graphite couldn't merge this PR because it had merge conflicts.
• Jun 15, 4:56 AM UTC: A user started a stack merge that includes this pull request via Graphite.
• Jun 15, 4:57 AM UTC: @akshaydeo merged this pull request with Graphite.