chore: update skills repository dependencies and workspace tooling - #4228
Merged
akshaydeo merged 1 commit intoJun 11, 2026
Conversation
|
|
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 9, 2026
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (20)
📒 Files selected for processing (8)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThis PR updates indirect and direct Go module dependencies across the repository (CLI, plugins, test modules, and transports), introduces a Nix flake overlay to pin Go 1.26.4, and refactors UI build tooling to use a standalone TypeScript type-check npm script instead of a Vite plugin. ChangesDependency and Build Environment Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies" Comment |
Contributor
Confidence Score: 5/5Safe to merge — all changes are dependency/tooling metadata with no runtime logic modifications. Every file touched is a go.mod, go.sum, flake.nix/lock, package.json, package-lock.json, or vite.config reformatting. The only behavioural change is replacing the vite-plugin-checker plugin with an explicit tsc --noEmit step, which now gates both build paths including build-enterprise, closing a previously noted gap. No application logic, handler, provider, plugin, or migration code is modified. The new go-git/go-billy direct dependencies are declared here as groundwork but no code in this PR exercises them. No files require special attention. Important Files Changed
Reviews (4): Last reviewed commit: "chore: update skills repository dependen..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
transports/go.mod (1)
155-155:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winCritical: Merge conflict marker left in go.mod.
Line 155 contains a Git merge conflict marker
; indirect<<<<<<< HEADthat will prevent the module from being parsed correctly by Go tooling.🔧 Proposed fix
- github.com/mattn/go-sqlite3 v1.14.32 // indirect; indirect<<<<<<< HEAD + github.com/mattn/go-sqlite3 v1.14.32 // indirect🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@transports/go.mod` at line 155, The go.mod contains a leftover merge marker in the module requirement for github.com/mattn/go-sqlite3; remove the conflict text `<<<<<<< HEAD` so the requirement reads correctly (e.g., `github.com/mattn/go-sqlite3 v1.14.32 // indirect`) and then run go mod tidy to ensure the file is valid and dependencies are cleaned up; target the module line referencing github.com/mattn/go-sqlite3 when making the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@transports/go.mod`:
- Line 220: Restore the indirect marker on the module line for golang.org/x/text
v0.37.0 in the transports module by adding the trailing comment "// indirect" to
the existing module requirement ("golang.org/x/text v0.37.0"); ensure no other
changes to the go.mod formatting so the entry matches other indirect
dependencies.
In `@ui/vite.config.mts`:
- Around line 15-33: The project still lists vite-plugin-checker in
ui/package.json and package-lock.json despite it being removed from the Vite
config; remove the unused dependency and update the lockfile: delete
vite-plugin-checker from ui/package.json devDependencies, run npm install (or
npm ci) in ui to regenerate ui/package-lock.json, and confirm there are no
remaining imports/usages of the plugin in ui/vite.config.mts (plugins array) or
elsewhere before committing.
---
Outside diff comments:
In `@transports/go.mod`:
- Line 155: The go.mod contains a leftover merge marker in the module
requirement for github.com/mattn/go-sqlite3; remove the conflict text `<<<<<<<
HEAD` so the requirement reads correctly (e.g., `github.com/mattn/go-sqlite3
v1.14.32 // indirect`) and then run go mod tidy to ensure the file is valid and
dependencies are cleaned up; target the module line referencing
github.com/mattn/go-sqlite3 when making the change.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 7a40e8e4-74d9-45ee-9544-ed050ae30001
⛔ Files ignored due to path filters (19)
cli/go.sumis excluded by!**/*.sumcore/go.sumis excluded by!**/*.sumflake.lockis excluded by!**/*.lockframework/go.sumis excluded by!**/*.sumplugins/compat/go.sumis excluded by!**/*.sumplugins/governance/go.sumis excluded by!**/*.sumplugins/jsonparser/go.sumis excluded by!**/*.sumplugins/logging/go.sumis excluded by!**/*.sumplugins/maxim/go.sumis excluded by!**/*.sumplugins/mocker/go.sumis excluded by!**/*.sumplugins/modelcatalogresolver/go.sumis excluded by!**/*.sumplugins/otel/go.sumis excluded by!**/*.sumplugins/prompts/go.sumis excluded by!**/*.sumplugins/semanticcache/go.sumis excluded by!**/*.sumplugins/telemetry/go.sumis excluded by!**/*.sumtests/cmd/e2eseed/go.sumis excluded by!**/*.sumtests/cmd/seed/go.sumis excluded by!**/*.sumtests/cmd/seedvks/go.sumis excluded by!**/*.sumtransports/go.sumis excluded by!**/*.sum
📒 Files selected for processing (10)
cli/go.modflake.nixplugins/governance/go.modplugins/modelcatalogresolver/go.modtests/cmd/e2eseed/go.modtests/cmd/seed/go.modtests/cmd/seedvks/go.modtransports/go.modui/package.jsonui/vite.config.mts
danpiths
force-pushed
the
06-10-chore_update_skills_repository_dependencies_and_workspace_tooling
branch
from
June 10, 2026 05:57
fdcd6f6 to
4c8e557
Compare
Collaborator
Author
|
@coderabbitai review |
Contributor
✅ Action performedReview finished.
|
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
transports/go.mod (1)
155-155:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winRemove merge conflict marker from go.mod
Line 155 contains a malformed comment with a Git merge conflict marker:
// indirect; indirect<<<<<<< HEAD. This will causego mod tidyor build errors.🔧 Fix the malformed comment
- github.com/mattn/go-sqlite3 v1.14.32 // indirect; indirect<<<<<<< HEAD + github.com/mattn/go-sqlite3 v1.14.32 // indirect🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@transports/go.mod` at line 155, Remove the Git merge conflict marker from the module comment on the line containing "github.com/mattn/go-sqlite3 v1.14.32": replace the malformed comment segment "// indirect; indirect<<<<<<< HEAD" with a proper comment (e.g., "// indirect") so the go.mod entry is well-formed, then run go mod tidy to verify the file is clean.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@transports/go.mod`:
- Line 155: Remove the Git merge conflict marker from the module comment on the
line containing "github.com/mattn/go-sqlite3 v1.14.32": replace the malformed
comment segment "// indirect; indirect<<<<<<< HEAD" with a proper comment (e.g.,
"// indirect") so the go.mod entry is well-formed, then run go mod tidy to
verify the file is clean.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: aeb81aca-18d0-449c-b351-22da560c18fa
⛔ Files ignored due to path filters (20)
cli/go.sumis excluded by!**/*.sumcore/go.sumis excluded by!**/*.sumflake.lockis excluded by!**/*.lockframework/go.sumis excluded by!**/*.sumplugins/compat/go.sumis excluded by!**/*.sumplugins/governance/go.sumis excluded by!**/*.sumplugins/jsonparser/go.sumis excluded by!**/*.sumplugins/logging/go.sumis excluded by!**/*.sumplugins/maxim/go.sumis excluded by!**/*.sumplugins/mocker/go.sumis excluded by!**/*.sumplugins/modelcatalogresolver/go.sumis excluded by!**/*.sumplugins/otel/go.sumis excluded by!**/*.sumplugins/prompts/go.sumis excluded by!**/*.sumplugins/semanticcache/go.sumis excluded by!**/*.sumplugins/telemetry/go.sumis excluded by!**/*.sumtests/cmd/e2eseed/go.sumis excluded by!**/*.sumtests/cmd/seed/go.sumis excluded by!**/*.sumtests/cmd/seedvks/go.sumis excluded by!**/*.sumtransports/go.sumis excluded by!**/*.sumui/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (10)
cli/go.modflake.nixplugins/governance/go.modplugins/modelcatalogresolver/go.modtests/cmd/e2eseed/go.modtests/cmd/seed/go.modtests/cmd/seedvks/go.modtransports/go.modui/package.jsonui/vite.config.mts
danpiths
force-pushed
the
06-10-chore_update_skills_repository_dependencies_and_workspace_tooling
branch
from
June 10, 2026 06:27
4c8e557 to
2a806eb
Compare
Collaborator
Author
|
@coderabbitai review |
Contributor
✅ Action performedReview finished.
|
Collaborator
Author
|
@coderabbitai approve |
Contributor
✅ Action performedComments resolved. Approval is disabled; enable |
This was referenced Jun 11, 2026
Closed
danpiths
force-pushed
the
06-10-chore_update_skills_repository_dependencies_and_workspace_tooling
branch
from
June 11, 2026 12:27
2a806eb to
83be55b
Compare
This was referenced Jun 11, 2026
18 tasks
Contributor
Merge activity
|
akshaydeo
deleted the
06-10-chore_update_skills_repository_dependencies_and_workspace_tooling
branch
June 11, 2026 19:15
akshaydeo
pushed a commit
that referenced
this pull request
Jun 12, 2026
…4228) ## Summary Updates workspace dependency and tooling metadata required by the Skills Repository stack, including Go workspace/module version alignment, Nix tooling updates, transport Git-serving dependencies, and UI package metadata. This keeps cross-module dependency churn isolated at the bottom of the Graphite stack so later feature PRs are easier to review. ## Changes - Aligned Go workspace/module metadata across CLI, core, framework, plugins, tests, and transports for the Skills Repository stack. - Added transport-layer Git repository construction dependencies used by later Git-backed marketplace serving work. - Updated Nix flake tooling for the workspace Go toolchain. - Updated UI package/build metadata needed by the dashboard work. - Kept this as a chore-only base PR so subsequent Skills Repository PRs can focus on product/code changes. ## Type of change - [ ] Bug fix - [ ] Feature - [ ] Refactor - [ ] Documentation - [x] Chore/CI ## Affected areas - [x] Core (Go) - [x] Transports (HTTP) - [ ] Providers/Integrations - [x] Plugins - [x] UI (React) - [ ] Docs ## How to test Validated in the Skills Repository stack with: ```sh # From bifrost/ direnv exec . go build ./transports/bifrost-http/... ./framework/configstore/... direnv exec . go test ./transports/bifrost-http/handlers -run 'Test.*Skill' direnv exec . go test ./framework/configstore -count=1 # From bifrost/ui direnv exec . npm run build ``` Expected result: targeted Go build succeeds, Skills HTTP handler tests pass, configstore tests pass, and the UI production build completes successfully. No new configs or environment variables are added in this PR. ## Screenshots/Recordings N/A — no direct UI behavior changes in this PR. ## Breaking changes - [ ] Yes - [x] No If yes, describe impact and migration instructions. ## Related issues N/A ## Security considerations No direct security changes. This PR only updates dependency/tooling metadata. ## Checklist - [x] I read `docs/contributing/README.md` and followed the guidelines - [x] I added/updated tests where appropriate (no new tests required for metadata-only dependency/tooling changes) - [ ] I updated documentation where needed - [x] I verified builds succeed (Go and UI) - [x] I verified the CI pipeline passes locally if applicable <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated Go and third-party dependencies to latest stable versions for improved compatibility and security. * Refined build system configuration to enhance type-checking during the build process. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates workspace dependency and tooling metadata required by the Skills
Repository stack, including Go workspace/module version alignment, Nix tooling
updates, transport Git-serving dependencies, and UI package metadata. This keeps
cross-module dependency churn isolated at the bottom of the Graphite stack so
later feature PRs are easier to review.
Changes
tests, and transports for the Skills Repository stack.
Git-backed marketplace serving work.
focus on product/code changes.
Type of change
Affected areas
How to test
Validated in the Skills Repository stack with:
Expected result: targeted Go build succeeds, Skills HTTP handler tests pass,
configstore tests pass, and the UI production build completes successfully.
No new configs or environment variables are added in this PR.
Screenshots/Recordings
N/A — no direct UI behavior changes in this PR.
Breaking changes
If yes, describe impact and migration instructions.
Related issues
N/A
Security considerations
No direct security changes. This PR only updates dependency/tooling metadata.
Checklist
docs/contributing/README.mdand followed the guidelinesmetadata-only dependency/tooling changes)
Summary by CodeRabbit