fix(helm): use correct templating for mcpClientConfig#2673
fix(helm): use correct templating for mcpClientConfig#2673akshaydeo merged 1 commit intomaximhq:mainfrom
Conversation
0947b18 to
3bc8bd5
Compare
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThis pull request releases Helm chart version 2.0.18 for bifrost, updating the chart version, documentation, and template configuration. The MCP client configuration template was modified to accept camelCase property names while maintaining snake_case output keys. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3bc8bd5 to
b5113d3
Compare
Confidence Score: 5/5Safe to merge — the template fix is correct and well-scoped; only a minor README documentation gap remains. The core change is a targeted, correct fix verified against values.schema.json. The only finding is a missing v2.0.17 changelog entry in the README, which is a P2 documentation concern and does not affect runtime behavior. helm-charts/bifrost/README.md — missing v2.0.17 changelog entry Important Files Changed
Reviews (1): Last reviewed commit: "fix(helm): use correct templating for mc..." | Re-trigger Greptile |
| - `authType` → `auth_type` | ||
| - `oauthConfigId` → `oauth_config_id` | ||
|
|
||
| ### v2.0.16 |
There was a problem hiding this comment.
Missing v2.0.17 changelog entry
The changelog jumps from v2.0.18 directly to v2.0.16, skipping v2.0.17. Since Chart.yaml was previously at 2.0.17, users upgrading from that version will have no entry describing what changed there.
| ### v2.0.16 | |
| ### v2.0.17 | |
| - (add changelog entry for 2.0.17 here) | |
| ### v2.0.16 |
fix(helm): use correct templating for mcpClientConfig (maximhq#2673)
fix(helm): use correct templating for mcpClientConfig (maximhq#2673)
Summary
Fix MCP client values not being rendered into
config.jsonin the Helm ConfigMap due to key-name mismatch.Changes
toolsToExecute→tools_to_executetoolsToAutoExecute→tools_to_auto_executeauthType→auth_typeoauthConfigId→oauth_config_idType of change
Affected areas
How to test
Describe the steps to validate this change. Include commands and expected outcomes.