Skip to content

fix(helm): use correct templating for mcpClientConfig (#2673)#7

Merged
dominictayloruk merged 1 commit intodominictayloruk:initialise-vector-store-fixfrom
maximhq:main
Apr 13, 2026
Merged

fix(helm): use correct templating for mcpClientConfig (#2673)#7
dominictayloruk merged 1 commit intodominictayloruk:initialise-vector-store-fixfrom
maximhq:main

Conversation

@dominictayloruk
Copy link
Copy Markdown
Owner

Summary

Briefly explain the purpose of this PR and the problem it solves.

Changes

  • What was changed and why
  • Any notable design decisions or trade-offs

Type of change

  • Bug fix
  • Feature
  • Refactor
  • Documentation
  • Chore/CI

Affected areas

  • Core (Go)
  • Transports (HTTP)
  • Providers/Integrations
  • Plugins
  • UI (Next.js)
  • Docs

How to test

Describe the steps to validate this change. Include commands and expected outcomes.

# Core/Transports
go version
go test ./...

# UI
cd ui
pnpm i || npm i
pnpm test || npm test
pnpm build || npm run build

If adding new configs or environment variables, document them here.

Screenshots/Recordings

If UI changes, add before/after screenshots or short clips.

Breaking changes

  • Yes
  • No

If yes, describe impact and migration instructions.

Related issues

Link related issues and discussions. Example: Closes maximhq#123

Security considerations

Note any security implications (auth, secrets, PII, sandboxing, etc.).

Checklist

  • I read docs/contributing/README.md and followed the guidelines
  • I added/updated tests where appropriate
  • I updated documentation where needed
  • I verified builds succeed (Go and UI)
  • I verified the CI pipeline passes locally if applicable

@dominictayloruk dominictayloruk merged commit 898e16c into dominictayloruk:initialise-vector-store-fix Apr 13, 2026
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Bifrost Helm chart to version 2.0.18, primarily fixing the MCP client configuration template to correctly map camelCase Helm values to snake_case configuration keys. Feedback indicates that the metadata for the new entry in index.yaml is inconsistent with Chart.yaml regarding maintainers, icons, and keywords, and should be synchronized.

Comment thread helm-charts/index.yaml
Comment on lines +4 to +24
- apiVersion: v2
appVersion: 1.4.11
created: "2026-04-13T12:00:00.000000+00:00"
description: A Helm chart for deploying Bifrost - AI Gateway with unified interface for multiple providers
digest: ""
home: https://www.getmaxim.ai/bifrost
icon: https://www.getmaxim.ai/bifrost/bifrost-logo-only.png
keywords:
- ai
- gateway
- llm
maintainers:
- email: akshay@getmaxim.ai
name: Bifrost Team
name: bifrost
sources:
- https://github.com/maximhq/bifrost
type: application
urls:
- https://maximhq.github.io/bifrost/helm-charts/bifrost-2.0.18.tgz
version: 2.0.18
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The metadata for the new entry in index.yaml (version 2.0.18) is inconsistent with the metadata defined in helm-charts/bifrost/Chart.yaml. Specifically:

  • Maintainers: index.yaml uses akshay@getmaxim.ai while Chart.yaml uses support@getbifrost.ai.
  • Icon: index.yaml uses https://www.getmaxim.ai/bifrost/bifrost-logo-only.png while Chart.yaml uses https://www.getbifrost.ai/favicon.png.
  • Keywords: index.yaml is missing openai and anthropic which are present in Chart.yaml.

It is recommended to regenerate the index.yaml file using helm repo index or manually synchronize these fields to ensure consistency across the repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants