fix(helm): use correct templating for mcpClientConfig (#2673)#7
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Bifrost Helm chart to version 2.0.18, primarily fixing the MCP client configuration template to correctly map camelCase Helm values to snake_case configuration keys. Feedback indicates that the metadata for the new entry in index.yaml is inconsistent with Chart.yaml regarding maintainers, icons, and keywords, and should be synchronized.
| - apiVersion: v2 | ||
| appVersion: 1.4.11 | ||
| created: "2026-04-13T12:00:00.000000+00:00" | ||
| description: A Helm chart for deploying Bifrost - AI Gateway with unified interface for multiple providers | ||
| digest: "" | ||
| home: https://www.getmaxim.ai/bifrost | ||
| icon: https://www.getmaxim.ai/bifrost/bifrost-logo-only.png | ||
| keywords: | ||
| - ai | ||
| - gateway | ||
| - llm | ||
| maintainers: | ||
| - email: akshay@getmaxim.ai | ||
| name: Bifrost Team | ||
| name: bifrost | ||
| sources: | ||
| - https://github.com/maximhq/bifrost | ||
| type: application | ||
| urls: | ||
| - https://maximhq.github.io/bifrost/helm-charts/bifrost-2.0.18.tgz | ||
| version: 2.0.18 |
There was a problem hiding this comment.
The metadata for the new entry in index.yaml (version 2.0.18) is inconsistent with the metadata defined in helm-charts/bifrost/Chart.yaml. Specifically:
- Maintainers:
index.yamlusesakshay@getmaxim.aiwhileChart.yamlusessupport@getbifrost.ai. - Icon:
index.yamluseshttps://www.getmaxim.ai/bifrost/bifrost-logo-only.pngwhileChart.yamluseshttps://www.getbifrost.ai/favicon.png. - Keywords:
index.yamlis missingopenaiandanthropicwhich are present inChart.yaml.
It is recommended to regenerate the index.yaml file using helm repo index or manually synchronize these fields to ensure consistency across the repository.
Summary
Briefly explain the purpose of this PR and the problem it solves.
Changes
Type of change
Affected areas
How to test
Describe the steps to validate this change. Include commands and expected outcomes.
If adding new configs or environment variables, document them here.
Screenshots/Recordings
If UI changes, add before/after screenshots or short clips.
Breaking changes
If yes, describe impact and migration instructions.
Related issues
Link related issues and discussions. Example: Closes maximhq#123
Security considerations
Note any security implications (auth, secrets, PII, sandboxing, etc.).
Checklist
docs/contributing/README.mdand followed the guidelines